Use asymptotically efficient immutable Vector in many places in the VM #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
Collaborator
|
yeah so this is definitely not going to be able to land as-is. specifically, literally every addon that ever interfaces with lists is going to brick really really hard if we go through with the listiota change. we definitely want to land up to ~378a2fe, but further than that should block on a major version bump |
Collaborator
|
[hand to earpiece] nvm i am being told there are no 1.21 addons. rejoice |
Member
|
There aren't any 1.21 addons, but we still shouldn't merge breaking changes like this into main for now, since main is still on 1.20. |
object-Object
force-pushed
the
main
branch
4 times, most recently
from
107cf95 to
7202ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #804
Supercedes #813
See also #815
We've done tests to make sure things don't completely break (btw there was a Thoth's bug in #813 that we had to fix) but obviously we don't have the manpower to test every Hex ever written.