<fix>(build): update dependencies version, add UT with AI. #945

kyonRay · 2025-11-07T02:52:43Z

No description provided.

* Initial plan * Initial setup: Upgrade Gradle to 7.6.4 for Java 17 compatibility and fix duplicate resources handling Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for model classes and exceptions to improve coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add more unit tests for model and enum classes to increase coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for crypto exception classes to increase coverage Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Downgrade Gradle version to 6.3 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com>

* Initial plan * Add unit tests for client and transaction packages - part 1 Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add more unit tests for client protocol response and transaction dto classes Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add unit tests for LogFilterRequest, model BO classes and CommonConstant Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Fix ResultCodeEnumTest to avoid mutating enum state in tests Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com>

…codec classes (#4) * Initial plan * Add comprehensive tests for ByteUtils, ThreadPoolService, SystemInformation, SecureRandomUtils, and LinuxSecureRandom Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Add comprehensive tests for JsonRpcRequest and TopicTools Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> * Address code review feedback - fix resource cleanup and remove redundant tests Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kyonRay <32325790+kyonRay@users.noreply.github.com>

sonarqubecloud · 2025-11-13T02:44:53Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull Request Overview

This PR updates dependencies to newer versions, adds comprehensive unit tests generated by AI, and makes several improvements to the codebase including timeout handling and ObjectMapper configuration updates.

Key Changes:

Dependency Updates: Upgraded Jackson (2.14.3 → 2.20.1), Commons IO (2.11.0 → 2.20.0), and Commons Lang3 (3.12.0 → 3.19.0)
Test Coverage: Added 50+ unit test files covering exceptions, models, utilities, and transaction components
Code Improvements: Enhanced ObjectMapper configuration, added timeout handling in ClientImpl, and removed unused imports

Reviewed Changes

Copilot reviewed 69 out of 72 changed files in this pull request and generated 35 comments.

Show a summary per file

File	Description
build.gradle	Updated dependency versions and Maven repository URLs; added jackson-datatype-jdk8 dependency and duplicates strategy
.github/workflows/workflow.yml	Updated Windows test runner from windows-2019 to windows-2025
src/main/java/org/fisco/bcos/sdk/v3/utils/ObjectMapperFactory.java	Modernized ObjectMapper initialization using JsonMapper.builder() with proper configurations
src/main/java/org/fisco/bcos/sdk/v3/crypto/keypair/ECDSAKeyPair.java	Added utility method cryptoKeyPair() for creating ECDSAKeyPair instances
src/main/java/org/fisco/bcos/sdk/v3/client/ClientImpl.java	Added timeout handling with TimeoutException support in callRemoteMethod
src/integration-wasm-test/.../BcosSDKTest.java	Cleaned up unused imports
src/integration-test/.../AssembleTransactionProcessorTest.java	Cleaned up unused imports
src/test/java/.../exception/*	Added comprehensive test coverage for exception classes
src/test/java/.../model/*	Added test coverage for model classes including RetCode, Response, NodeVersion, etc.
src/test/java/.../utils/*	Added test coverage for utility classes including StringUtils, ByteUtils, Numeric, etc.
src/test/java/.../transaction/*	Added test coverage for transaction-related classes and DTOs
src/test/java/.../codec/*	Added test coverage for codec datatypes
src/test/java/.../client/*	Added test coverage for client protocol classes and requests
src/test/java/.../crypto/exceptions/*	Added test coverage for crypto-related exceptions
src/test/java/.../config/exceptions/*	Added test coverage for configuration exceptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-13T03:11:51Z

src/test/java/org/fisco/bcos/sdk/v3/test/client/model/TransactionAttributeTest.java

+
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);


Test is always true.

Suggested change

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

// Test that EVM_ABI_CODEC bit is set in combined

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

// Test that EVM_ABI_CODEC bit is not set when not included

int notCombined = TransactionAttribute.DAG;

Assert.assertFalse((notCombined & TransactionAttribute.EVM_ABI_CODEC) != 0);

// Test that DAG bit is set in combined

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

// Test that LIQUID_SCALE_CODEC bit is not set in combined

Copilot · 2025-11-13T03:11:51Z

src/test/java/org/fisco/bcos/sdk/v3/test/client/model/TransactionAttributeTest.java

+
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);


Test is always true.

Suggested change

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);

// Test that EVM_ABI_CODEC and DAG are present in the combination

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);

// Test that DAG is not present when not included

int combinedWithoutDAG = TransactionAttribute.EVM_ABI_CODEC | TransactionAttribute.LIQUID_SCALE_CODEC;

Assert.assertFalse((combinedWithoutDAG & TransactionAttribute.DAG) != 0);

Copilot · 2025-11-13T03:11:51Z

src/test/java/org/fisco/bcos/sdk/v3/test/client/model/TransactionAttributeTest.java

+
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);


Test is always false.

Suggested change

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);

Assert.assertEquals(0, combined & TransactionAttribute.LIQUID_SCALE_CODEC);

Copilot · 2025-11-13T03:11:52Z

src/test/java/org/fisco/bcos/sdk/v3/test/client/protocol/model/TransactionAttributeTest.java

+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);


Test is always true.

Suggested change

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);

// EVM_ABI_CODEC and DAG should be present

Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);

Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

// LIQUID_SCALE_CODEC should not be present

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != TransactionAttribute.LIQUID_SCALE_CODEC);

// Test absence: combined without EVM_ABI_CODEC

int combinedWithoutEVM = TransactionAttribute.DAG;

Assert.assertFalse((combinedWithoutEVM & TransactionAttribute.EVM_ABI_CODEC) != 0);

// Test presence: add LIQUID_CREATE

int combinedWithCreate = combined | TransactionAttribute.LIQUID_CREATE;

Assert.assertTrue((combinedWithCreate & TransactionAttribute.LIQUID_CREATE) != 0);

Copilot · 2025-11-13T03:11:52Z

src/test/java/org/fisco/bcos/sdk/v3/test/client/protocol/model/TransactionAttributeTest.java

+
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);


Test is always true.

Suggested change

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);

// Test that a flag not included in 'combined' is absent

Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != TransactionAttribute.LIQUID_SCALE_CODEC);

Copilot · 2025-11-13T03:11:59Z

src/test/java/org/fisco/bcos/sdk/v3/transaction/model/exception/JsonExceptionTest.java

+    public void testExceptionDoesNotRequireChecked() {
+        // Since JsonException extends RuntimeException, it can be thrown without being declared
+        JsonException exception = new JsonException("Unchecked exception");
+        Assert.assertTrue(exception instanceof RuntimeException);


There is no need to test whether an instance of JsonException is also an instance of RuntimeException - it always is.

Copilot · 2025-11-13T03:11:59Z

src/test/java/org/fisco/bcos/sdk/v3/transaction/model/exception/JsonExceptionTest.java

+    public void testSerialVersionUID() {
+        // Test that the exception is serializable
+        JsonException exception = new JsonException("Test");
+        Assert.assertTrue(exception instanceof java.io.Serializable);


There is no need to test whether an instance of JsonException is also an instance of Serializable - it always is.

Copilot · 2025-11-13T03:11:59Z

...est/java/org/fisco/bcos/sdk/v3/transaction/model/exception/TransactionBaseExceptionTest.java

+    @Test
+    public void testExceptionIsThrowable() {
+        TransactionBaseException exception = new TransactionBaseException(100, "Test");
+        Assert.assertTrue(exception instanceof Exception);


There is no need to test whether an instance of TransactionBaseException is also an instance of Exception - it always is.

Copilot · 2025-11-13T03:11:59Z

...est/java/org/fisco/bcos/sdk/v3/transaction/model/exception/TransactionBaseExceptionTest.java

+    public void testExceptionIsThrowable() {
+        TransactionBaseException exception = new TransactionBaseException(100, "Test");
+        Assert.assertTrue(exception instanceof Exception);
+        Assert.assertTrue(exception instanceof Throwable);


There is no need to test whether an instance of TransactionBaseException is also an instance of Throwable - it always is.

Copilot · 2025-11-13T03:12:00Z

...est/java/org/fisco/bcos/sdk/v3/transaction/model/exception/TransactionBaseExceptionTest.java

+    public void testSerialVersionUID() {
+        // Test that the exception is serializable
+        TransactionBaseException exception = new TransactionBaseException(100, "Test");
+        Assert.assertTrue(exception instanceof java.io.Serializable);


There is no need to test whether an instance of TransactionBaseException is also an instance of Serializable - it always is.

kyonRay and others added 5 commits November 4, 2025 14:58

<fix>(build): update dependencies version, add UT with AI.

aef619c

<fix>(test): fixed tests path.

44944ef

kyonRay force-pushed the release-3.9.0 branch from db54f64 to c7b8f5c Compare November 7, 2025 02:54

kyonRay added 2 commits November 7, 2025 11:00

<fix>(CI): fix windows ci version to 2025.

3467344

<fix>(build): update publish url to central.sonatype.

b8e3d0a

kyonRay requested a review from Copilot November 13, 2025 03:05

Copilot started reviewing on behalf of kyonRay November 13, 2025 03:06 View session

Copilot finished reviewing on behalf of kyonRay November 13, 2025 03:06

Copilot AI reviewed Nov 13, 2025

View reviewed changes

kyonRay merged commit 756f823 into FISCO-BCOS:release-3.9.0 Nov 13, 2025
10 of 11 checks passed


		Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
		Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);

-        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
-        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        // Test that EVM_ABI_CODEC bit is set in combined
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        // Test that EVM_ABI_CODEC bit is not set when not included
+        int notCombined = TransactionAttribute.DAG;
+        Assert.assertFalse((notCombined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        // Test that DAG bit is set in combined
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        // Test that LIQUID_SCALE_CODEC bit is not set in combined

	Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);
	Assert.assertEquals(0, combined & TransactionAttribute.LIQUID_SCALE_CODEC);

-        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
-        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
-        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);
+        // EVM_ABI_CODEC and DAG should be present
+        Assert.assertTrue((combined & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        Assert.assertTrue((combined & TransactionAttribute.DAG) != 0);
+        // LIQUID_SCALE_CODEC should not be present
+        Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != TransactionAttribute.LIQUID_SCALE_CODEC);
+        // Test absence: combined without EVM_ABI_CODEC
+        int combinedWithoutEVM = TransactionAttribute.DAG;
+        Assert.assertFalse((combinedWithoutEVM & TransactionAttribute.EVM_ABI_CODEC) != 0);
+        // Test presence: add LIQUID_CREATE
+        int combinedWithCreate = combined | TransactionAttribute.LIQUID_CREATE;
+        Assert.assertTrue((combinedWithCreate & TransactionAttribute.LIQUID_CREATE) != 0);

	Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != 0);
	// Test that a flag not included in 'combined' is absent
	Assert.assertFalse((combined & TransactionAttribute.LIQUID_SCALE_CODEC) != TransactionAttribute.LIQUID_SCALE_CODEC);

<fix>(build): update dependencies version, add UT with AI. #945

<fix>(build): update dependencies version, add UT with AI. #945

Uh oh!

Conversation

kyonRay commented Nov 7, 2025

Uh oh!

sonarqubecloud bot commented Nov 13, 2025

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant