deps: move postman-request to direct dep for smoother upgrades. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading from 7 to 8, npm and classic Yarn would not automatically install postman-request because it's a peer-dep and not a direct dep. By making postman-request a direct dep, upgrades will go smoother. To minimize the need to upgrade this module due to a vuln that's found later in postman-request, we intentionally use the `^` notation to accept any newer patch version, so users would be able to update their lock files without requiring a new release of this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I suspected that maybe we should move away
from a peer dependency
#152 (comment)
And today I researched that more and confirmed, that
when upgrading from requestretry from 7 to 8, npm and classic Yarn would not automatically install postman-request because it's a peer-dep and not a direct dep.
By making postman-request a direct dep, upgrades will
go smoother.
To minimize the need to upgrade this module due to a
vuln that's found later in postman-request, we intentionally
use the
^notation to accept any newer patch version,so users would be able to update their lock files without
requiring a new release of this module.
To force the package-lock.json to reflect the change I rebuilt it, which created some additional churn there, although it's probably for the best as it freshed a few more things in the dependency chain.