Enhance thermal boundary conditions handling for 1D meshes by implementing convection type

Author: nikoscham

src/solvers/solidHeatTransferScript.js

@@ -151,8 +151,7 @@ export function assembleSolidHeatTransferMat(meshConfig, boundaryConditions) {
         // Computation of Galerkin's residuals and Jacobian matrix
         for (let localNodeIndex1 = 0; localNodeIndex1 < numNodes; localNodeIndex1++) {
           let globalNodeIndex1 = localNodalNumbers[localNodeIndex1];
-          residualVector[globalNodeIndex1] +=
-            gaussWeights[gaussPointIndex1] * detJacobian * basisFunction[localNodeIndex1];
+          // residualVector is zero for this case
 
           for (let localNodeIndex2 = 0; localNodeIndex2 < numNodes; localNodeIndex2++) {
             let globalNodeIndex2 = localNodalNumbers[localNodeIndex2];
@@ -213,11 +212,7 @@ export function assembleSolidHeatTransferMat(meshConfig, boundaryConditions) {
           // Computation of Galerkin's residuals and Jacobian matrix
           for (let localNodeIndex1 = 0; localNodeIndex1 < numNodes; localNodeIndex1++) {
             let globalNodeIndex1 = localNodalNumbers[localNodeIndex1];
-            residualVector[globalNodeIndex1] +=
-              gaussWeights[gaussPointIndex1] *
-              gaussWeights[gaussPointIndex2] *
-              detJacobian *
-              basisFunction[localNodeIndex1];
+            // residualVector is zero for this case
 
             for (let localNodeIndex2 = 0; localNodeIndex2 < numNodes; localNodeIndex2++) {
               let globalNodeIndex2 = localNodalNumbers[localNodeIndex2];

src/solvers/thermalBoundaryConditionsScript.js

@@ -154,7 +154,36 @@ export class ThermalBoundaryConditions {
     });
 
     if (this.meshDimension === "1D") {
-      // 1D code
+      Object.keys(this.boundaryConditions).forEach((boundaryKey) => {
+        if (this.boundaryConditions[boundaryKey][0] === "convection") {
+          const convectionCoeff = convectionHeatTranfCoeff[boundaryKey];
+          const extTemp = convectionExtTemp[boundaryKey];
+          this.boundaryElements[boundaryKey].forEach(([elementIndex, side]) => {
+            let nodeIndex;
+            if (this.elementOrder === "linear") {
+              if (side === 0) {
+                // Node at the left side of the reference element
+                nodeIndex = 0;
+              } else {
+                // Node at the right side of the reference element
+                nodeIndex = 1;
+              }
+            } else if (this.elementOrder === "quadratic") {
+              if (side === 0) {
+                // Node at the left side of the reference element
+                nodeIndex = 0;
+              } else {
+                // Node at the right side of the reference element
+                nodeIndex = 2;
+              }
+            }
+            
+            const globalNodeIndex = this.nop[elementIndex][nodeIndex] - 1;
+            residualVector[globalNodeIndex] += -convectionCoeff * extTemp;
+            jacobianMatrix[globalNodeIndex][globalNodeIndex] += convectionCoeff;
+          });
+        }
+      });
     } else if (this.meshDimension === "2D") {
       Object.keys(this.boundaryConditions).forEach((boundaryKey) => {
         if (this.boundaryConditions[boundaryKey][0] === "convection") {