Improve convection boundary conditions handling and perform nested array check for the line plot

Author: nikoscham

src/solvers/solidHeatTransferScript.js

@@ -36,18 +36,11 @@ export function assembleSolidHeatTransferMat(meshConfig, boundaryConditions) {
     elementOrder, // The order of elements
   } = meshConfig;
 
-  debugLog(`Mesh configuration: ${meshDimension}, Elements: ${numElementsX}x${numElementsY || 1}, Size: ${maxX}x${maxY || 0}, Order: ${elementOrder}`);
-
-  // Extract boundary conditions from the configuration object
-  let convectionHeatTranfCoeff = [];
-  let convectionExtTemp = [];
-  Object.keys(boundaryConditions).forEach((key) => {
-    const boundaryCondition = boundaryConditions[key];
-    if (boundaryCondition[0] === "convection") {
-      convectionHeatTranfCoeff[key] = boundaryCondition[1];
-      convectionExtTemp[key] = boundaryCondition[2];
-    }
-  });
+  debugLog(
+    `Mesh configuration: ${meshDimension}, Elements: ${numElementsX}x${numElementsY || 1}, Size: ${maxX}x${
+      maxY || 0
+    }, Order: ${elementOrder}`
+  );
 
   // Create a new instance of the meshGeneration class
   debugLog("Generating mesh...");
@@ -259,9 +252,7 @@ export function assembleSolidHeatTransferMat(meshConfig, boundaryConditions) {
     gaussWeights,
     nodesXCoordinates,
     nodesYCoordinates,
-    basisFunctionsData,
-    convectionHeatTranfCoeff,
-    convectionExtTemp
+    basisFunctionsData
   );
   debugLog("Convection boundary conditions applied");
 

src/solvers/thermalBoundaryConditionsScript.js

@@ -132,8 +132,6 @@ export class ThermalBoundaryConditions {
    * @param {array} nodesXCoordinates - Array of x-coordinates of nodes
    * @param {array} nodesYCoordinates - Array of y-coordinates of nodes
    * @param {object} basisFunctionsData - Object containing basis functions and their derivatives
-   * @param {array} convectionHeatTranfCoeff - Array of convection heat transfer coefficients
-   * @param {array} convectionExtTemp - Array of external temperatures for convection
    */
   imposeConvectionBoundaryConditions(
     residualVector,
@@ -142,10 +140,19 @@ export class ThermalBoundaryConditions {
     gaussWeights,
     nodesXCoordinates,
     nodesYCoordinates,
-    basisFunctionsData,
-    convectionHeatTranfCoeff,
-    convectionExtTemp
+    basisFunctionsData
   ) {
+    // Extract convection parameters from boundary conditions
+    let convectionHeatTranfCoeff = [];
+    let convectionExtTemp = [];
+    Object.keys(this.boundaryConditions).forEach((key) => {
+      const boundaryCondition = this.boundaryConditions[key];
+      if (boundaryCondition[0] === "convection") {
+        convectionHeatTranfCoeff[key] = boundaryCondition[1];
+        convectionExtTemp[key] = boundaryCondition[2];
+      }
+    });
+
     if (this.meshDimension === "1D") {
       // 1D code
     } else if (this.meshDimension === "2D") {

src/visualization/plotSolutionScript.js

@@ -30,8 +30,13 @@ export function plotSolution(
   const { nodesXCoordinates, nodesYCoordinates } = nodesCoordinates;
 
   if (meshDimension === "1D" && plotType === "line") {
-    // Flatten solutionVector
-    let yData = solutionVector.map(arr => arr[0]);
+    // Check if solutionVector is a nested array
+    let yData;
+    if (solutionVector.length > 0 && Array.isArray(solutionVector[0])) {
+      yData = solutionVector.map(arr => arr[0]);
+    } else {
+      yData = solutionVector;
+    }
     let xData = Array.from(nodesXCoordinates);
 
     let lineData = {