feat: TrySetRank method(and refactor) #680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. We need to test this to make sure it doesn't cause problems, because God only knows how it all works internally. https://discord.com/channels/656673194693885975/1002713309876854924/1432873468285948055
…ble ones. We need to test this to make sure it doesn't cause problems, because God only knows how it all works internally." This reverts commit c72eabf.
Author
|
Why did all the old commits end up here if I synced the repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: TrySetRank method(and refactor)
Describe the changes
New TrySetRank method. Refactoring of the SetRank method.
What is the current behavior? (You can also link to an open issue here)
Unfortunately, the standard SetRank method requires creating a UserGroup object, which isn't always convenient. Specifying "null" isn't always a good idea, and it doesn't meet the requirements for clean and correct code. Furthermore, it's not entirely clear what happens if you specify null.
https://discord.com/channels/656673194693885975/1002713309876854924/1436117402965508147
What is the new behavior? (if this is a feature change)
It has become convenient to assign a rank (group).
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other