Skip to content

feat: added MinPlayers property #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
An4r3w wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: added MinPlayers property #660

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791c43c
added MinPlayers property
An4r3w Oct 19, 2025
afe167c
changed MinPlayer check's position
An4r3w Oct 23, 2025
1c117e7
changed == to >=
An4r3w Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion EXILED/Exiled.CustomRoles/API/Features/CustomRole.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ public abstract class CustomRole
/// </summary>
public virtual SpawnProperties SpawnProperties { get; set; } = new();

/// <summary>
/// Gets or sets the minimum number of players connected needed in order to add the role.
/// </summary>
public virtual int MinPlayers { get; set; }

/// <summary>
/// Gets or sets a value indicating whether players keep their current position when gaining this role.
/// </summary>
Expand Down Expand Up @@ -1020,4 +1025,4 @@ private void OnSpawningRagdoll(SpawningRagdollEventArgs ev)

private void OnDestroying(DestroyingEventArgs ev) => RemoveRole(ev.Player);
}
}
}
4 changes: 2 additions & 2 deletions EXILED/Exiled.CustomRoles/Events/PlayerHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ internal void OnSpawned(SpawnedEventArgs ev)

foreach (CustomRole role in CustomRole.Registered)
{
if (role.Role == ev.Player.Role.Type && !role.IgnoreSpawnSystem && role.SpawnChance > 0 && !role.Check(ev.Player) && (role.SpawnProperties is null || role.SpawnedPlayers < role.SpawnProperties.Limit))
if (role.Role == ev.Player.Role.Type && !role.IgnoreSpawnSystem && role.SpawnChance > 0 && !role.Check(ev.Player) && (role.SpawnProperties is null || role.SpawnedPlayers < role.SpawnProperties.Limit) && (role.MinPlayers is 0 || Server.PlayerCount == role.MinPlayers))
Copy link
Collaborator

@Someone-193 Someone-193 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be >= in player count comparison ?

Copy link
Author

@An4r3w An4r3w Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally missed that lol

Copy link
Collaborator

@Someone-193 Someone-193 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should NPC's be included in this check btw? Server.PlayerCount includes dummies, but Server.ConnectedPlayerCount will ignore them

{
eligibleRoles.Add(role);
totalChance += role.SpawnChance;
Expand Down Expand Up @@ -123,4 +123,4 @@ internal void OnSpawned(SpawnedEventArgs ev)
}
}
}
}
}
Loading