Skip to content

feat: specialize dispatches for faster concrete array generation #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

feat: specialize dispatches for faster concrete array generation #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9d99b8
feat: specialize dispatches for faster concrete array generation
avik-pal Nov 1, 2024
b55f443
chore: apply formatting suggestion
avik-pal Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/Tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,29 @@ end

@inline function to_rarray(@nospecialize(x); track_numbers::Union{Bool,Tuple}=())
track_numbers isa Bool && (track_numbers = track_numbers ? (Number,) : ())
return to_rarray_internal(x, track_numbers)
end

@inline function to_rarray_internal(@nospecialize(x), track_numbers::Tuple)
return make_tracer(OrderedIdDict(), x, (), Reactant.ArrayToConcrete; track_numbers)
end

to_rarray(x::ReactantPrimitive) = ConcreteRArray(x)
function to_rarray_internal(@nospecialize(::TracedRArray), ::Tuple)
return error("Cannot convert TracedRArray to ConcreteRArray")
end
@inline to_rarray_internal(@nospecialize(x::ConcreteRArray), ::Tuple) = x
@inline function to_rarray_internal(
@nospecialize(x::AbstractArray{<:ReactantPrimitive}), ::Tuple
)
return ConcreteRArray(x)
end

@inline to_rarray_internal(@nospecialize(x::ConcreteRNumber), ::Tuple) = x
@inline function to_rarray_internal(
@nospecialize(x::ReactantPrimitive), track_numbers::Tuple
)
for T in track_numbers
typeof(x) <: T && return ConcreteRNumber(x)
end
return x
end
14 changes: 14 additions & 0 deletions test/tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,18 @@ using Test
end
end
end

@testset "specialized dispatches" begin
@test @inferred Union{Float64,ConcreteRArray{Float64}} Reactant.to_rarray(
1.0; track_numbers=(Number,)
) isa ConcreteRNumber
@test @inferred Reactant.to_rarray(1.0) isa Float64
@test @inferred Reactant.to_rarray(rand(3)) isa ConcreteRArray

x_ra = Reactant.to_rarray(rand(3))
@test @inferred Reactant.to_rarray(x_ra) isa ConcreteRArray

x_ra = Reactant.to_rarray(1.0; track_numbers=(Number,))
@test @inferred Reactant.to_rarray(x_ra) isa ConcreteRNumber
end
end
Loading