fix: finite diff gradient accidental type promotion + generalize inputs #1847
+216
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fd
branch
3 times, most recently
from
9afcb9a to
74f08fe
Compare
wsmoses
reviewed
Nov 15, 2025
| resargprefix = gensym("finitediffresarg") | ||
|
|
||
| # TODO: can we detect and prevent using functions that mutate their arguments? | ||
| mlir_fn_res = TracedUtils.make_mlir_fn( |
Member
There was a problem hiding this comment.
do we need to do the full make_mlir_fn here, or can we reuse the equivalent of traced call or traced functions to achieve the same effect?
Collaborator
Author
There was a problem hiding this comment.
I am using make_mlir_fn mostly to linearlize the arguments. not sure how to use traced_call here though
Member
There was a problem hiding this comment.
ah so it was linearization, not efficiency
avik-pal
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wsmoses
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precision issue will take a look later