Skip to content

Add halo test #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add halo test #1820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d3203
Add halo test
wsmoses Nov 3, 2025
bf1b85c
Update test/optimize_comm.jl
wsmoses Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions test/optimize_comm.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ function dus2(x, y)
return nothing
end

function halo!(x)
x[9:3065, 7, :] = x[9:3065, 8, :]
x[9:3065, 3066, :] = x[9:3065, 3065, :]

x[1:8, :, :] = x[(3065 - 8 + 1):3065, :, :]
x[3065:(3065 + 8 - 1), :, :] = x[8:15, :, :]
return nothing
end

if length(addressable_devices) ≥ 8
@testset "Rotate" begin
N = min((length(Reactant.devices()) ÷ 2) * 2, 8)
Expand Down Expand Up @@ -110,4 +119,30 @@ if length(addressable_devices) ≥ 8
@test all(x .== convert(Array, rx))
@test all(y .== convert(Array, ry))
end


@testset "Halo" begin
N = min((length(Reactant.devices()) ÷ 2) * 2, 8)

mesh = Sharding.Mesh(reshape(Reactant.devices()[1:N], 2, :, 1), (:x, :y, :z))
sharding = Sharding.NamedSharding(mesh, (:x, :y, :z))

M = 3072
x = reshape(collect(Int, 1:(M * M)), M, M, 1)
rx = Reactant.to_rarray(x; sharding)

hlo = repr(@code_xla shardy_passes = :to_mhlo_shardings halo!(rx))

@test !contains(hlo, "all-to-all")
@test !contains(hlo, "all-reduce") broken = true
@test !contains(hlo, "all-gather") broken =
Reactant.XLA.REACTANT_XLA_RUNTIME == "PJRT"
@test contains(hlo, "collective-permute") broken =
Reactant.XLA.REACTANT_XLA_RUNTIME == "PJRT"

dus2(x, y)
@jit shardy_passes = :to_mhlo_shardings dus2(rx, ry)
@test all(x .== convert(Array, rx))
@test all(y .== convert(Array, ry))
end
end
Loading