symm op #1777
Closed
symm op #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
reviewed
Oct 19, 2025
src/Ops.jl
Outdated
| location, | ||
| ), | ||
| ) | ||
| return res |
Collaborator
There was a problem hiding this comment.
construct a TracedRArray before returning (see the dot_general case below)
avik-pal
reviewed
Oct 19, 2025
src/Ops.jl
Outdated
| C.mlir_data, | ||
| alpha.mlir_data, | ||
| beta.mlir_data; | ||
| output=mlir_type(TracedRArray{eltype(C),length(ressize)}, ressize), |
Collaborator
There was a problem hiding this comment.
eltype(c) make this into unwrapped_eltype
avik-pal
reviewed
Oct 20, 2025
src/stdlibs/LinearAlgebra.jl
Outdated
| β::Number=true, | ||
| ) | ||
| # Promote to traced arrays | ||
| A = call_with_reactant(Reactant.promote_to, TracedRArray, A.data) |
Collaborator
There was a problem hiding this comment.
Suggested change
| A = call_with_reactant(Reactant.promote_to, TracedRArray, A.data) | |
| A = call_with_reactant(Reactant.promote_to, TracedRArray, parent(A)) |
avik-pal
reviewed
Oct 20, 2025
Comment on lines
+277
to
+279
| @nospecialize(C::TracedRArray{T,2} where {T}), | ||
| @nospecialize(A::Symmetric), | ||
| @nospecialize(B::AbstractMatrix), |
Collaborator
There was a problem hiding this comment.
Also add the version where B is Symmetric
* feat: julia api to access device properties [skip ci] * fix: apply suggestion from @avik-pal [skp ci] * chore: bump reactant_jll * fix: remove deleted fields [skip ci] * chore: bump jll
* actually run code for symlinking ptxas, fatbinary, libdevice (the condition `build_backend == "cuda"` was now always false) * check the source of the symlinks exists, instead of creating broken symlinks, if that part of the code ever runs (which at the moment it doesn't because of point above) * rework backend handling, to use more structure instead of string comparisons (which lead to issues like the first point)
* Regenerate MLIR Bindings * fix: kernel call --------- Co-authored-by: enzyme-ci-bot[bot] <78882869+enzyme-ci-bot[bot]@users.noreply.github.com> Co-authored-by: Avik Pal <avikpal@mit.edu>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: enzyme-ci-bot[bot] <78882869+enzyme-ci-bot[bot]@users.noreply.github.com>
* feat: new jll version + new compiler passes * fix: use newer libtpu builds * fix: try always downloading libtpu on ci * feat: version check for libtpu
* test: version 1.12 Comment out older Go versions in CI matrix * test: v1.12 * ci: disable downgrade * fix: get 1.12 KAExt loading to work * Mildly functioning on 1.12 * ci * fix 1.10 * Change Julia version from 1.12 to 1.10 * chore: run formatter --------- Co-authored-by: William S. Moses <gh@wsmoses.com> Co-authored-by: William Moses <wmoses@google.com>
Collaborator
|
closing in favor of #1798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.