fuzz-tests: get rid of magic numbers in fuzz-hsm_encryption.c
#8595
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
hsm_encryption
branch
from
8cea2f3 to
cc3d0ad
Compare
Contributor
|
This file was replaced, due to the hsm encryption changes, so I altered your test to fit. Maintained the corpora for now, though. |
rustyrussell
force-pushed
the
hsm_encryption
branch
from
cc3d0ad to
b166978
Compare
We check this now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-None: `fuzz-hsm_encryption.c` hard codes the lengths sizeof(struct secret) as 32 and crypto_pwhash_argon2id_PASSWD_MAX as 4294967295. Replace the latter with the former to improve readability and maintainability. While at it, replace the `tal_free()` call on our secret key with `discard_key()`. This has the benefit of testing `discard_key()`. [ Changed from fuzz-hsm_encryption to fuzz-hsm_secret --RR ]
Change in the fuzzing scheme of fuzz-hsm_encryption led to the discovery of test inputs that result in greater in code coverage. Add these inputs to the test's seed corpus. [ Changed from fuzz-hsm_encryption to fuzz-hsm_secret --RR ]
rustyrussell
force-pushed
the
hsm_encryption
branch
from
b166978 to
7d39fad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-None:
fuzz-hsm_encryption.chard codes the lengthssizeof(struct secret)as 32 andcrypto_pwhash_argon2id_PASSWD_MAXas 4294967295. Replace the latter with the former to improve readability and maintainability.While at it, replace the
tal_free()call on our secret key withdiscard_key(). This has the benefit of testingdiscard_key().Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: