ENG-162487: accessibility fix for stepper component to move the focus to the selected section #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
src/components/Stepper/Stepper.tsx
Outdated
Comment on lines
247
to
249
| const firstInput = sectionElement.querySelector( | ||
| 'input, textarea, select, [tabindex="0"]' | ||
| ) as HTMLElement; |
Collaborator
There was a problem hiding this comment.
please use ref to select elements
src/components/Stepper/Stepper.tsx
Outdated
| }, 100); | ||
| }; | ||
|
|
||
| window.addEventListener('scroll', handleScroll); |
Collaborator
There was a problem hiding this comment.
remove on unmount as well
| locale = enUS, | ||
| onChange, | ||
| readonly = true, | ||
| sectionRefs, |
Collaborator
There was a problem hiding this comment.
this prop is not user friendly, please find a different option
… selected section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
ENG-162487:
Links should direct keyboard users to the relevant form section by either linking to the section heading or setting focus on the first input field.
Solution:
When the Enter or Space key is pressed on a link, the page smoothly scrolls to the corresponding form section and automatically sets focus on the first input field, enabling immediate keyboard interaction
GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-162487
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Navigate to TA Home → My Positions → Create Position → Create from Scratch → Select Template
Try to fill the form using keyboard for different section
Expected Result:
When a keyboard user activates a link using the Enter or Space key, the page scrolls smoothly to the targeted form section, and the first input field in that section receives focus, allowing the user to start interacting with the form immediately without additional navigation
Screen.Recording.2025-11-11.at.1.22.17.PM.mov