-
Notifications
You must be signed in to change notification settings - Fork 366
Fix broken paragdiwan.gitpatch extension build
#558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there @manuth! I am happy that you are fixing this extension, but I don't think because of it, there is enough purpose to introduce a brand-new option for it. It still sadly doesn't build even with this introduced. I think we should remove the extension from here and ask the author to publish it themselves. Edit: it builds now, yay 😄! |
|
@filiptronicek thanks for your rapid answer! Hope you don't mind me introducing this change. |
Oh, it is because of an outdated README. We have deprecated the checkout property and no longer use it. |
Oh that's fair, I wasn't aware of that. Should I put this PR on hold until the |
Sounds like a good idea to me :) |
|
@manuth just merged the custom property PR, so feel free to use it :) |
|
Awesome! Thanks for letting me know 😄 |
|
Oh... well that's weird, the GitHub actions won't run 😅 |
|
I'll close this PR in favor of #565 |
I have tried reaching out to the extension maintainers about publishing this extension to OpenVSX (if not, please create an issue in the extension's repo using this template).Description
Changes made in this PR will update the commit reference to build
paragdiwan.gitpatchfrom as the latest version doesn't build properly.Furthermore, changes made in this PR will fully implement the
checkout-feature mentioned in this repository'sREADME.