Skip to content

Conversation

@neurolag
Copy link
Contributor

@neurolag neurolag commented Mar 10, 2022

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to OpenVSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

Changes made in this PR will update the commit reference to build paragdiwan.gitpatch from as the latest version doesn't build properly.
Furthermore, changes made in this PR will fully implement the checkout-feature mentioned in this repository's README.

@filiptronicek
Copy link
Member

filiptronicek commented Mar 10, 2022

Hi there @manuth! I am happy that you are fixing this extension, but I don't think because of it, there is enough purpose to introduce a brand-new option for it. It still sadly doesn't build even with this introduced. I think we should remove the extension from here and ask the author to publish it themselves.

Edit: it builds now, yay 😄!

@neurolag
Copy link
Contributor Author

@filiptronicek thanks for your rapid answer!
I wasn't aware that the "checkout"-feature described in the README wasn't implemented, so I added it with my last commit (
39c048f).

Hope you don't mind me introducing this change.

@filiptronicek
Copy link
Member

I wasn't aware that the "checkout"-feature described in the README wasn't implemented, so I added it with my last commit

Oh, it is because of an outdated README. We have deprecated the checkout property and no longer use it.

@neurolag
Copy link
Contributor Author

I wasn't aware that the "checkout"-feature described in the README wasn't implemented, so I added it with my last commit

Oh, it is because of an outdated README. We have deprecated the checkout property and no longer use it.

Oh that's fair, I wasn't aware of that.
I guess once the custom-feature is established, having a checkout-property is not necessary anymore anyways.

Should I put this PR on hold until the custom-feature has been established?

@filiptronicek
Copy link
Member

Should I put this PR on hold until the custom-feature has been established?

Sounds like a good idea to me :)

@filiptronicek
Copy link
Member

@manuth just merged the custom property PR, so feel free to use it :)

@neurolag
Copy link
Contributor Author

Awesome! Thanks for letting me know 😄

@neurolag
Copy link
Contributor Author

Oh... well that's weird, the GitHub actions won't run 😅

@neurolag
Copy link
Contributor Author

neurolag commented Apr 6, 2022

I'll close this PR in favor of #565

@neurolag neurolag closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants