Skip to content

Conversation

@ddudenin
Copy link
Contributor

@ddudenin ddudenin commented Oct 30, 2025

Plan

  • Implement the date selection in a well-typed format.
  • Selecting a range using the keyboard
  • Selecting a range using the mouse
  • Support for the style attributes described below
  • Support marking certain dates as unavailable
  • Pass tests.
    • Compilation.
    • Check, clippy tests.
    • Doc comments.
    • Playwright.
    • Add components.

Fixes #131

Styling

it would be nice to have data attributes for:

  • the start of the selection
  • dates in between the selection
  • the end of the selection
  • the state of the selection (no dates, the first date or both dates have been selected)

@github-actions
Copy link

@ddudenin ddudenin marked this pull request as draft October 30, 2025 19:56
  - Add date range struct
  - Selecting a range using the mouse
  - Selecting a range using the keyboard
  - Add selection attributes
  - Add range component as variant of the calendar (preview)
  - Add selection style for last and next month
  - Fix keyboard selection
  - Update docs for RangeCalendarDay
@ddudenin ddudenin marked this pull request as ready for review October 31, 2025 11:55
@ddudenin
Copy link
Contributor Author

@ealmloff I'm looking for feedback on the issue of selecting date ranges in the calendar.

Regarding the errors in adding components, am I correct in understanding that the error is that the new properties and structures are not in the main branch, so it cannot pass the tests successfully?

@ealmloff
Copy link
Member

Regarding the errors in adding components, am I correct in understanding that the error is that the new properties and structures are not in the main branch, so it cannot pass the tests successfully?

Yes, that looks like an error in the CI setup, not this branch itself. Feel free to ignore

@ddudenin
Copy link
Contributor Author

ddudenin commented Nov 5, 2025

@ealmloff I've added support for unavailable dates for all calendar types (without the ability to select non-contiguous ranges)

So this is the most complete version for your review

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Looks great overall, I'm going to mess with the styling a bit and then merge this

@ealmloff ealmloff enabled auto-merge (squash) November 11, 2025 18:55
@ealmloff ealmloff merged commit 98067ce into DioxusLabs:main Nov 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date range in Calendar

2 participants