-
Notifications
You must be signed in to change notification settings - Fork 35
Date range in Calendar #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-145/ |
- Add date range struct - Selecting a range using the mouse - Selecting a range using the keyboard - Add selection attributes - Add range component as variant of the calendar (preview)
- Add selection style for last and next month - Fix keyboard selection - Update docs for RangeCalendarDay
|
@ealmloff I'm looking for feedback on the issue of selecting date ranges in the calendar. Regarding the errors in adding components, am I correct in understanding that the error is that the new properties and structures are not in the main branch, so it cannot pass the tests successfully? |
Yes, that looks like an error in the CI setup, not this branch itself. Feel free to ignore |
|
@ealmloff I've added support for unavailable dates for all calendar types (without the ability to select non-contiguous ranges) So this is the most complete version for your review |
ealmloff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Looks great overall, I'm going to mess with the styling a bit and then merge this
Plan
Fixes #131
Styling
it would be nice to have data attributes for: