Fix CI in v25.1.3+ #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cript patterns - Implement proper TypeScript typing with DataGridTypes and Employee interface - Use modern React patterns: useCallback, memo, proper ref handling - Add FileUploaderEditor and FileUploaderWithPreview components - Add error handling and retry functionality - Include proper CSS styling for uploaded images - Remove old implementation files and use clean modern structure - Add DevExtreme CSS import to main.tsx
…tion API - Use Vue 3 Composition API with proper TypeScript typing - Implement reactive refs with proper type annotations - Create modular higher-order function for upload handler - Add comprehensive error handling for file uploads - Include proper styling with CSS Grid and flexbox - Remove original implementation files for clean structure - Add backend URL constants for configuration - Implement proper template refs with type safety
…patterns - Use modern ES6 arrow functions, const/let, and template literals - Implement proper state management object for retry button visibility - Add comprehensive JSDoc documentation for all functions - Create modular template creation functions with proper error handling - Add robust error handling for FileReader and upload processes - Include responsive CSS styling with Flexbox layout - Use semantic HTML structure with proper accessibility attributes - Implement proper DOM manipulation with modern JavaScript methods
- Document successful migrations for React, Vue.js, and jQuery - Highlight modern patterns implemented in each framework - Detail framework-specific modernizations and benefits - Document Angular build issues and suggested resolutions - Provide clear next steps and development commands - Include file structure overview and backend configuration
- Migrated to TypeScript with proper DevExtreme Angular types (DxDataGridTypes, DxFileUploaderTypes, DxButtonTypes) - Updated app.component.ts with framework-specific event types - Converted app.component.css to app.component.scss with kebab-case classes (.retry-button, .uploaded-image) - Created app.service.ts for Employee data service - Updated app.module.ts imports - Added proper type safety with generics <Employee, number> - Removed orig_ files - Build and lint passing with 0 errors
…se CSS - Migrated to Vue 3 Composition API with <script setup lang="ts"> - Updated to DevExtreme Vue types (DxDataGridTypes, DxFileUploaderTypes) - Removed redundant text prop from DxButton, using slot content instead - Updated CSS classes to kebab-case (.retry-button, .uploaded-image) - Removed unused event parameters from handlers - Added proper TypeScript typing for all event handlers - Created constants.ts for backendURL - Updated data.ts with Employee interface - Build and lint passing with 0 errors
- Updated package-lock.json with latest dependencies - Verified TypeScript migration with DevExtreme React types - Build and lint passing (TypeScript 5.8.3 with ESLint compatibility warning) - All functionality preserved with FileUploader in DataGrid edit form
- Modernized JavaScript syntax (var to let/const where appropriate) - Updated CSS classes to kebab-case (.retry-button, .uploaded-image) - Updated data.js with employee records - Maintained jQuery compatibility while improving code quality - Build and lint passing with Prettier formatting
- Migrated to strongly-typed DataGrid<Employee> with lambda expressions - Replaced AddSimple with AddSimpleFor(m => m.Property) - Replaced Add with AddFor(m => m.Property) for columns - Created Employee.cs model (renamed from SampleOrder.cs) - Updated SampleData.cs with 9 employees matching other frameworks - Removed SampleDataController.cs (using static data) - Created separate Razor partial views: _CellTemplate.cshtml, _EditCellTemplate.cshtml - Consolidated CSS from jQuery to Site.css with kebab-case naming - Removed inline styles from Index.cshtml - Added Nuget.config for DevExpress feed - Removed nested ASP.NET Core/ folder structure - Removed orig_ files - Build passing with 0 errors (only DX license warnings)
- Updated TargetFramework from netcoreapp3.1 to net9.0 - Migrated to minimal hosting model (Program.cs with WebApplicationBuilder) - Removed Startup.cs (no longer needed in .NET 9) - Enabled ImplicitUsings and nullable reference types - Updated FileUploadController.cs with async/await patterns - Created launchSettings.json for port 5020 configuration - Simplified CORS, Swagger, and static files configuration - Build passing with 0 errors
Contributor
|
Please correct the project and update this pull request by pushing a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.