Skip to content

Conversation

@BendingBender
Copy link
Contributor

Please fill in this template.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels May 16, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented May 16, 2021

@BendingBender Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 52982,
  "author": "BendingBender",
  "headCommitOid": "8cd913ba7948cc4181e374387423f3549722740a",
  "lastPushDate": "2021-05-16T17:27:30.000Z",
  "lastActivityDate": "2021-05-16T18:52:47.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "fast-json-stable-stringify",
      "kind": "delete",
      "files": [
        {
          "path": "types/fast-json-stable-stringify/fast-json-stable-stringify-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/fast-json-stable-stringify/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/fast-json-stable-stringify/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/fast-json-stable-stringify/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "bondz",
      "date": "2021-05-16T18:52:47.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @BendingBender — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 16, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented May 16, 2021

@BendingBender The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@BendingBender BendingBender force-pushed the fast-json-stable-stringify branch from 005b919 to c1a170e Compare May 16, 2021 17:27
@BendingBender BendingBender force-pushed the fast-json-stable-stringify branch from c1a170e to 8cd913b Compare May 16, 2021 17:27
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label May 16, 2021
@typescript-bot
Copy link
Contributor

@bondz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label May 16, 2021
@BendingBender BendingBender changed the title [fast-json-stable-stringify] Remove, bundles it's own types [fast-json-stable-stringify] Remove, bundles its own types May 17, 2021
@weswigham weswigham merged commit 3f7f481 into DefinitelyTyped:master May 18, 2021
@BendingBender BendingBender deleted the fast-json-stable-stringify branch May 18, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Infrastructure No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants