-
Notifications
You must be signed in to change notification settings - Fork 30.5k
[fast-json-stable-stringify] Remove, bundles its own types #52982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fast-json-stable-stringify] Remove, bundles its own types #52982
Conversation
|
@BendingBender Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 52982,
"author": "BendingBender",
"headCommitOid": "8cd913ba7948cc4181e374387423f3549722740a",
"lastPushDate": "2021-05-16T17:27:30.000Z",
"lastActivityDate": "2021-05-16T18:52:47.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "fast-json-stable-stringify",
"kind": "delete",
"files": [
{
"path": "types/fast-json-stable-stringify/fast-json-stable-stringify-tests.ts",
"kind": "test"
},
{
"path": "types/fast-json-stable-stringify/index.d.ts",
"kind": "definition"
},
{
"path": "types/fast-json-stable-stringify/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/fast-json-stable-stringify/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"BendingBender"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "bondz",
"date": "2021-05-16T18:52:47.000Z",
"isMaintainer": false
}
],
"ciResult": "pass"
} |
|
🔔 @BendingBender — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@BendingBender The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
005b919 to
c1a170e
Compare
c1a170e to
8cd913b
Compare
|
@bondz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
npm test <package to test>.If removing a declaration:
notNeededPackages.json.