reimport: support pro compute hash code method #13680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentijnscholten
added
Pro
affects_pro
valentijnscholten
force-pushed
the
pro-hash-code-reimport-fix
branch
from
00c313e to
e3f7546
Compare
valentijnscholten
changed the title
valentijnscholten
force-pushed
the
pro-hash-code-reimport-fix
branch
from
110ef68 to
b206f52
Compare
valentijnscholten
force-pushed
the
pro-hash-code-reimport-fix
branch
from
b206f52 to
b684aba
Compare
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
🔴 Risk threshold exceeded.This pull request modifies sensitive files (dojo/importers/default_reimporter.py and dojo/models.py), triggering configured codepath alerts for potentially sensitive edits; review and verify these changes and allowed authors as configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/models.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Nov 13, 2025
Jino-T
approved these changes
Nov 13, 2025
dogboat
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pro uses a custom implementation for hashing as it stores its settings differently and has some extra hash_code fields. The reimporter was not using this when calculating hashes, causing deduplication to fail for findings that are created during a reimport.