Skip to content

log a line when custom hash method is used #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+3 −2
Merged

log a line when custom hash method is used #13679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dojo/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3485,15 +3485,16 @@ def violates_sla(self):
def set_hash_code(self, dedupe_option):
from dojo.utils import get_custom_method # noqa: PLC0415 circular import
if hash_method := get_custom_method("FINDING_HASH_METHOD"):
deduplicationLogger.debug("Using custom hash method")
Copy link
Contributor

@dogboat dogboat Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for debug, is there any value in including the method name (either from the given setting or by stringifying the resolved method)?

Copy link
Contributor

@mtesauro mtesauro Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentijnscholten Before I approve and merged this I wanted to give you a chance to comment here.

hash_method(self, dedupe_option)
# Finding.save is called once from serializers.py with dedupe_option=False because the finding is not ready yet, for example the endpoints are not built
# It is then called a second time with dedupe_option defaulted to true; now we can compute the hash_code and run the deduplication
elif dedupe_option:
if self.hash_code is not None:
deduplicationLogger.debug("Hash_code already computed for finding")
deduplicationLogger.debug("Hash_code already computed for finding %i", self.id)
else:
self.hash_code = self.compute_hash_code()
deduplicationLogger.debug("Hash_code computed for finding: %s", self.hash_code)
deduplicationLogger.debug("Hash_code computed for finding %i: %s", self.id, self.hash_code)


class FindingAdmin(admin.ModelAdmin):
Expand Down