feat(deps): identify circular brick dependencies #395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
The poly tool now detects circular dependencies between bricks, to avoid any possible runtime errors.
The
poly depsandpoly deps --brick <the brick>now reports on bricks that are both used by and used in a brick.The notification is information, the command will not return with a failed exit code. The reason is that circular brick dependencies can work without runtime errors.
Motivation and Context
Solves feature request #394
How Has This Been Tested?
✅ CI
✅ Unit tests
✅ Local run of the command on the polylith repo itself containing two circular brick dependencies (see #393)
Types of changes
Checklist: