fix(json-specs): add secret flags on all secret fields #21975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
dev/tooling
integration/cassandra_nodetool
integration/disk
integration/gitlab
integration/mcache
integration/mongo
integration/mysql
integration/oracle
integration/pgbouncer
integration/postgres
integration/powerdns_recursor
integration/sqlserver
integration/ssh_check
integration/supervisord
integration/vsphere
integration/wmi_check
integration/openldap
integration/openstack_controller
integration/ibm_db2
integration/win32_event_log
integration/harbor
labels
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
BaptisteFoy
approved these changes
Nov 26, 2025
buraizu
approved these changes
Nov 26, 2025
steveny91
previously approved these changes
Nov 26, 2025
Contributor
|
Looks good. Can you add a changelog for datadog_checks_dev? |
temporal-github-worker-1
bot
dismissed
steveny91’s stale review
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- datadog_checks_dev/changelog.d/21975.fixed
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
eric-weaver
approved these changes
Dec 1, 2025
steveny91
approved these changes
Dec 2, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
mrafi97
approved these changes
Dec 2, 2025
apiazza-dd
approved these changes
Dec 5, 2025
ddog-nasirthomas
pushed a commit
that referenced
this pull request
Dec 8, 2025
* fix(json-specs): add secret flags on all secret fields * fix(json-specs): add secret flags on all secret fields - add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
secretflag on all the sensitive fields so that they can be treated as secrets by Fleet Automation.Motivation
https://datadoghq.atlassian.net/browse/FA-1028
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged