Skip to content

Provide a safe default stackwalker for non-hotspot JVMs #9930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

Provide a safe default stackwalker for non-hotspot JVMs #9930

merged 1 commit into from
Nov 12, 2025

Conversation

@jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Nov 11, 2025

What Does This Do

It adds a code to 'sanitize' the 'cstack' profiler configuration in order to avoid unsupported usecases.

Motivation

Recently, we switched the default profiler stackwalker to 'cstack' - however, this is not supported by non-hotspot JVMs.
We need a decent fallback to avoid non-functioning profiler stackwalking.

Additional Notes

Contributor Checklist

@jbachorik jbachorik added type: enhancement Enhancements and improvements comp: profiling Profiling labels Nov 11, 2025
@jbachorik jbachorik requested review from a team as code owners November 11, 2025 13:22
@jbachorik jbachorik requested review from bric3 and removed request for a team November 11, 2025 13:22
@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/vm_j9
git_commit_date 1762864555 1762871196
git_commit_sha 1397f25 bd924bd
release_version 1.56.0-SNAPSHOT~1397f25f48 1.56.0-SNAPSHOT~bd924bd3c0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762873024 1762873024
ci_job_id 1227556569 1227556569
ci_pipeline_id 81943193 81943193
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-9stromey 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-9stromey 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052487
Total [baseline] (10.684 s) : 0, 10684045
Agent [candidate] (1.051 s) : 0, 1051445
Total [candidate] (10.685 s) : 0, 10684932
section appsec
Agent [baseline] (1.221 s) : 0, 1220628
Total [baseline] (10.951 s) : 0, 10951435
Agent [candidate] (1.223 s) : 0, 1222999
Total [candidate] (10.793 s) : 0, 10792932
section iast
Agent [baseline] (1.178 s) : 0, 1178169
Total [baseline] (11.182 s) : 0, 11182354
Agent [candidate] (1.196 s) : 0, 1196382
Total [candidate] (11.145 s) : 0, 11145295
section profiling
Agent [baseline] (1.189 s) : 0, 1189412
Total [baseline] (10.839 s) : 0, 10838933
Agent [candidate] (1.193 s) : 0, 1193132
Total [candidate] (10.875 s) : 0, 10875369
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.221 s 168.141 ms (16.0%)
Agent iast 1.178 s 125.681 ms (11.9%)
Agent profiling 1.189 s 136.924 ms (13.0%)
Total tracing 10.684 s -
Total appsec 10.951 s 267.39 ms (2.5%)
Total iast 11.182 s 498.309 ms (4.7%)
Total profiling 10.839 s 154.888 ms (1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent appsec 1.223 s 171.555 ms (16.3%)
Agent iast 1.196 s 144.937 ms (13.8%)
Agent profiling 1.193 s 141.687 ms (13.5%)
Total tracing 10.685 s -
Total appsec 10.793 s 108.0 ms (1.0%)
Total iast 11.145 s 460.364 ms (4.3%)
Total profiling 10.875 s 190.437 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (709.536 ms) : 0, 709536
BytebuddyAgent [candidate] (709.332 ms) : 0, 709332
GlobalTracer [baseline] (245.891 ms) : 0, 245891
GlobalTracer [candidate] (245.682 ms) : 0, 245682
AppSec [baseline] (32.441 ms) : 0, 32441
AppSec [candidate] (32.36 ms) : 0, 32360
Debugger [baseline] (6.419 ms) : 0, 6419
Debugger [candidate] (6.375 ms) : 0, 6375
Remote Config [baseline] (717.587 µs) : 0, 718
Remote Config [candidate] (711.166 µs) : 0, 711
Telemetry [baseline] (12.347 ms) : 0, 12347
Telemetry [candidate] (14.907 ms) : 0, 14907
Flare Poller [baseline] (8.841 ms) : 0, 8841
Flare Poller [candidate] (5.768 ms) : 0, 5768
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (729.054 ms) : 0, 729054
BytebuddyAgent [candidate] (730.824 ms) : 0, 730824
GlobalTracer [baseline] (236.952 ms) : 0, 236952
GlobalTracer [candidate] (237.51 ms) : 0, 237510
AppSec [baseline] (174.21 ms) : 0, 174210
AppSec [candidate] (174.29 ms) : 0, 174290
Debugger [baseline] (6.016 ms) : 0, 6016
Debugger [candidate] (6.0 ms) : 0, 6000
Remote Config [baseline] (660.894 µs) : 0, 661
Remote Config [candidate] (653.439 µs) : 0, 653
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.608 ms) : 0, 8608
Flare Poller [baseline] (4.024 ms) : 0, 4024
Flare Poller [candidate] (3.988 ms) : 0, 3988
IAST [baseline] (24.817 ms) : 0, 24817
IAST [candidate] (24.847 ms) : 0, 24847
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.494 ms) : 0, 1494
BytebuddyAgent [baseline] (827.178 ms) : 0, 827178
BytebuddyAgent [candidate] (841.444 ms) : 0, 841444
GlobalTracer [baseline] (234.567 ms) : 0, 234567
GlobalTracer [candidate] (236.928 ms) : 0, 236928
AppSec [baseline] (27.124 ms) : 0, 27124
AppSec [candidate] (29.204 ms) : 0, 29204
Debugger [baseline] (5.989 ms) : 0, 5989
Debugger [candidate] (6.085 ms) : 0, 6085
Remote Config [baseline] (598.7 µs) : 0, 599
Remote Config [candidate] (601.143 µs) : 0, 601
Telemetry [baseline] (8.362 ms) : 0, 8362
Telemetry [candidate] (8.559 ms) : 0, 8559
Flare Poller [baseline] (4.162 ms) : 0, 4162
Flare Poller [candidate] (4.144 ms) : 0, 4144
IAST [baseline] (33.98 ms) : 0, 33980
IAST [candidate] (32.876 ms) : 0, 32876
section profiling
ProfilingAgent [baseline] (109.949 ms) : 0, 109949
ProfilingAgent [candidate] (110.897 ms) : 0, 110897
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (727.439 ms) : 0, 727439
BytebuddyAgent [candidate] (729.703 ms) : 0, 729703
GlobalTracer [baseline] (221.559 ms) : 0, 221559
GlobalTracer [candidate] (221.82 ms) : 0, 221820
AppSec [baseline] (31.982 ms) : 0, 31982
AppSec [candidate] (32.153 ms) : 0, 32153
Debugger [baseline] (7.477 ms) : 0, 7477
Debugger [candidate] (10.405 ms) : 0, 10405
Remote Config [baseline] (673.664 µs) : 0, 674
Remote Config [candidate] (674.682 µs) : 0, 675
Telemetry [baseline] (15.113 ms) : 0, 15113
Telemetry [candidate] (12.269 ms) : 0, 12269
Flare Poller [baseline] (4.095 ms) : 0, 4095
Flare Poller [candidate] (4.143 ms) : 0, 4143
Profiling [baseline] (110.617 ms) : 0, 110617
Profiling [candidate] (111.572 ms) : 0, 111572
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048232
Total [baseline] (8.649 s) : 0, 8648713
Agent [candidate] (1.054 s) : 0, 1053744
Total [candidate] (8.62 s) : 0, 8619912
section iast
Agent [baseline] (1.187 s) : 0, 1186520
Total [baseline] (9.251 s) : 0, 9251481
Agent [candidate] (1.186 s) : 0, 1185805
Total [candidate] (9.235 s) : 0, 9235408
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.187 s 138.288 ms (13.2%)
Total tracing 8.649 s -
Total iast 9.251 s 602.768 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.186 s 132.061 ms (12.5%)
Total tracing 8.62 s -
Total iast 9.235 s 615.496 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (705.378 ms) : 0, 705378
BytebuddyAgent [candidate] (709.163 ms) : 0, 709163
GlobalTracer [baseline] (246.044 ms) : 0, 246044
GlobalTracer [candidate] (247.124 ms) : 0, 247124
AppSec [baseline] (32.537 ms) : 0, 32537
AppSec [candidate] (32.798 ms) : 0, 32798
Debugger [baseline] (6.424 ms) : 0, 6424
Debugger [candidate] (6.469 ms) : 0, 6469
Remote Config [baseline] (727.649 µs) : 0, 728
Remote Config [candidate] (719.226 µs) : 0, 719
Telemetry [baseline] (12.189 ms) : 0, 12189
Telemetry [candidate] (12.938 ms) : 0, 12938
Flare Poller [baseline] (8.775 ms) : 0, 8775
Flare Poller [candidate] (8.243 ms) : 0, 8243
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (834.723 ms) : 0, 834723
BytebuddyAgent [candidate] (833.997 ms) : 0, 833997
GlobalTracer [baseline] (235.074 ms) : 0, 235074
GlobalTracer [candidate] (235.306 ms) : 0, 235306
IAST [baseline] (33.355 ms) : 0, 33355
IAST [candidate] (33.59 ms) : 0, 33590
AppSec [baseline] (27.758 ms) : 0, 27758
AppSec [candidate] (27.646 ms) : 0, 27646
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (5.942 ms) : 0, 5942
Remote Config [baseline] (598.997 µs) : 0, 599
Remote Config [candidate] (593.124 µs) : 0, 593
Telemetry [baseline] (8.427 ms) : 0, 8427
Telemetry [candidate] (8.326 ms) : 0, 8326
Flare Poller [baseline] (4.168 ms) : 0, 4168
Flare Poller [candidate] (4.102 ms) : 0, 4102
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/vm_j9
git_commit_date 1762864555 1762871196
git_commit_sha 1397f25 bd924bd
release_version 1.56.0-SNAPSHOT~1397f25f48 1.56.0-SNAPSHOT~bd924bd3c0
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762873528 1762873528
ci_job_id 1227556570 1227556570
ci_pipeline_id 81943193 81943193
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-bmce7d2f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-bmce7d2f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-188.873µs; -84.298µs] or [-6.498%; -2.900%]		 same
[-344.552µs; +69.519µs] or [-4.242%; +0.856%]		 unstable
[-104.926op/s; +175.238op/s] or [-8.409%; +14.045%]		 2.770ms 7.984ms 1282.875op/s 2.907ms 8.122ms 1247.719op/s
scenario:load:petclinic:code_origins:high_load worse
[+0.787ms; +1.534ms] or [+4.590%; +8.945%]		 unsure
[+0.406ms; +1.668ms] or [+1.439%; +5.906%]		 unstable
[-40.474op/s; +12.474op/s] or [-15.290%; +4.712%]		 18.313ms 29.281ms 250.719op/s 17.152ms 28.244ms 264.719op/s
scenario:load:petclinic:profiling:high_load better
[-2.574ms; -2.057ms] or [-12.591%; -10.061%]		 better
[-2.908ms; -1.385ms] or [-9.018%; -4.295%]		 unstable
[+0.489op/s; +48.886op/s] or [+0.216%; +21.643%]		 18.126ms 30.102ms 250.562op/s 20.441ms 32.249ms 225.875op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.805 ms) : 18618, 18992
.   : milestone, 18805,
appsec (18.702 ms) : 18513, 18890
.   : milestone, 18702,
code_origins (17.626 ms) : 17450, 17801
.   : milestone, 17626,
iast (18.408 ms) : 18223, 18592
.   : milestone, 18408,
profiling (20.68 ms) : 20475, 20886
.   : milestone, 20680,
tracing (18.226 ms) : 18044, 18408
.   : milestone, 18226,
section candidate
no_agent (18.131 ms) : 17948, 18314
.   : milestone, 18131,
appsec (18.974 ms) : 18780, 19168
.   : milestone, 18974,
code_origins (18.612 ms) : 18427, 18797
.   : milestone, 18612,
iast (18.111 ms) : 17928, 18295
.   : milestone, 18111,
profiling (18.631 ms) : 18440, 18823
.   : milestone, 18631,
tracing (17.929 ms) : 17749, 18109
.   : milestone, 17929,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.805 ms [18.618 ms, 18.992 ms] -
appsec 18.702 ms [18.513 ms, 18.89 ms] -103.026 µs (-0.5%)
code_origins 17.626 ms [17.45 ms, 17.801 ms] -1.179 ms (-6.3%)
iast 18.408 ms [18.223 ms, 18.592 ms] -397.367 µs (-2.1%)
profiling 20.68 ms [20.475 ms, 20.886 ms] 1.876 ms (10.0%)
tracing 18.226 ms [18.044 ms, 18.408 ms] -579.173 µs (-3.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.131 ms [17.948 ms, 18.314 ms] -
appsec 18.974 ms [18.78 ms, 19.168 ms] 843.03 µs (4.6%)
code_origins 18.612 ms [18.427 ms, 18.797 ms] 481.143 µs (2.7%)
iast 18.111 ms [17.928 ms, 18.295 ms] -19.918 µs (-0.1%)
profiling 18.631 ms [18.44 ms, 18.823 ms] 499.984 µs (2.8%)
tracing 17.929 ms [17.749 ms, 18.109 ms] -202.359 µs (-1.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.206 ms) : 1193, 1218
.   : milestone, 1206,
iast (3.261 ms) : 3215, 3306
.   : milestone, 3261,
iast_FULL (5.831 ms) : 5772, 5891
.   : milestone, 5831,
iast_GLOBAL (3.678 ms) : 3619, 3737
.   : milestone, 3678,
profiling (1.999 ms) : 1981, 2017
.   : milestone, 1999,
tracing (1.785 ms) : 1770, 1800
.   : milestone, 1785,
section candidate
no_agent (1.202 ms) : 1190, 1214
.   : milestone, 1202,
iast (3.245 ms) : 3201, 3289
.   : milestone, 3245,
iast_FULL (5.715 ms) : 5657, 5773
.   : milestone, 5715,
iast_GLOBAL (3.575 ms) : 3514, 3636
.   : milestone, 3575,
profiling (2.02 ms) : 2003, 2037
.   : milestone, 2020,
tracing (1.787 ms) : 1773, 1802
.   : milestone, 1787,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.206 ms [1.193 ms, 1.218 ms] -
iast 3.261 ms [3.215 ms, 3.306 ms] 2.055 ms (170.5%)
iast_FULL 5.831 ms [5.772 ms, 5.891 ms] 4.626 ms (383.7%)
iast_GLOBAL 3.678 ms [3.619 ms, 3.737 ms] 2.473 ms (205.1%)
profiling 1.999 ms [1.981 ms, 2.017 ms] 793.437 µs (65.8%)
tracing 1.785 ms [1.77 ms, 1.8 ms] 579.524 µs (48.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.202 ms [1.19 ms, 1.214 ms] -
iast 3.245 ms [3.201 ms, 3.289 ms] 2.043 ms (170.0%)
iast_FULL 5.715 ms [5.657 ms, 5.773 ms] 4.513 ms (375.5%)
iast_GLOBAL 3.575 ms [3.514 ms, 3.636 ms] 2.373 ms (197.4%)
profiling 2.02 ms [2.003 ms, 2.037 ms] 817.617 µs (68.0%)
tracing 1.787 ms [1.773 ms, 1.802 ms] 585.339 µs (48.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/vm_j9
git_commit_date 1762864555 1762871196
git_commit_sha 1397f25 bd924bd
release_version 1.56.0-SNAPSHOT~1397f25f48 1.56.0-SNAPSHOT~bd924bd3c0
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762873200 1762873200
ci_job_id 1227556571 1227556571
ci_pipeline_id 81943193 81943193
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-4egb9a8d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-4egb9a8d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (3.654 ms) : 3440, 3869
.   : milestone, 3654,
iast (2.204 ms) : 2141, 2267
.   : milestone, 2204,
iast_GLOBAL (2.247 ms) : 2184, 2311
.   : milestone, 2247,
profiling (2.482 ms) : 2317, 2647
.   : milestone, 2482,
tracing (2.02 ms) : 1972, 2069
.   : milestone, 2020,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.643 ms) : 3430, 3856
.   : milestone, 3643,
iast (2.197 ms) : 2135, 2260
.   : milestone, 2197,
iast_GLOBAL (2.248 ms) : 2185, 2311
.   : milestone, 2248,
profiling (2.037 ms) : 1987, 2088
.   : milestone, 2037,
tracing (2.02 ms) : 1971, 2069
.   : milestone, 2020,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 3.654 ms [3.44 ms, 3.869 ms] 2.181 ms (148.0%)
iast 2.204 ms [2.141 ms, 2.267 ms] 730.781 µs (49.6%)
iast_GLOBAL 2.247 ms [2.184 ms, 2.311 ms] 773.843 µs (52.5%)
profiling 2.482 ms [2.317 ms, 2.647 ms] 1.009 ms (68.5%)
tracing 2.02 ms [1.972 ms, 2.069 ms] 546.863 µs (37.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 3.643 ms [3.43 ms, 3.856 ms] 2.167 ms (146.9%)
iast 2.197 ms [2.135 ms, 2.26 ms] 721.553 µs (48.9%)
iast_GLOBAL 2.248 ms [2.185 ms, 2.311 ms] 772.31 µs (52.3%)
profiling 2.037 ms [1.987 ms, 2.088 ms] 561.343 µs (38.0%)
tracing 2.02 ms [1.971 ms, 2.069 ms] 544.031 µs (36.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bd924bd3c0, baseline=1.56.0-SNAPSHOT~1397f25f48
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.594 s) : 15594000, 15594000
.   : milestone, 15594000,
appsec (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
iast (18.431 s) : 18431000, 18431000
.   : milestone, 18431000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
.   : milestone, 18048000,
profiling (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
tracing (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
section candidate
no_agent (15.588 s) : 15588000, 15588000
.   : milestone, 15588000,
appsec (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
iast (18.739 s) : 18739000, 18739000
.   : milestone, 18739000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
.   : milestone, 17790000,
profiling (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
tracing (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.594 s [15.594 s, 15.594 s] -
appsec 15.029 s [15.029 s, 15.029 s] -565.0 ms (-3.6%)
iast 18.431 s [18.431 s, 18.431 s] 2.837 s (18.2%)
iast_GLOBAL 18.048 s [18.048 s, 18.048 s] 2.454 s (15.7%)
profiling 14.947 s [14.947 s, 14.947 s] -647.0 ms (-4.1%)
tracing 14.826 s [14.826 s, 14.826 s] -768.0 ms (-4.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.588 s [15.588 s, 15.588 s] -
appsec 14.985 s [14.985 s, 14.985 s] -603.0 ms (-3.9%)
iast 18.739 s [18.739 s, 18.739 s] 3.151 s (20.2%)
iast_GLOBAL 17.79 s [17.79 s, 17.79 s] 2.202 s (14.1%)
profiling 14.991 s [14.991 s, 14.991 s] -597.0 ms (-3.8%)
tracing 14.937 s [14.937 s, 14.937 s] -651.0 ms (-4.2%)

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Nov 11, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.60% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bd924bd | Docs | Datadog PR Page | Was this helpful? Give us feedback!

rkennke
rkennke approved these changes Nov 12, 2025
View reviewed changes
Copy link

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Nov 12, 2025
View reviewed changes
...g/profiling-ddprof/src/test/java/com/datadog/profiling/ddprof/DatadogProfilerConfigTest.java
}

@ParameterizedTest
@MethodSource("zingStackwalkerTestCases")
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion. I believe that @CsvSource would be a better choice here. More readable.
Here and similar places in this test.

Copy link
Contributor Author

@jbachorik jbachorik Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, I've just noticed that. Will do that as a followup ...

@jbachorik jbachorik merged commit c17d0e8 into master Nov 12, 2025
539 checks passed
@jbachorik jbachorik deleted the jb/vm_j9 branch November 12, 2025 15:41
@jbachorik jbachorik mentioned this pull request Nov 12, 2025
Open
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD left review comments

@rkennke rkennke rkennke approved these changes

@bric3 bric3 Awaiting requested review from bric3 bric3 is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

comp: profiling Profiling type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jbachorik @rkennke @AlexeyKuznetsov-DD