fix JDBC's SQLCommenter not taking into account semicolons #9915

na-ji · 2025-11-07T13:32:06Z

Motivation

After adding the new always append comment feature in #9798, a customer found a bug that was present in our SQL Commenter since a long time. Basically, JDBC always split queries to send to the DB on the semicolon. If a comment is after a semicolon, JDBC will still split the queries, and return multiple ResultSet. This provoked exceptions like this one:

org.postgresql.util.PSQLException: Multiple ResultSets were returned by
the query

What Does This Do

The SQL Commenter now correctly handles queries that ends with a semicolon. Instead of injecting the comment at the end, it will inject the comment before the semicolon.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: SDBM-2100

datadog-datadog-prod-us1 · 2025-11-07T13:50:59Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 73.62% (+13.99%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f16df98 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-11-07T14:23:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762962102	1762964628
git_commit_sha	`c17d0e8`	`f16df98`
release_version	1.56.0-SNAPSHOT~c17d0e83ec	1.56.0-SNAPSHOT~f16df987c1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762968023	1762968023
ci_job_id	1230442897	1230442897
ci_pipeline_id	82117257	82117257
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-8bl3sw2a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-8bl3sw2a 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101117
Total [baseline] (8.851 s) : 0, 8851193
Agent [candidate] (1.106 s) : 0, 1105860
Total [candidate] (8.832 s) : 0, 8832218
section iast
Agent [baseline] (1.24 s) : 0, 1240266
Total [baseline] (9.551 s) : 0, 9551280
Agent [candidate] (1.242 s) : 0, 1241833
Total [candidate] (9.556 s) : 0, 9556244

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.101 s	-
Agent	iast	1.24 s	139.149 ms (12.6%)
Total	tracing	8.851 s	-
Total	iast	9.551 s	700.086 ms (7.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.106 s	-
Agent	iast	1.242 s	135.973 ms (12.3%)
Total	tracing	8.832 s	-
Total	iast	9.556 s	724.026 ms (8.2%)

gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (704.476 ms) : 0, 704476
BytebuddyAgent [candidate] (707.026 ms) : 0, 707026
GlobalTracer [baseline] (247.754 ms) : 0, 247754
GlobalTracer [candidate] (248.948 ms) : 0, 248948
AppSec [baseline] (32.21 ms) : 0, 32210
AppSec [candidate] (32.437 ms) : 0, 32437
Debugger [baseline] (67.994 ms) : 0, 67994
Debugger [candidate] (68.598 ms) : 0, 68598
Remote Config [baseline] (634.97 µs) : 0, 635
Remote Config [candidate] (624.238 µs) : 0, 624
Telemetry [baseline] (8.16 ms) : 0, 8160
Telemetry [candidate] (8.233 ms) : 0, 8233
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.751 ms) : 0, 3751
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (828.44 ms) : 0, 828440
BytebuddyAgent [candidate] (829.298 ms) : 0, 829298
GlobalTracer [baseline] (237.796 ms) : 0, 237796
GlobalTracer [candidate] (237.884 ms) : 0, 237884
AppSec [baseline] (31.408 ms) : 0, 31408
AppSec [candidate] (33.087 ms) : 0, 33087
Debugger [baseline] (64.692 ms) : 0, 64692
Debugger [candidate] (65.223 ms) : 0, 65223
Remote Config [baseline] (547.541 µs) : 0, 548
Remote Config [candidate] (554.717 µs) : 0, 555
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (7.652 ms) : 0, 7652
Flare Poller [baseline] (3.516 ms) : 0, 3516
Flare Poller [candidate] (3.583 ms) : 0, 3583
IAST [baseline] (29.984 ms) : 0, 29984
IAST [candidate] (28.333 ms) : 0, 28333

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.109 s) : 0, 1109118
Total [baseline] (10.816 s) : 0, 10816182
Agent [candidate] (1.106 s) : 0, 1106418
Total [candidate] (10.781 s) : 0, 10780727
section appsec
Agent [baseline] (1.287 s) : 0, 1286561
Total [baseline] (11.127 s) : 0, 11126670
Agent [candidate] (1.286 s) : 0, 1285547
Total [candidate] (11.212 s) : 0, 11211930
section iast
Agent [baseline] (1.262 s) : 0, 1261829
Total [baseline] (11.365 s) : 0, 11364914
Agent [candidate] (1.252 s) : 0, 1251811
Total [candidate] (11.364 s) : 0, 11364065
section profiling
Agent [baseline] (1.236 s) : 0, 1236077
Total [baseline] (11.071 s) : 0, 11071117
Agent [candidate] (1.237 s) : 0, 1236854
Total [candidate] (11.084 s) : 0, 11083905

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.109 s	-
Agent	appsec	1.287 s	177.444 ms (16.0%)
Agent	iast	1.262 s	152.711 ms (13.8%)
Agent	profiling	1.236 s	126.959 ms (11.4%)
Total	tracing	10.816 s	-
Total	appsec	11.127 s	310.488 ms (2.9%)
Total	iast	11.365 s	548.733 ms (5.1%)
Total	profiling	11.071 s	254.936 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.106 s	-
Agent	appsec	1.286 s	179.13 ms (16.2%)
Agent	iast	1.252 s	145.393 ms (13.1%)
Agent	profiling	1.237 s	130.436 ms (11.8%)
Total	tracing	10.781 s	-
Total	appsec	11.212 s	431.202 ms (4.0%)
Total	iast	11.364 s	583.338 ms (5.4%)
Total	profiling	11.084 s	303.178 ms (2.8%)

gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (708.144 ms) : 0, 708144
BytebuddyAgent [candidate] (706.237 ms) : 0, 706237
GlobalTracer [baseline] (250.691 ms) : 0, 250691
GlobalTracer [candidate] (249.347 ms) : 0, 249347
AppSec [baseline] (32.556 ms) : 0, 32556
AppSec [candidate] (32.436 ms) : 0, 32436
Debugger [baseline] (69.059 ms) : 0, 69059
Debugger [candidate] (69.338 ms) : 0, 69338
Remote Config [baseline] (635.346 µs) : 0, 635
Remote Config [candidate] (705.136 µs) : 0, 705
Telemetry [baseline] (8.082 ms) : 0, 8082
Telemetry [candidate] (8.281 ms) : 0, 8281
Flare Poller [baseline] (3.703 ms) : 0, 3703
Flare Poller [candidate] (3.788 ms) : 0, 3788
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (735.007 ms) : 0, 735007
BytebuddyAgent [candidate] (731.349 ms) : 0, 731349
GlobalTracer [baseline] (241.359 ms) : 0, 241359
GlobalTracer [candidate] (242.858 ms) : 0, 242858
AppSec [baseline] (174.854 ms) : 0, 174854
AppSec [candidate] (174.563 ms) : 0, 174563
Debugger [baseline] (61.098 ms) : 0, 61098
Debugger [candidate] (62.553 ms) : 0, 62553
Remote Config [baseline] (641.123 µs) : 0, 641
Remote Config [candidate] (674.202 µs) : 0, 674
Telemetry [baseline] (8.472 ms) : 0, 8472
Telemetry [candidate] (8.372 ms) : 0, 8372
Flare Poller [baseline] (3.868 ms) : 0, 3868
Flare Poller [candidate] (3.933 ms) : 0, 3933
IAST [baseline] (24.865 ms) : 0, 24865
IAST [candidate] (25.004 ms) : 0, 25004
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (844.285 ms) : 0, 844285
BytebuddyAgent [candidate] (835.736 ms) : 0, 835736
GlobalTracer [baseline] (240.592 ms) : 0, 240592
GlobalTracer [candidate] (239.854 ms) : 0, 239854
AppSec [baseline] (28.758 ms) : 0, 28758
AppSec [candidate] (33.459 ms) : 0, 33459
Debugger [baseline] (66.606 ms) : 0, 66606
Debugger [candidate] (66.115 ms) : 0, 66115
Remote Config [baseline] (570.713 µs) : 0, 571
Remote Config [candidate] (547.548 µs) : 0, 548
Telemetry [baseline] (7.831 ms) : 0, 7831
Telemetry [candidate] (7.673 ms) : 0, 7673
Flare Poller [baseline] (3.616 ms) : 0, 3616
Flare Poller [candidate] (3.554 ms) : 0, 3554
IAST [baseline] (33.082 ms) : 0, 33082
IAST [candidate] (28.552 ms) : 0, 28552
section profiling
ProfilingAgent [baseline] (97.063 ms) : 0, 97063
ProfilingAgent [candidate] (97.027 ms) : 0, 97027
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (731.367 ms) : 0, 731367
BytebuddyAgent [candidate] (732.356 ms) : 0, 732356
GlobalTracer [baseline] (223.047 ms) : 0, 223047
GlobalTracer [candidate] (222.765 ms) : 0, 222765
AppSec [baseline] (32.257 ms) : 0, 32257
AppSec [candidate] (32.407 ms) : 0, 32407
Debugger [baseline] (68.664 ms) : 0, 68664
Debugger [candidate] (68.471 ms) : 0, 68471
Remote Config [baseline] (660.534 µs) : 0, 661
Remote Config [candidate] (667.783 µs) : 0, 668
Telemetry [baseline] (8.035 ms) : 0, 8035
Telemetry [candidate] (8.001 ms) : 0, 8001
Flare Poller [baseline] (3.83 ms) : 0, 3830
Flare Poller [candidate] (3.801 ms) : 0, 3801
Profiling [baseline] (97.636 ms) : 0, 97636
Profiling [candidate] (97.6 ms) : 0, 97600

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762962102	1762964628
git_commit_sha	`c17d0e8`	`f16df98`
release_version	1.56.0-SNAPSHOT~c17d0e83ec	1.56.0-SNAPSHOT~f16df987c1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1762968898	1762968898
ci_job_id	1230585346	1230585346
ci_pipeline_id	82117257	82117257
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-ppb1grgh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-ppb1grgh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	better [-507.439µs; -248.361µs] or [-9.397%; -4.599%]	better [-1.503ms; -0.666ms] or [-11.516%; -5.101%]	unstable [-27.710op/s; +136.647op/s] or [-3.659%; +18.044%]	5.022ms	11.971ms	811.781op/s	5.400ms	13.056ms	757.312op/s
scenario:load:petclinic:no_agent:high_load	better [-2.164ms; -0.676ms] or [-11.984%; -3.742%]	unstable [-3.344ms; -0.195ms] or [-11.108%; -0.646%]	unstable [-10.409op/s; +47.096op/s] or [-4.111%; +18.601%]	16.639ms	28.336ms	271.531op/s	18.059ms	30.105ms	253.188op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.198 ms) : 1186, 1210
.   : milestone, 1198,
iast (3.309 ms) : 3206, 3412
.   : milestone, 3309,
iast_FULL (6.109 ms) : 6046, 6173
.   : milestone, 6109,
iast_GLOBAL (3.574 ms) : 3518, 3629
.   : milestone, 3574,
profiling (2.169 ms) : 2149, 2189
.   : milestone, 2169,
tracing (1.769 ms) : 1754, 1783
.   : milestone, 1769,
section candidate
no_agent (1.181 ms) : 1169, 1192
.   : milestone, 1181,
iast (3.342 ms) : 3270, 3415
.   : milestone, 3342,
iast_FULL (5.693 ms) : 5637, 5749
.   : milestone, 5693,
iast_GLOBAL (3.627 ms) : 3575, 3679
.   : milestone, 3627,
profiling (2.216 ms) : 2193, 2238
.   : milestone, 2216,
tracing (1.754 ms) : 1740, 1769
.   : milestone, 1754,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.198 ms [1.186 ms, 1.21 ms]	-
iast	3.309 ms [3.206 ms, 3.412 ms]	2.111 ms (176.2%)
iast_FULL	6.109 ms [6.046 ms, 6.173 ms]	4.911 ms (410.0%)
iast_GLOBAL	3.574 ms [3.518 ms, 3.629 ms]	2.376 ms (198.3%)
profiling	2.169 ms [2.149 ms, 2.189 ms]	971.027 µs (81.1%)
tracing	1.769 ms [1.754 ms, 1.783 ms]	570.746 µs (47.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.181 ms [1.169 ms, 1.192 ms]	-
iast	3.342 ms [3.27 ms, 3.415 ms]	2.162 ms (183.1%)
iast_FULL	5.693 ms [5.637 ms, 5.749 ms]	4.512 ms (382.2%)
iast_GLOBAL	3.627 ms [3.575 ms, 3.679 ms]	2.447 ms (207.2%)
profiling	2.216 ms [2.193 ms, 2.238 ms]	1.035 ms (87.7%)
tracing	1.754 ms [1.74 ms, 1.769 ms]	573.702 µs (48.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.435 ms) : 18243, 18627
.   : milestone, 18435,
appsec (18.464 ms) : 18278, 18650
.   : milestone, 18464,
code_origins (17.716 ms) : 17543, 17889
.   : milestone, 17716,
iast (17.579 ms) : 17403, 17755
.   : milestone, 17579,
profiling (18.577 ms) : 18393, 18761
.   : milestone, 18577,
tracing (17.562 ms) : 17387, 17736
.   : milestone, 17562,
section candidate
no_agent (17.181 ms) : 17009, 17354
.   : milestone, 17181,
appsec (18.459 ms) : 18273, 18644
.   : milestone, 18459,
code_origins (17.786 ms) : 17606, 17965
.   : milestone, 17786,
iast (17.596 ms) : 17422, 17769
.   : milestone, 17596,
profiling (18.553 ms) : 18364, 18743
.   : milestone, 18553,
tracing (17.55 ms) : 17373, 17727
.   : milestone, 17550,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.435 ms [18.243 ms, 18.627 ms]	-
appsec	18.464 ms [18.278 ms, 18.65 ms]	29.033 µs (0.2%)
code_origins	17.716 ms [17.543 ms, 17.889 ms]	-719.179 µs (-3.9%)
iast	17.579 ms [17.403 ms, 17.755 ms]	-856.179 µs (-4.6%)
profiling	18.577 ms [18.393 ms, 18.761 ms]	142.35 µs (0.8%)
tracing	17.562 ms [17.387 ms, 17.736 ms]	-873.425 µs (-4.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.181 ms [17.009 ms, 17.354 ms]	-
appsec	18.459 ms [18.273 ms, 18.644 ms]	1.278 ms (7.4%)
code_origins	17.786 ms [17.606 ms, 17.965 ms]	604.437 µs (3.5%)
iast	17.596 ms [17.422 ms, 17.769 ms]	414.448 µs (2.4%)
profiling	18.553 ms [18.364 ms, 18.743 ms]	1.372 ms (8.0%)
tracing	17.55 ms [17.373 ms, 17.727 ms]	368.891 µs (2.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	naji.astier/SDBM-2100-fix-SQL-append
git_commit_date	1762962102	1762964628
git_commit_sha	`c17d0e8`	`f16df98`
release_version	1.56.0-SNAPSHOT~c17d0e83ec	1.56.0-SNAPSHOT~f16df987c1

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1762966737	1762966737
ci_job_id	1230442899	1230442899
ci_pipeline_id	82117257	82117257
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-zk1uolbu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-zk1uolbu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (3.704 ms) : 3485, 3922
.   : milestone, 3704,
iast (2.214 ms) : 2150, 2279
.   : milestone, 2214,
iast_GLOBAL (2.263 ms) : 2198, 2328
.   : milestone, 2263,
profiling (2.052 ms) : 2000, 2104
.   : milestone, 2052,
tracing (2.04 ms) : 1990, 2091
.   : milestone, 2040,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (3.645 ms) : 3433, 3857
.   : milestone, 3645,
iast (2.217 ms) : 2153, 2282
.   : milestone, 2217,
iast_GLOBAL (2.263 ms) : 2198, 2328
.   : milestone, 2263,
profiling (2.089 ms) : 2034, 2144
.   : milestone, 2089,
tracing (2.042 ms) : 1991, 2092
.   : milestone, 2042,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	3.704 ms [3.485 ms, 3.922 ms]	2.229 ms (151.2%)
iast	2.214 ms [2.15 ms, 2.279 ms]	739.976 µs (50.2%)
iast_GLOBAL	2.263 ms [2.198 ms, 2.328 ms]	788.725 µs (53.5%)
profiling	2.052 ms [2.0 ms, 2.104 ms]	577.45 µs (39.2%)
tracing	2.04 ms [1.99 ms, 2.091 ms]	565.978 µs (38.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	3.645 ms [3.433 ms, 3.857 ms]	2.176 ms (148.0%)
iast	2.217 ms [2.153 ms, 2.282 ms]	747.848 µs (50.9%)
iast_GLOBAL	2.263 ms [2.198 ms, 2.328 ms]	793.532 µs (54.0%)
profiling	2.089 ms [2.034 ms, 2.144 ms]	619.309 µs (42.1%)
tracing	2.042 ms [1.991 ms, 2.092 ms]	572.075 µs (38.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f16df987c1, baseline=1.56.0-SNAPSHOT~c17d0e83ec
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.595 s) : 15595000, 15595000
.   : milestone, 15595000,
appsec (14.553 s) : 14553000, 14553000
.   : milestone, 14553000,
iast (18.42 s) : 18420000, 18420000
.   : milestone, 18420000,
iast_GLOBAL (17.731 s) : 17731000, 17731000
.   : milestone, 17731000,
profiling (14.785 s) : 14785000, 14785000
.   : milestone, 14785000,
tracing (14.863 s) : 14863000, 14863000
.   : milestone, 14863000,
section candidate
no_agent (15.507 s) : 15507000, 15507000
.   : milestone, 15507000,
appsec (14.864 s) : 14864000, 14864000
.   : milestone, 14864000,
iast (18.482 s) : 18482000, 18482000
.   : milestone, 18482000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
.   : milestone, 17924000,
profiling (15.184 s) : 15184000, 15184000
.   : milestone, 15184000,
tracing (14.514 s) : 14514000, 14514000
.   : milestone, 14514000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.595 s [15.595 s, 15.595 s]	-
appsec	14.553 s [14.553 s, 14.553 s]	-1.042 s (-6.7%)
iast	18.42 s [18.42 s, 18.42 s]	2.825 s (18.1%)
iast_GLOBAL	17.731 s [17.731 s, 17.731 s]	2.136 s (13.7%)
profiling	14.785 s [14.785 s, 14.785 s]	-810.0 ms (-5.2%)
tracing	14.863 s [14.863 s, 14.863 s]	-732.0 ms (-4.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.507 s [15.507 s, 15.507 s]	-
appsec	14.864 s [14.864 s, 14.864 s]	-643.0 ms (-4.1%)
iast	18.482 s [18.482 s, 18.482 s]	2.975 s (19.2%)
iast_GLOBAL	17.924 s [17.924 s, 17.924 s]	2.417 s (15.6%)
profiling	15.184 s [15.184 s, 15.184 s]	-323.0 ms (-2.1%)
tracing	14.514 s [14.514 s, 14.514 s]	-993.0 ms (-6.4%)

...gent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java

AlexeyKuznetsov-DD

LGTM

After adding the new always append comment feature in #9798, a customer found a bug that was present in our SQL Commenter since a long time. Basically, JDBC always split queries to send to the DB on the semicolon. If a comment is after a semicolon, JDBC will still split the queries, and return multiple ResultSet. This provoked exceptions like this one: ``` org.postgresql.util.PSQLException: Multiple ResultSets were returned by the query ``` SDBM-2100

na-ji self-assigned this Nov 7, 2025

na-ji added type: bug Bug report and fix inst: jdbc JDBC instrumentation comp: database Database Monitoring labels Nov 7, 2025

na-ji marked this pull request as ready for review November 7, 2025 14:25

na-ji requested a review from a team as a code owner November 7, 2025 14:25

AlexeyKuznetsov-DD reviewed Nov 10, 2025

View reviewed changes

...gent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java Outdated Show resolved Hide resolved

na-ji force-pushed the naji.astier/SDBM-2100-fix-SQL-append branch from 82b9e9c to a180774 Compare November 12, 2025 08:59

na-ji requested review from AlexeyKuznetsov-DD and dougqh November 12, 2025 08:59

AlexeyKuznetsov-DD reviewed Nov 12, 2025

View reviewed changes

...gent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD reviewed Nov 12, 2025

View reviewed changes

...gent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD reviewed Nov 12, 2025

View reviewed changes

...gent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java Outdated Show resolved Hide resolved

na-ji requested a review from AlexeyKuznetsov-DD November 12, 2025 14:48

AlexeyKuznetsov-DD approved these changes Nov 12, 2025

View reviewed changes

na-ji enabled auto-merge (squash) November 12, 2025 16:23

na-ji disabled auto-merge November 12, 2025 16:23

na-ji added 3 commits November 12, 2025 17:23

replace query trimming with manual iteration over query in SQL Commenter

d17335d

improve performance of the detection of semicolon in the SQL commenter

f16df98

na-ji force-pushed the naji.astier/SDBM-2100-fix-SQL-append branch from a597794 to f16df98 Compare November 12, 2025 16:24

dougqh approved these changes Nov 13, 2025

View reviewed changes

na-ji merged commit 256a096 into master Nov 13, 2025
540 checks passed

na-ji deleted the naji.astier/SDBM-2100-fix-SQL-append branch November 13, 2025 20:12

github-actions bot added this to the 1.56.0 milestone Nov 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix JDBC's SQLCommenter not taking into account semicolons #9915

fix JDBC's SQLCommenter not taking into account semicolons #9915

Uh oh!

na-ji commented Nov 7, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix JDBC's SQLCommenter not taking into account semicolons #9915

fix JDBC's SQLCommenter not taking into account semicolons #9915

Uh oh!

Conversation

na-ji commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

What Does This Do

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

na-ji commented Nov 7, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Nov 7, 2025 •

edited

Loading

pr-commenter bot commented Nov 7, 2025 •

edited

Loading

AlexeyKuznetsov-DD left a comment •

edited

Loading