Skip to content

Code cleanup. #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 12, 2025
Merged

Code cleanup. #9911

merged 10 commits into from
Nov 12, 2025

Conversation

@AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Nov 6, 2025 •
edited
Loading

What Does This Do

  1. Cleanup obviously wrong imports (typo error in IDEA).
  2. Use same annotations across code base.
  3. Cleanup JUnit4 leftovers.
  4. Cleanup build files.
  5. Refactored test to not use exotic org.apache.tools.ant.taskdefs.Classloader.

Motivation

Clean code.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Nov 6, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring comp: tooling Build & Tooling labels Nov 6, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review November 6, 2025 21:20
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners November 6, 2025 21:20
@datadog-official
Copy link

datadog-official bot commented Nov 6, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.60% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b09bab7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/code-cleanup
git_commit_date 1762804509 1762808050
git_commit_sha 7aef6ed b09bab7
See matching parameters
Baseline Candidate
ci_job_date 1762809197 1762809197
ci_job_id 1226577563 1226577563
ci_pipeline_id 81877435 81877435
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce unsure
[-66624.093op/s; -3260.838op/s] or [-3.643%; -0.178%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/code-cleanup
git_commit_date 1762797252 1762797422
git_commit_sha 4a54f5a 4e4a75b
See matching parameters
Baseline Candidate
ci_job_date 1762798786 1762798786
ci_job_id 1226078381 1226078381
ci_pipeline_id 81848365 81848365
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/code-cleanup
git_commit_date 1762797252 1762797422
git_commit_sha 4a54f5a 4e4a75b
release_version 1.56.0-SNAPSHOT~4a54f5ae55 1.56.0-SNAPSHOT~4e4a75b63b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762799513 1762799513
ci_job_id 1226078375 1226078375
ci_pipeline_id 81848365 81848365
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-h8xad4uh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-h8xad4uh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048633
Total [baseline] (8.621 s) : 0, 8621342
Agent [candidate] (1.052 s) : 0, 1052339
Total [candidate] (8.672 s) : 0, 8671862
section iast
Agent [baseline] (1.184 s) : 0, 1183943
Total [baseline] (9.277 s) : 0, 9277062
Agent [candidate] (1.179 s) : 0, 1179316
Total [candidate] (9.235 s) : 0, 9235128
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.184 s 135.309 ms (12.9%)
Total tracing 8.621 s -
Total iast 9.277 s 655.72 ms (7.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.179 s 126.977 ms (12.1%)
Total tracing 8.672 s -
Total iast 9.235 s 563.266 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (706.023 ms) : 0, 706023
BytebuddyAgent [candidate] (708.948 ms) : 0, 708948
GlobalTracer [baseline] (245.962 ms) : 0, 245962
GlobalTracer [candidate] (246.224 ms) : 0, 246224
AppSec [baseline] (32.386 ms) : 0, 32386
AppSec [candidate] (32.58 ms) : 0, 32580
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.385 ms) : 0, 6385
Remote Config [baseline] (715.745 µs) : 0, 716
Remote Config [candidate] (712.3 µs) : 0, 712
Telemetry [baseline] (13.714 ms) : 0, 13714
Telemetry [candidate] (10.872 ms) : 0, 10872
Flare Poller [baseline] (7.261 ms) : 0, 7261
Flare Poller [candidate] (10.351 ms) : 0, 10351
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (832.52 ms) : 0, 832520
BytebuddyAgent [candidate] (828.577 ms) : 0, 828577
GlobalTracer [baseline] (234.909 ms) : 0, 234909
GlobalTracer [candidate] (234.231 ms) : 0, 234231
AppSec [baseline] (26.22 ms) : 0, 26220
AppSec [candidate] (27.861 ms) : 0, 27861
Debugger [baseline] (5.996 ms) : 0, 5996
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (606.659 µs) : 0, 607
Remote Config [candidate] (593.167 µs) : 0, 593
Telemetry [baseline] (8.327 ms) : 0, 8327
Telemetry [candidate] (8.325 ms) : 0, 8325
Flare Poller [baseline] (4.116 ms) : 0, 4116
Flare Poller [candidate] (4.173 ms) : 0, 4173
IAST [baseline] (34.99 ms) : 0, 34990
IAST [candidate] (33.412 ms) : 0, 33412
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045511
Total [baseline] (10.712 s) : 0, 10712245
Agent [candidate] (1.049 s) : 0, 1048534
Total [candidate] (10.788 s) : 0, 10788485
section appsec
Agent [baseline] (1.224 s) : 0, 1223596
Total [baseline] (10.88 s) : 0, 10879934
Agent [candidate] (1.233 s) : 0, 1232768
Total [candidate] (10.903 s) : 0, 10903243
section iast
Agent [baseline] (1.178 s) : 0, 1178362
Total [baseline] (11.142 s) : 0, 11142064
Agent [candidate] (1.187 s) : 0, 1186635
Total [candidate] (11.12 s) : 0, 11119869
section profiling
Agent [baseline] (1.198 s) : 0, 1198312
Total [baseline] (10.955 s) : 0, 10954746
Agent [candidate] (1.19 s) : 0, 1189694
Total [candidate] (10.828 s) : 0, 10827968
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.224 s 178.085 ms (17.0%)
Agent iast 1.178 s 132.851 ms (12.7%)
Agent profiling 1.198 s 152.801 ms (14.6%)
Total tracing 10.712 s -
Total appsec 10.88 s 167.688 ms (1.6%)
Total iast 11.142 s 429.818 ms (4.0%)
Total profiling 10.955 s 242.501 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.233 s 184.234 ms (17.6%)
Agent iast 1.187 s 138.101 ms (13.2%)
Agent profiling 1.19 s 141.16 ms (13.5%)
Total tracing 10.788 s -
Total appsec 10.903 s 114.759 ms (1.1%)
Total iast 11.12 s 331.384 ms (3.1%)
Total profiling 10.828 s 39.484 ms (0.4%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (703.442 ms) : 0, 703442
BytebuddyAgent [candidate] (706.244 ms) : 0, 706244
GlobalTracer [baseline] (245.629 ms) : 0, 245629
GlobalTracer [candidate] (245.968 ms) : 0, 245968
AppSec [baseline] (32.364 ms) : 0, 32364
AppSec [candidate] (32.476 ms) : 0, 32476
Debugger [baseline] (6.437 ms) : 0, 6437
Debugger [candidate] (6.382 ms) : 0, 6382
Remote Config [baseline] (705.139 µs) : 0, 705
Remote Config [candidate] (716.516 µs) : 0, 717
Telemetry [baseline] (12.258 ms) : 0, 12258
Telemetry [candidate] (14.313 ms) : 0, 14313
Flare Poller [baseline] (8.64 ms) : 0, 8640
Flare Poller [candidate] (6.333 ms) : 0, 6333
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (731.3 ms) : 0, 731300
BytebuddyAgent [candidate] (735.125 ms) : 0, 735125
GlobalTracer [baseline] (237.638 ms) : 0, 237638
GlobalTracer [candidate] (240.183 ms) : 0, 240183
AppSec [baseline] (174.266 ms) : 0, 174266
AppSec [candidate] (175.885 ms) : 0, 175885
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (6.169 ms) : 0, 6169
Remote Config [baseline] (654.088 µs) : 0, 654
Remote Config [candidate] (673.218 µs) : 0, 673
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.787 ms) : 0, 8787
Flare Poller [baseline] (3.958 ms) : 0, 3958
Flare Poller [candidate] (4.05 ms) : 0, 4050
IAST [baseline] (24.882 ms) : 0, 24882
IAST [candidate] (25.436 ms) : 0, 25436
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (827.694 ms) : 0, 827694
BytebuddyAgent [candidate] (834.091 ms) : 0, 834091
GlobalTracer [baseline] (234.253 ms) : 0, 234253
GlobalTracer [candidate] (235.836 ms) : 0, 235836
AppSec [baseline] (28.682 ms) : 0, 28682
AppSec [candidate] (28.62 ms) : 0, 28620
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (6.012 ms) : 0, 6012
Remote Config [baseline] (600.851 µs) : 0, 601
Remote Config [candidate] (600.522 µs) : 0, 601
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.415 ms) : 0, 8415
Flare Poller [baseline] (4.115 ms) : 0, 4115
Flare Poller [candidate] (4.176 ms) : 0, 4176
IAST [baseline] (32.351 ms) : 0, 32351
IAST [candidate] (32.589 ms) : 0, 32589
section profiling
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (733.498 ms) : 0, 733498
BytebuddyAgent [candidate] (727.419 ms) : 0, 727419
GlobalTracer [baseline] (222.59 ms) : 0, 222590
GlobalTracer [candidate] (221.111 ms) : 0, 221111
AppSec [baseline] (32.296 ms) : 0, 32296
AppSec [candidate] (32.093 ms) : 0, 32093
Debugger [baseline] (9.959 ms) : 0, 9959
Debugger [candidate] (8.191 ms) : 0, 8191
Remote Config [baseline] (690.513 µs) : 0, 691
Remote Config [candidate] (685.927 µs) : 0, 686
Telemetry [baseline] (12.982 ms) : 0, 12982
Telemetry [candidate] (14.656 ms) : 0, 14656
Flare Poller [baseline] (4.157 ms) : 0, 4157
Flare Poller [candidate] (4.143 ms) : 0, 4143
ProfilingAgent [baseline] (110.589 ms) : 0, 110589
ProfilingAgent [candidate] (110.317 ms) : 0, 110317
Profiling [baseline] (111.243 ms) : 0, 111243
Profiling [candidate] (110.987 ms) : 0, 110987
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/code-cleanup
git_commit_date 1762797252 1762797422
git_commit_sha 4a54f5a 4e4a75b
release_version 1.56.0-SNAPSHOT~4a54f5ae55 1.56.0-SNAPSHOT~4e4a75b63b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1762799943 1762799943
ci_job_id 1226078376 1226078376
ci_pipeline_id 81848365 81848365
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-gtgx8p16 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-gtgx8p16 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load better
[-85.551µs; -52.786µs] or [-4.655%; -2.872%]		 unstable
[-190.999op/s; +377.374op/s] or [-7.807%; +15.425%]		 1.769ms 2539.688op/s 1.838ms 2446.500op/s
scenario:load:petclinic:code_origins:high_load better
[-1181.120µs; -786.210µs] or [-6.329%; -4.213%]		 unstable
[-13.150op/s; +40.837op/s] or [-5.259%; +16.331%]		 17.678ms 263.906op/s 18.662ms 250.062op/s
scenario:load:petclinic:tracing:high_load worse
[+667.318µs; +1077.438µs] or [+3.637%; +5.873%]		 unstable
[-38.550op/s; +15.550op/s] or [-15.157%; +6.114%]		 19.219ms 242.844op/s 18.347ms 254.344op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.338 ms) : 18147, 18528
.   : milestone, 18338,
appsec (18.58 ms) : 18391, 18769
.   : milestone, 18580,
code_origins (18.662 ms) : 18473, 18851
.   : milestone, 18662,
iast (17.697 ms) : 17523, 17871
.   : milestone, 17697,
profiling (18.661 ms) : 18471, 18851
.   : milestone, 18661,
tracing (18.347 ms) : 18164, 18529
.   : milestone, 18347,
section candidate
no_agent (18.199 ms) : 18007, 18391
.   : milestone, 18199,
appsec (18.779 ms) : 18591, 18968
.   : milestone, 18779,
code_origins (17.678 ms) : 17500, 17856
.   : milestone, 17678,
iast (17.747 ms) : 17573, 17922
.   : milestone, 17747,
profiling (18.628 ms) : 18443, 18812
.   : milestone, 18628,
tracing (19.219 ms) : 19021, 19417
.   : milestone, 19219,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.338 ms [18.147 ms, 18.528 ms] -
appsec 18.58 ms [18.391 ms, 18.769 ms] 241.839 µs (1.3%)
code_origins 18.662 ms [18.473 ms, 18.851 ms] 324.137 µs (1.8%)
iast 17.697 ms [17.523 ms, 17.871 ms] -640.856 µs (-3.5%)
profiling 18.661 ms [18.471 ms, 18.851 ms] 323.284 µs (1.8%)
tracing 18.347 ms [18.164 ms, 18.529 ms] 8.758 µs (0.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.199 ms [18.007 ms, 18.391 ms] -
appsec 18.779 ms [18.591 ms, 18.968 ms] 580.55 µs (3.2%)
code_origins 17.678 ms [17.5 ms, 17.856 ms] -520.529 µs (-2.9%)
iast 17.747 ms [17.573 ms, 17.922 ms] -451.538 µs (-2.5%)
profiling 18.628 ms [18.443 ms, 18.812 ms] 428.685 µs (2.4%)
tracing 19.219 ms [19.021 ms, 19.417 ms] 1.02 ms (5.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.219 ms) : 1207, 1231
.   : milestone, 1219,
iast (3.258 ms) : 3218, 3298
.   : milestone, 3258,
iast_FULL (5.825 ms) : 5767, 5884
.   : milestone, 5825,
iast_GLOBAL (3.694 ms) : 3638, 3751
.   : milestone, 3694,
profiling (1.968 ms) : 1951, 1985
.   : milestone, 1968,
tracing (1.838 ms) : 1821, 1855
.   : milestone, 1838,
section candidate
no_agent (1.194 ms) : 1183, 1205
.   : milestone, 1194,
iast (3.163 ms) : 3119, 3207
.   : milestone, 3163,
iast_FULL (5.802 ms) : 5745, 5860
.   : milestone, 5802,
iast_GLOBAL (3.572 ms) : 3511, 3632
.   : milestone, 3572,
profiling (1.937 ms) : 1920, 1954
.   : milestone, 1937,
tracing (1.769 ms) : 1755, 1783
.   : milestone, 1769,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.219 ms [1.207 ms, 1.231 ms] -
iast 3.258 ms [3.218 ms, 3.298 ms] 2.039 ms (167.3%)
iast_FULL 5.825 ms [5.767 ms, 5.884 ms] 4.607 ms (377.9%)
iast_GLOBAL 3.694 ms [3.638 ms, 3.751 ms] 2.475 ms (203.1%)
profiling 1.968 ms [1.951 ms, 1.985 ms] 749.411 µs (61.5%)
tracing 1.838 ms [1.821 ms, 1.855 ms] 619.175 µs (50.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.194 ms [1.183 ms, 1.205 ms] -
iast 3.163 ms [3.119 ms, 3.207 ms] 1.969 ms (164.9%)
iast_FULL 5.802 ms [5.745 ms, 5.86 ms] 4.608 ms (385.9%)
iast_GLOBAL 3.572 ms [3.511 ms, 3.632 ms] 2.378 ms (199.1%)
profiling 1.937 ms [1.92 ms, 1.954 ms] 742.429 µs (62.2%)
tracing 1.769 ms [1.755 ms, 1.783 ms] 574.649 µs (48.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/code-cleanup
git_commit_date 1762797252 1762797422
git_commit_sha 4a54f5a 4e4a75b
release_version 1.56.0-SNAPSHOT~4a54f5ae55 1.56.0-SNAPSHOT~4e4a75b63b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1762799679 1762799679
ci_job_id 1226078377 1226078377
ci_pipeline_id 81848365 81848365
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-g6246qle 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-g6246qle 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
appsec (14.675 s) : 14675000, 14675000
.   : milestone, 14675000,
iast (18.313 s) : 18313000, 18313000
.   : milestone, 18313000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
.   : milestone, 18048000,
profiling (15.81 s) : 15810000, 15810000
.   : milestone, 15810000,
tracing (14.737 s) : 14737000, 14737000
.   : milestone, 14737000,
section candidate
no_agent (15.459 s) : 15459000, 15459000
.   : milestone, 15459000,
appsec (14.733 s) : 14733000, 14733000
.   : milestone, 14733000,
iast (18.356 s) : 18356000, 18356000
.   : milestone, 18356000,
iast_GLOBAL (18.223 s) : 18223000, 18223000
.   : milestone, 18223000,
profiling (15.185 s) : 15185000, 15185000
.   : milestone, 15185000,
tracing (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.966 s [14.966 s, 14.966 s] -
appsec 14.675 s [14.675 s, 14.675 s] -291.0 ms (-1.9%)
iast 18.313 s [18.313 s, 18.313 s] 3.347 s (22.4%)
iast_GLOBAL 18.048 s [18.048 s, 18.048 s] 3.082 s (20.6%)
profiling 15.81 s [15.81 s, 15.81 s] 844.0 ms (5.6%)
tracing 14.737 s [14.737 s, 14.737 s] -229.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.459 s [15.459 s, 15.459 s] -
appsec 14.733 s [14.733 s, 14.733 s] -726.0 ms (-4.7%)
iast 18.356 s [18.356 s, 18.356 s] 2.897 s (18.7%)
iast_GLOBAL 18.223 s [18.223 s, 18.223 s] 2.764 s (17.9%)
profiling 15.185 s [15.185 s, 15.185 s] -274.0 ms (-1.8%)
tracing 14.802 s [14.802 s, 14.802 s] -657.0 ms (-4.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~4e4a75b63b, baseline=1.56.0-SNAPSHOT~4a54f5ae55
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.447 ms) : 2397, 2498
.   : milestone, 2447,
iast (2.199 ms) : 2135, 2263
.   : milestone, 2199,
iast_GLOBAL (2.243 ms) : 2180, 2307
.   : milestone, 2243,
profiling (2.053 ms) : 2001, 2104
.   : milestone, 2053,
tracing (2.033 ms) : 1983, 2083
.   : milestone, 2033,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (3.698 ms) : 3479, 3916
.   : milestone, 3698,
iast (2.208 ms) : 2145, 2272
.   : milestone, 2208,
iast_GLOBAL (2.248 ms) : 2184, 2312
.   : milestone, 2248,
profiling (2.067 ms) : 2014, 2120
.   : milestone, 2067,
tracing (2.025 ms) : 1975, 2075
.   : milestone, 2025,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.447 ms [2.397 ms, 2.498 ms] 974.772 µs (66.2%)
iast 2.199 ms [2.135 ms, 2.263 ms] 726.32 µs (49.3%)
iast_GLOBAL 2.243 ms [2.18 ms, 2.307 ms] 770.612 µs (52.3%)
profiling 2.053 ms [2.001 ms, 2.104 ms] 580.009 µs (39.4%)
tracing 2.033 ms [1.983 ms, 2.083 ms] 560.318 µs (38.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 3.698 ms [3.479 ms, 3.916 ms] 2.227 ms (151.4%)
iast 2.208 ms [2.145 ms, 2.272 ms] 737.426 µs (50.1%)
iast_GLOBAL 2.248 ms [2.184 ms, 2.312 ms] 776.813 µs (52.8%)
profiling 2.067 ms [2.014 ms, 2.12 ms] 596.631 µs (40.6%)
tracing 2.025 ms [1.975 ms, 2.075 ms] 554.465 µs (37.7%)

sarahchen6
sarahchen6 approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners November 7, 2025 15:15
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from evanchooly and removed request for a team November 7, 2025 15:15
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1762808727 1762809072
end_time 2025-11-10T21:06:47 2025-11-10T21:12:33
git_branch master alexeyk/code-cleanup
git_commit_sha 7aef6ed b09bab7
start_time 2025-11-10T21:05:28 2025-11-10T21:11:13
See matching parameters
Baseline Candidate
ci_job_id 1226577566 1226577566
ci_pipeline_id 81877435 81877435
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1762808050 1762808050

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic same worse
[+5.336µs; +20.689µs] or [+1.884%; +7.306%]		 worse
[+4.444µs; +22.156µs] or [+1.513%; +7.544%]		 unstable
[-73.940µs; +84.446µs] or [-10.009%; +11.431%]		 unstable
[-345.385op/s; +82.227op/s] or [-13.125%; +3.125%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-41.566µs; +55.893µs] or [-14.462%; +19.447%]		 unstable
[-55.482µs; +74.752µs] or [-16.921%; +22.797%]		 unstable
[-64.426µs; +88.149µs] or [-18.801%; +25.723%]		 unstable
[-291.270µs; +502.303µs] or [-28.717%; +49.524%]		 same
scenario:loop unsure
[+11.558µs; +16.973µs] or [+0.131%; +0.192%]		 unsure
[+3.499µs; +12.682µs] or [+0.039%; +0.142%]		 unsure
[+4.754µs; +16.214µs] or [+0.053%; +0.180%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (327.898 µs) : 268, 388
.   : milestone, 328,
basic (283.197 µs) : 276, 290
.   : milestone, 283,
loop (8.945 ms) : 8942, 8949
.   : milestone, 8945,
section candidate
noprobe (337.532 µs) : 273, 402
.   : milestone, 338,
basic (296.21 µs) : 288, 304
.   : milestone, 296,
loop (8.954 ms) : 8949, 8958
.   : milestone, 8954,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 327.898 µs [268.121 µs, 387.674 µs]
basic 283.197 µs [276.318 µs, 290.077 µs]
loop 8.945 ms [8.942 ms, 8.949 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 337.532 µs [273.388 µs, 401.677 µs]
basic 296.21 µs [288.121 µs, 304.299 µs]
loop 8.954 ms [8.949 ms, 8.958 ms]

jpbempel
jpbempel approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@jpbempel jpbempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for debugger

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit e1b081e into master Nov 12, 2025
548 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/code-cleanup branch November 12, 2025 13:13
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbempel jpbempel jpbempel approved these changes

@sarahchen6 sarahchen6 sarahchen6 approved these changes

@bric3 bric3 Awaiting requested review from bric3

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels

comp: testing Testing comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.56.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexeyKuznetsov-DD @jpbempel @sarahchen6