-
Notifications
You must be signed in to change notification settings - Fork 315
Add process tags to agent statsd client #9904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| if (null != constantTags && constantTags.length > 0) { | ||
| tagMapping = new TagCombiner(constantTags); | ||
| final List<String> processTags = ProcessTags.getTagsAsStringList(); | ||
| final int processTagSize = processTags != null ? processTags.size() : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raphaelgavache I did not filter right now the process tags meaning that we send all of them systematically. It should be ok but in case it represents an issue, please let me know and we'll craft a whitelist
|
🎯 Code Coverage 🔗 Commit SHA: a784ec9 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061070
Total [baseline] (8.706 s) : 0, 8705908
Agent [candidate] (1.051 s) : 0, 1050711
Total [candidate] (8.662 s) : 0, 8661972
section iast
Agent [baseline] (1.181 s) : 0, 1181490
Total [baseline] (9.274 s) : 0, 9274291
Agent [candidate] (1.182 s) : 0, 1182471
Total [candidate] (9.298 s) : 0, 9298066
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (714.24 ms) : 0, 714240
BytebuddyAgent [candidate] (705.222 ms) : 0, 705222
GlobalTracer [baseline] (248.67 ms) : 0, 248670
GlobalTracer [candidate] (249.359 ms) : 0, 249359
AppSec [baseline] (32.902 ms) : 0, 32902
AppSec [candidate] (32.301 ms) : 0, 32301
Debugger [baseline] (6.537 ms) : 0, 6537
Debugger [candidate] (6.384 ms) : 0, 6384
Remote Config [baseline] (724.68 µs) : 0, 725
Remote Config [candidate] (680.794 µs) : 0, 681
Telemetry [baseline] (14.172 ms) : 0, 14172
Telemetry [candidate] (15.689 ms) : 0, 15689
Flare Poller [baseline] (7.292 ms) : 0, 7292
Flare Poller [candidate] (4.92 ms) : 0, 4920
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (828.4 ms) : 0, 828400
BytebuddyAgent [candidate] (829.469 ms) : 0, 829469
GlobalTracer [baseline] (235.684 ms) : 0, 235684
GlobalTracer [candidate] (237.586 ms) : 0, 237586
IAST [baseline] (30.928 ms) : 0, 30928
IAST [candidate] (33.86 ms) : 0, 33860
AppSec [baseline] (30.663 ms) : 0, 30663
AppSec [candidate] (26.703 ms) : 0, 26703
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.026 ms) : 0, 6026
Remote Config [baseline] (607.115 µs) : 0, 607
Remote Config [candidate] (609.178 µs) : 0, 609
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (7.897 ms) : 0, 7897
Flare Poller [baseline] (4.261 ms) : 0, 4261
Flare Poller [candidate] (4.073 ms) : 0, 4073
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048244
Total [baseline] (10.834 s) : 0, 10834432
Agent [candidate] (1.048 s) : 0, 1047514
Total [candidate] (10.847 s) : 0, 10846587
section appsec
Agent [baseline] (1.221 s) : 0, 1220781
Total [baseline] (11.002 s) : 0, 11001635
Agent [candidate] (1.224 s) : 0, 1223833
Total [candidate] (10.885 s) : 0, 10885033
section iast
Agent [baseline] (1.179 s) : 0, 1179184
Total [baseline] (11.11 s) : 0, 11110353
Agent [candidate] (1.191 s) : 0, 1190851
Total [candidate] (11.178 s) : 0, 11178275
section profiling
Agent [baseline] (1.195 s) : 0, 1195132
Total [baseline] (10.878 s) : 0, 10878281
Agent [candidate] (1.198 s) : 0, 1198012
Total [candidate] (10.924 s) : 0, 10924313
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (705.404 ms) : 0, 705404
BytebuddyAgent [candidate] (703.395 ms) : 0, 703395
GlobalTracer [baseline] (245.938 ms) : 0, 245938
GlobalTracer [candidate] (248.185 ms) : 0, 248185
AppSec [baseline] (32.259 ms) : 0, 32259
AppSec [candidate] (32.259 ms) : 0, 32259
Debugger [baseline] (6.425 ms) : 0, 6425
Debugger [candidate] (6.393 ms) : 0, 6393
Remote Config [baseline] (718.812 µs) : 0, 719
Remote Config [candidate] (676.467 µs) : 0, 676
Telemetry [baseline] (14.393 ms) : 0, 14393
Telemetry [candidate] (14.766 ms) : 0, 14766
Flare Poller [baseline] (6.701 ms) : 0, 6701
Flare Poller [candidate] (5.615 ms) : 0, 5615
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (728.158 ms) : 0, 728158
BytebuddyAgent [candidate] (728.684 ms) : 0, 728684
GlobalTracer [baseline] (236.832 ms) : 0, 236832
GlobalTracer [candidate] (240.56 ms) : 0, 240560
IAST [baseline] (24.716 ms) : 0, 24716
IAST [candidate] (24.767 ms) : 0, 24767
AppSec [baseline] (175.303 ms) : 0, 175303
AppSec [candidate] (174.862 ms) : 0, 174862
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.097 ms) : 0, 6097
Remote Config [baseline] (652.043 µs) : 0, 652
Remote Config [candidate] (657.59 µs) : 0, 658
Telemetry [baseline] (8.62 ms) : 0, 8620
Telemetry [candidate] (7.896 ms) : 0, 7896
Flare Poller [baseline] (4.078 ms) : 0, 4078
Flare Poller [candidate] (4.013 ms) : 0, 4013
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (827.95 ms) : 0, 827950
BytebuddyAgent [candidate] (835.072 ms) : 0, 835072
GlobalTracer [baseline] (234.572 ms) : 0, 234572
GlobalTracer [candidate] (239.062 ms) : 0, 239062
IAST [baseline] (31.725 ms) : 0, 31725
IAST [candidate] (32.576 ms) : 0, 32576
AppSec [baseline] (29.501 ms) : 0, 29501
AppSec [candidate] (28.772 ms) : 0, 28772
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (6.058 ms) : 0, 6058
Remote Config [baseline] (595.831 µs) : 0, 596
Remote Config [candidate] (622.109 µs) : 0, 622
Telemetry [baseline] (8.385 ms) : 0, 8385
Telemetry [candidate] (8.107 ms) : 0, 8107
Flare Poller [baseline] (4.115 ms) : 0, 4115
Flare Poller [candidate] (4.112 ms) : 0, 4112
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (730.144 ms) : 0, 730144
BytebuddyAgent [candidate] (733.396 ms) : 0, 733396
GlobalTracer [baseline] (222.539 ms) : 0, 222539
GlobalTracer [candidate] (222.131 ms) : 0, 222131
AppSec [baseline] (32.248 ms) : 0, 32248
AppSec [candidate] (32.055 ms) : 0, 32055
Debugger [baseline] (8.347 ms) : 0, 8347
Debugger [candidate] (6.718 ms) : 0, 6718
Remote Config [baseline] (689.155 µs) : 0, 689
Remote Config [candidate] (680.063 µs) : 0, 680
Telemetry [baseline] (14.961 ms) : 0, 14961
Telemetry [candidate] (16.103 ms) : 0, 16103
Flare Poller [baseline] (4.114 ms) : 0, 4114
Flare Poller [candidate] (4.133 ms) : 0, 4133
ProfilingAgent [baseline] (110.821 ms) : 0, 110821
ProfilingAgent [candidate] (111.146 ms) : 0, 111146
Profiling [baseline] (111.515 ms) : 0, 111515
Profiling [candidate] (111.801 ms) : 0, 111801
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (18.048 ms) : 17865, 18231
. : milestone, 18048,
appsec (19.2 ms) : 19004, 19396
. : milestone, 19200,
code_origins (17.539 ms) : 17365, 17712
. : milestone, 17539,
iast (18.109 ms) : 17929, 18289
. : milestone, 18109,
profiling (18.677 ms) : 18487, 18867
. : milestone, 18677,
tracing (17.589 ms) : 17414, 17764
. : milestone, 17589,
section candidate
no_agent (17.093 ms) : 16923, 17264
. : milestone, 17093,
appsec (18.897 ms) : 18707, 19087
. : milestone, 18897,
code_origins (17.536 ms) : 17367, 17705
. : milestone, 17536,
iast (17.972 ms) : 17789, 18155
. : milestone, 17972,
profiling (18.535 ms) : 18351, 18719
. : milestone, 18535,
tracing (17.688 ms) : 17512, 17865
. : milestone, 17688,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.174 ms) : 1163, 1185
. : milestone, 1174,
iast (3.21 ms) : 3175, 3246
. : milestone, 3210,
iast_FULL (5.738 ms) : 5681, 5796
. : milestone, 5738,
iast_GLOBAL (3.474 ms) : 3419, 3530
. : milestone, 3474,
profiling (2.067 ms) : 2049, 2086
. : milestone, 2067,
tracing (1.908 ms) : 1891, 1925
. : milestone, 1908,
section candidate
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.162 ms) : 3120, 3204
. : milestone, 3162,
iast_FULL (5.834 ms) : 5776, 5893
. : milestone, 5834,
iast_GLOBAL (3.669 ms) : 3608, 3730
. : milestone, 3669,
profiling (1.963 ms) : 1946, 1980
. : milestone, 1963,
tracing (1.777 ms) : 1762, 1793
. : milestone, 1777,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (18.505 s) : 18505000, 18505000
. : milestone, 18505000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
profiling (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
tracing (14.457 s) : 14457000, 14457000
. : milestone, 14457000,
section candidate
no_agent (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.567 s) : 18567000, 18567000
. : milestone, 18567000,
iast_GLOBAL (17.715 s) : 17715000, 17715000
. : milestone, 17715000,
profiling (15.517 s) : 15517000, 15517000
. : milestone, 15517000,
tracing (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~a784ec9b3f, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.71 ms) : 3495, 3926
. : milestone, 3710,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.085 ms) : 2032, 2139
. : milestone, 2085,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.721 ms) : 3499, 3942
. : milestone, 3721,
iast (2.199 ms) : 2135, 2262
. : milestone, 2199,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.042 ms) : 1992, 2092
. : milestone, 2042,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
communication/src/test/groovy/datadog/communication/monitor/DDAgentStatsDClientTest.groovy
Show resolved
Hide resolved
8482aff to
a784ec9
Compare
What Does This Do
Adds the process tags as constant tags to the statsd clients used by the tracer (i.e. jmxfetch)
Note: process tags may mutate since instrumentations can add some of them when the instrumentation kicks in. That can happen after the statsd client is created. This is a known limitation right now.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]