Skip to content

Fix ros2 sensor msgs support #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ros2 sensor msgs support #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd9dbc
Fix import of numpy_pc2
rpl-simon-waterer Jul 4, 2022
5a35f6c
Fix for ROS2 - convert the PointCloud2 msg data to bytes object for c…
rpl-simon-waterer Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pypcd/numpy_pc2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def pointcloud2_to_array(cloud_msg, split_rgb=False, remove_padding=True):
dtype_list = pointcloud2_to_dtype(cloud_msg)

# parse the cloud into an array
cloud_arr = np.fromstring(cloud_msg.data, dtype_list)
cloud_arr = np.fromstring(cloud_msg.data.tobytes(), dtype_list)

# remove the dummy fields that were added
if remove_padding:
Expand Down
2 changes: 1 addition & 1 deletion pypcd/pypcd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
HAS_SENSOR_MSGS = True
try:
from sensor_msgs.msg import PointField
import numpy_pc2 # needs sensor_msgs
from . import numpy_pc2 # needs sensor_msgs
except ImportError:
HAS_SENSOR_MSGS = False

Expand Down