-
Notifications
You must be signed in to change notification settings - Fork 49
Upgrade monaco editor version #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cythia828
wants to merge
11
commits into
next
Choose a base branch
from
upgrade_monaco_editor_version
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: update molecule@2.0.0-alpha.8 * feat: add welcome * feat: init colortheme && reset workbench * feat: add website ui * feat: improve UI * feat: imporve workbench to support sidebar * feat: support problem panel * feat: support snippetCompletion * feat: support to register action * feat: apiDocPage && unitTest init * feat: improve ui in quick github to visit * feat(website): support quickStart to create new file && code review * fix(website): create file to share data * chore(release): 1.0.0-beta.0 * chore(release): 1.0.0-beta.1 * chore(release): 1.0.0-beta.2 * chore(release): 1.0.0-beta.3 * chore(release): 1.0.0-beta.4 * chore(release): 1.0.0-beta.5 * feat: update demo and others after upgrade monaco-editor's version * feat: update contribute ts and update unit test * feat: bump molecule2.0 from alpha.8 to alpha.10 with monaco-editor@0.52.2 --------- Co-authored-by: beier <beier@dtstack.com> Co-authored-by: zhaoge <>
JackWang032
reviewed
Nov 12, 2025
| }, | ||
| "peerDependencies": { | ||
| "monaco-editor": ">=0.31.0" | ||
| "monaco-editor": ">=0.52.2" |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个宿主版本要求太高了, 0.52.2只是 molecue2.x 的限定版本,主要的API变更都在 contribution.ts 中,看下新的API是从哪个版本开始的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改动范围
monaco-editor升级至0.52.2website升级 molecule 至 alpha.10 版本以兼容 monaco-editor@0.52.2:本次改动基于 https://github.com/DTStack/monaco-sql-languages/pull/189,升级 molecule 至 alpha.10 版本,然后对 website 模块中的 molecule 依赖进行升级。
关联 Issue / PR
#189
#190