Handle pre-contest clarifications

webapp/src/Controller/API/ClarificationController.php

@@ -8,6 +8,7 @@
 use App\Entity\ContestProblem;
 use App\Entity\Team;
 use App\Utils\Utils;
+use DateTime;
 use Doctrine\ORM\NonUniqueResultException;
 use Doctrine\ORM\QueryBuilder;
 use Exception;
@@ -208,6 +209,17 @@ public function addAction(
             } else {
                 throw new BadRequestHttpException('A team can not assign time.');
             }
+        } elseif ($this->isGranted('ROLE_API_WRITER') && $contest->getStartTime() > $time) {
+            $startTime = $contest->getStarttimeString();
+            $startTimeTimeZone = DateTime::createFromFormat('Y-m-d h:i:s e', $startTime)->getTimezone();
+            $now = DateTime::createFromFormat('U.u', (string) $time);
+            $now->setTimezone($startTimeTimeZone); // We can't the timezone in createFromFormat as it always picks UTC.
+            throw new BadRequestHttpException(
+                "Sending a clarification before the contest can disclose restricted information, "
+                . "provide an explicit time when this clarification should be visible. "
+                . "For the start of this contest: " . $contest->getStarttimeString() . ", "
+                . "for the current time: " . $now->format('Y-m-d H:i:s e') . "."
+            );
         }
 
         $clarification->setSubmittime($time);

webapp/src/Controller/Jury/ClarificationController.php

@@ -34,13 +34,30 @@ public function __construct(
         protected readonly EventLogService $eventLogService
     ) {}
 
+    private function warnClarificationBeforeContestStart(): void
+    {
+        $cc = $this->dj->getCurrentContest();
+        $message = "Generic clarifications are visible before contest start.";
+        if ($cc && $cc->getStartTime() > Utils::now()) {
+            $this->addFlash('warning', $message);
+        } elseif (!$cc) {
+            foreach ($this->dj->getCurrentContests() as $cc) {
+                if ($cc->getStartTime() > Utils::now()) {
+                    $this->addFlash('warning', $message);
+                    return;
+                }
+            }
+        }
+    }
+
     #[Route(path: '', name: 'jury_clarifications')]
     public function indexAction(
         #[MapQueryParameter(name: 'filter')]
         ?string $currentFilter = null,
         #[MapQueryParameter(name: 'queue')]
         string $currentQueue = 'all',
     ): Response {
+        $this->warnClarificationBeforeContestStart();
         $categories = $this->config->get('clar_categories');
         if ($contest = $this->dj->getCurrentContest()) {
             $contestIds = [$contest->getCid()];
@@ -116,6 +133,7 @@ public function indexAction(
     #[Route(path: '/{id<\d+>}', name: 'jury_clarification')]
     public function viewAction(Request $request, int $id): Response
     {
+        $this->warnClarificationBeforeContestStart();
         $clarification = $this->em->getRepository(Clarification::class)->find($id);
         if (!$clarification) {
             throw new NotFoundHttpException(sprintf('Clarification with ID %s not found', $id));
@@ -239,6 +257,7 @@ public function composeClarificationAction(
         #[MapQueryParameter]
         ?string $teamto = null,
     ): Response {
+        $this->warnClarificationBeforeContestStart();
         $formData = ['recipient' => JuryClarificationType::RECIPIENT_MUST_SELECT];
 
         if ($teamto !== null) {

webapp/templates/team/partials/index_content.html.twig

@@ -6,6 +6,10 @@
     <h2 id="contestnotstarted" class="text-center">
         Contest {{ contest | printContestStart }}
     </h2>
+    {% if clarifications is not empty %}
+        <h1 class="teamoverview">Clarifications</h1>
+        {% include 'team/partials/clarification_list.html.twig' with {clarifications: clarifications} %}
+    {% endif %}
 {% else %}
 
     <div id="teamscoresummary">