Sourcery refactored DOGE branch #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
214
to
225
| [ | ||
| Button.inline(f"🌟 Bᴇsᴛ - 🎞 ᴍᴋᴠ", data=f"ytdl_download_{vid}_mkv_v"), | ||
| Button.inline('🌟 Bᴇsᴛ - 🎞 ᴍᴋᴠ', data=f"ytdl_download_{vid}_mkv_v"), | ||
| Button.inline( | ||
| f"🌟 Bᴇsᴛ - 🎞 ᴡᴇʙᴍ/ᴍᴘ4", | ||
| data=f"ytdl_download_{vid}_mp4_v", | ||
| '🌟 Bᴇsᴛ - 🎞 ᴡᴇʙᴍ/ᴍᴘ4', data=f"ytdl_download_{vid}_mp4_v" | ||
| ), | ||
| ] | ||
| ] | ||
|
|
Author
There was a problem hiding this comment.
Function download_button refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-301
to
+308
| f"**🚨 Eʀʀoʀ:** The uploader hasn't made this video available in your country." | ||
| "**🚨 Eʀʀoʀ:** The uploader hasn't made this video available in your country." | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function _tubeDl refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/helpers/utils/events.py
Outdated
| async def wowcmydev(user): | ||
| if user in M_ST_RS: | ||
| return f"\n\n<b>🧡 This user is my developer!</b>" | ||
| return '\n\n<b>🧡 This user is my developer!</b>' |
Author
There was a problem hiding this comment.
Function wowcmydev refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/helpers/utils/events.py
Outdated
| async def wowcg_y(user): | ||
| if user in G_YS: | ||
| return f"\n\n<b>🤡 This user has been banned from using Doge.</b>" | ||
| return '\n\n<b>🤡 This user has been banned from using Doge.</b>' |
Author
There was a problem hiding this comment.
Function wowcg_y refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/helpers/utils/events.py
Outdated
| except (TypeError, ValueError) as err: | ||
| LOGS.info(err) | ||
| await edl(dogevent, f"**🚨 Eʀʀoʀ:**\n`ℹ️ Couldn't fetch the chat!`") | ||
| await edl(dogevent, "**🚨 Eʀʀoʀ:**\n`ℹ️ Couldn't fetch the chat!`") |
Author
There was a problem hiding this comment.
Function get_chatinfo refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/helpers/utils/format.py
Outdated
| if "url" in response: | ||
| return response["url"] | ||
| return f"**🚨 Eʀʀoʀ:** While pasting text to site" | ||
| return '**🚨 Eʀʀoʀ:** While pasting text to site' |
Author
There was a problem hiding this comment.
Function paste_message refactored with the following changes:
- Split conditional into multiple branches (
split-or-ifs) - Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Remove redundant conditional (
remove-redundant-if) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
| To Paste the given message/text/code to Telegraph | ||
| """ | ||
| c = title if title else "🐶 Doge UserBot 🐾" | ||
| c = title or "🐶 Doge UserBot 🐾" |
Author
There was a problem hiding this comment.
Function t_paste refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity)
userbot/helpers/utils/paste.py
Outdated
| } | ||
| er = "pasty.lus.pm" | ||
| return {"error": f"`🚨 Unable to reach {er}!`"} | ||
| return {"error": f'`🚨 Unable to reach pasty.lus.pm!`'} |
Author
There was a problem hiding this comment.
Function p_paste refactored with the following changes:
- Inline variable that is only used once (
inline-variable) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
userbot/helpers/utils/paste.py
Outdated
Comment on lines
110
to
109
| er = "spacebin" | ||
| return {"error": f"`🚨 Unable to reach {er}!`"} | ||
| return {"error": f'`🚨 Unable to reach spacebin!`'} |
Author
There was a problem hiding this comment.
Function s_paste refactored with the following changes:
- Inline variable that is only used once (
inline-variable) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
userbot/helpers/utils/paste.py
Outdated
Comment on lines
136
to
134
| er = "nekobin" | ||
| return {"error": f"`🚨 Unable to reach {er}!`"} | ||
| return {"error": f'`🚨 Unable to reach nekobin!`'} |
Author
There was a problem hiding this comment.
Function n_paste refactored with the following changes:
- Inline variable that is only used once (
inline-variable) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
userbot/helpers/utils/paste.py
Outdated
Comment on lines
162
to
159
| er = "catbin" | ||
| return {"error": f"`🚨 Unable to reach {er}!`"} | ||
| return {"error": f'`🚨 Unable to reach catbin!`'} |
Author
There was a problem hiding this comment.
Function d_paste refactored with the following changes:
- Inline variable that is only used once (
inline-variable) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
| "#AFKTRUE \nSet AFK mode to True, and Reason is Not Mentioned", | ||
| ) | ||
| elif media_t != "Sticker" and media_t: | ||
| else: |
Author
There was a problem hiding this comment.
Function afksetter refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
userbot/plugins/afk.py
Outdated
Comment on lines
251
to
257
| last = user.last_name if user.last_name else "" | ||
| last = user.last_name or "" | ||
| fullname = f"{first} {last}" if last else first | ||
| username = f"@{user.username}" if user.username else mention | ||
| me = await event.client.get_me() | ||
| my_mention = f"[{me.first_name}](tg://user?id={me.id})" | ||
| my_first = me.first_name | ||
| my_last = me.last_name if me.last_name else "" | ||
| my_last = me.last_name or "" |
Author
There was a problem hiding this comment.
Function on_afk refactored with the following changes:
- Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Remove redundant conditional (
remove-redundant-if) - Replace if statement with if expression (
assign-if-exp) - Simplify if expression by using or (
or-if-exp-identity) - Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
userbot/plugins/corecmds copy.py
Outdated
Comment on lines
48
to
79
| if event.reply_to_msg_id: | ||
| reply_message = await event.get_reply_message() | ||
| try: | ||
| downloaded_file_name = await event.client.download_media( | ||
| reply_message, | ||
| "userbot/plugins/", | ||
| ) | ||
| if "(" not in downloaded_file_name: | ||
| path1 = Path(downloaded_file_name) | ||
| shortname = path1.stem | ||
| shortestname = shortname.replace(".py", "") | ||
| try: | ||
| load_module(shortestname) | ||
| except ModuleNotFoundError as mnfe: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ | ||
| if not event.reply_to_msg_id: | ||
| return | ||
| reply_message = await event.get_reply_message() | ||
| try: | ||
| downloaded_file_name = await event.client.download_media( | ||
| reply_message, | ||
| "userbot/plugins/", | ||
| ) | ||
| if "(" not in downloaded_file_name: | ||
| path1 = Path(downloaded_file_name) | ||
| shortname = path1.stem | ||
| shortestname = shortname.replace(".py", "") | ||
| try: | ||
| load_module(shortestname) | ||
| except ModuleNotFoundError as mnfe: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ | ||
| \n➡️ `{mnfe}`\ | ||
| \n\ | ||
| \n**🦴 Try to write** `{tr}finstall` **& reply.**", | ||
| 15, | ||
| ) | ||
| 15, | ||
| ) | ||
|
|
||
| try: | ||
| await reply_message.forward_to(PLUGIN_CHANNEL) | ||
| except Exception: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ | ||
| try: | ||
| await reply_message.forward_to(PLUGIN_CHANNEL) | ||
| except Exception: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ |
Author
There was a problem hiding this comment.
Function install refactored with the following changes:
- Add guard clause (
last-if-guard)
userbot/plugins/corecmds copy.py
Outdated
Comment on lines
125
to
151
| if event.reply_to_msg_id: | ||
| reply_message = await event.get_reply_message() | ||
| try: | ||
| downloaded_file_name = await event.client.download_media( | ||
| reply_message, | ||
| "userbot/plugins/", | ||
| ) | ||
| if "(" not in downloaded_file_name: | ||
| path1 = Path(downloaded_file_name) | ||
| shortname = path1.stem | ||
| shortestname = shortname.replace(".py", "") | ||
| try: | ||
| load_module(shortestname) | ||
| except ModuleNotFoundError as e: | ||
| install_pip(e.name) | ||
| sleep(1) | ||
| load_module(shortestname) | ||
| if not event.reply_to_msg_id: | ||
| return | ||
| reply_message = await event.get_reply_message() | ||
| try: | ||
| downloaded_file_name = await event.client.download_media( | ||
| reply_message, | ||
| "userbot/plugins/", | ||
| ) | ||
| if "(" not in downloaded_file_name: | ||
| path1 = Path(downloaded_file_name) | ||
| shortname = path1.stem | ||
| shortestname = shortname.replace(".py", "") | ||
| try: | ||
| load_module(shortestname) | ||
| except ModuleNotFoundError as e: | ||
| install_pip(e.name) | ||
| sleep(1) | ||
| load_module(shortestname) | ||
|
|
||
| try: | ||
| await reply_message.forward_to(PLUGIN_CHANNEL) | ||
| except Exception: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ | ||
| try: | ||
| await reply_message.forward_to(PLUGIN_CHANNEL) | ||
| except Exception: | ||
| remove(downloaded_file_name) | ||
| return await edl( | ||
| event, | ||
| f"**🚨 Eʀʀoʀ:**\ |
Author
There was a problem hiding this comment.
Function finstall refactored with the following changes:
- Add guard clause (
last-if-guard)
userbot/plugins/help copy.py
Outdated
| outstr += f"**🔹 Iɴғo:** __{CMD_INFO[cmd][1]}__\n\n" | ||
| except IndexError: | ||
| outstr += f"**🔹 Iɴғo:** -\n\n" | ||
| outstr += '**🔹 Iɴғo:** -\n\n' |
Author
There was a problem hiding this comment.
Function plugininfo refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/plugins/images.py
Outdated
Comment on lines
262
to
271
| return await edl(dogevent, f"**Error:**\n__Invalid dimension.__") | ||
| return await edl(dogevent, '**Error:**\n__Invalid dimension.__') | ||
| else: | ||
| try: | ||
| nw = int(args[0]) | ||
| except ValueError: | ||
| return await edl(dogevent, f"**Error:**\n__Invalid width.__") | ||
| return await edl(dogevent, '**Error:**\n__Invalid width.__') | ||
| try: | ||
| nh = int(args[1]) | ||
| except ValueError: | ||
| return await edl(dogevent, f"**Error:**\n__Invalid height.__") | ||
| return await edl(dogevent, '**Error:**\n__Invalid height.__') |
Author
There was a problem hiding this comment.
Function iresize refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/plugins/images.py
Outdated
| except BaseException as e: | ||
| system(output[1]) | ||
| await edl(output[0], f"**Error**\n`{str(e)}`") | ||
| await edl(output[0], f'**Error**\n`{e}`') |
Author
There was a problem hiding this comment.
Function txt_art refactored with the following changes:
- Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
userbot/plugins/info.py
Outdated
Comment on lines
496
to
497
| caption += m_st_r if m_st_r else "" | ||
| caption += g_y if g_y else "" | ||
| caption += m_st_r or "" | ||
| caption += g_y or "" |
Author
There was a problem hiding this comment.
Function fetch_info refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity)
userbot/plugins/logo.py
Outdated
Comment on lines
93
to
100
| or f"https://raw.githubusercontent.com/DOG-E/Source/DOGE/Material/LogoBackgrounds/black.jpg" | ||
| or 'https://raw.githubusercontent.com/DOG-E/Source/DOGE/Material/LogoBackgrounds/black.jpg' | ||
| ) | ||
|
|
||
| LOGO_FONT = ( | ||
| gvar("LOGO_FONT") | ||
| or f"https://github.com/DOG-E/Source/raw/DOGE/Material/Fonts/streamster.ttf" | ||
| or 'https://github.com/DOG-E/Source/raw/DOGE/Material/Fonts/streamster.ttf' | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function very refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
sourcery-ai
bot
changed the title
sourcery-ai
bot
force-pushed
the
sourcery/DOGE
branch
from
ad5e2f2 to
fdb7faf
Compare
Comment on lines
20
to
21
|
|
||
|
|
Author
There was a problem hiding this comment.
Lines 67-67 refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| if not self.jsobj: | ||
| return None | ||
| return self.jsobj | ||
| return None if not self.jsobj else self.jsobj |
Author
There was a problem hiding this comment.
Function Main.parse_storage.TheHTMLParser.result refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-339
to
+337
| opt_file = self.options.file | ||
| if opt_file: | ||
| if opt_file := self.options.file: |
Author
There was a problem hiding this comment.
Function Main.create_file_name refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| __license__ = "GNU Affero General Public License v3.0" | ||
| __author__ = "DogeUserBot < https://github.com/DOG-E/DogeUserBot >" | ||
| __copyright__ = "©️ Copyright 2021, " + __author__ | ||
| __copyright__ = f"©️ Copyright 2021, {__author__}" |
Author
There was a problem hiding this comment.
Lines 21-62 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-33
to
+35
| LOGS.info(f"⏳ STARTING DOGE USERBOT 🐾") | ||
| LOGS.info("⏳ STARTING DOGE USERBOT 🐾") | ||
| doge.loop.run_until_complete(setup_bot()) | ||
| LOGS.info(f"✅ STARTUP COMPLETED 🐾") | ||
| LOGS.info("✅ STARTUP COMPLETED 🐾") |
Author
There was a problem hiding this comment.
Lines 33-35 refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
| return await edl(event, "`🔲 Butonda hangi metni kullanmalıyım?`") | ||
|
|
||
| doginput = "Inline buttons " + markdown_note | ||
| doginput = f"Inline buttons {markdown_note}" |
Author
There was a problem hiding this comment.
Function button refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-26
to
+28
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| else: | ||
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." |
Author
There was a problem hiding this comment.
Function on_plug_in_callback_query_handler refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-78
to
80
| return await edl( | ||
| event, f"**📺 Geçerli bir YouTube URL'sine girin veya cevap verin!**" | ||
| event, "**📺 Geçerli bir YouTube URL'sine girin veya cevap verin!**" | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function yt_inline refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-273
to
+274
| await c_q.answer(f"➡️ Görünüm olarak şu değiştirildi: 📜 Liste", alert=False) | ||
| await c_q.answer("➡️ Görünüm olarak şu değiştirildi: 📜 Liste", alert=False) |
Author
There was a problem hiding this comment.
Function ytdl_callback refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-36
to
+38
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| else: | ||
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." |
Author
There was a problem hiding this comment.
Function on_plug_in_callback_query_handler refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-30
to
+42
| if reply_message.media: | ||
| media = await reply_message.download_media() | ||
| if reply_message.text: | ||
| await doge.tgbot.send_file(chat, media, caption=reply_message.text) | ||
| else: | ||
| await doge.tgbot.send_file(chat, media) | ||
| return await event.delete() | ||
|
|
||
| else: | ||
| if not reply_message.media: | ||
| return await edl( | ||
| event, | ||
| "__Bot üzerinden ne göndermeliyim? Bana bir metin verin ya da mesajı yanıtlayın.__", | ||
| ) | ||
|
|
||
| media = await reply_message.download_media() | ||
| if reply_message.text: | ||
| await doge.tgbot.send_file(chat, media, caption=reply_message.text) | ||
| else: | ||
| await doge.tgbot.send_file(chat, media) | ||
| return await event.delete() | ||
|
|
Author
There was a problem hiding this comment.
Function botmsg refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-36
to
+38
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| else: | ||
| reply_pop_up_alert = f"🚨 Bu mesaj artık Doge sunucusunda yok." | ||
| reply_pop_up_alert = "🚨 Bu mesaj artık Doge sunucusunda yok." |
Author
There was a problem hiding this comment.
Function on_plug_in_callback_query_handler refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-212
to
+215
| text = "**🐶 Doɢᴇ UsᴇʀBoᴛ Hᴀᴛᴀ Rᴀᴘᴏʀᴜ 🐾**" | ||
| text += "\n\n" | ||
| text = "**🐶 Doɢᴇ UsᴇʀBoᴛ Hᴀᴛᴀ Rᴀᴘᴏʀᴜ 🐾**" + "\n\n" | ||
| text += f"**🚨 Hata Raporu:** [{new['error']}]({pastelink})" | ||
| text += "\n\n" | ||
| link = f"[BURAYA](https://t.me/DogeSup)" | ||
| link = "[BURAYA](https://t.me/DogeSup)" |
Author
There was a problem hiding this comment.
Function DogeUserBotClient.bot_cmd.decorator.wrapper refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-352
to
+354
| text = "**🐶 Doɢᴇ Asɪsᴛᴀɴ Hᴀᴛᴀ Rᴀᴘᴏʀᴜ 🐾**" | ||
| text += "\n\n" | ||
| text = "**🐶 Doɢᴇ Asɪsᴛᴀɴ Hᴀᴛᴀ Rᴀᴘᴏʀᴜ 🐾**" + "\n\n" | ||
| text += f"**🚨 Hata Raporu:** [{new['error']}]({pastelink})" | ||
| text += "\n\n" | ||
| link = f"[BURAYA](https://t.me/DogeSup)" | ||
| link = "[BURAYA](https://t.me/DogeSup)" |
Author
There was a problem hiding this comment.
Function DogeUserBotClient.shiba_cmd.decorator.wrapper refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
|
|
||
| if "f" in about: | ||
| tmp_chelp += f"\n\n**🐾 Aʏᴀʀ:**" | ||
| tmp_chelp += "\\n\\n**🐾 Aʏᴀʀ:**" |
Author
There was a problem hiding this comment.
Function _format_about refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-797
to
+795
| exact_size = ( | ||
| ",isz:ex,iszw:" + str(size_array[0]) + ",iszh:" + str(size_array[1]) | ||
| ) | ||
| exact_size = f",isz:ex,iszw:{str(size_array[0])},iszh:{str(size_array[1])}" |
Author
There was a problem hiding this comment.
Function googleimagesdownload.build_url_parameters refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace calls to
dict.itemswithdict.valueswhen the keys are not used. (replace-dict-items-with-values)
Comment on lines
-977
to
+978
| for line in f: | ||
| if line not in ["\n", "\r\n"]: | ||
| search_keyword.append(line.replace("\n", "").replace("\r", "")) | ||
| search_keyword.extend( | ||
| line.replace("\n", "").replace("\r", "") | ||
| for line in f | ||
| if line not in ["\n", "\r\n"] | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function googleimagesdownload.keywords_from_file refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
Comment on lines
990
to
989
| dir_name_thumbnail = dir_name + " - thumbnail" | ||
| dir_name_thumbnail = f'{dir_name} - thumbnail' |
Author
There was a problem hiding this comment.
Function googleimagesdownload.create_directories refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-1028
to
+1027
| print("Image URL: " + image_url) | ||
| print(f"Image URL: {image_url}") |
Author
There was a problem hiding this comment.
Function googleimagesdownload.download_image_thumbnail refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Replace if statement with if expression (
assign-if-exp) - Use
withwhen opening file to ensure closure (ensure-file-closed)
Comment on lines
-1459
to
+1451
| arguments = {} | ||
| for i in args_list: | ||
| arguments[i] = None | ||
| arguments = {i: None for i in args_list} |
Author
There was a problem hiding this comment.
Function googleimagesdownload.download refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension)
| first_name = replied_user.user.first_name | ||
| username = replied_user.user.username | ||
| if username: | ||
| if username := replied_user.user.username: |
Author
There was a problem hiding this comment.
Function slap refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| def nsfw(category): | ||
| category.sort(key=str.casefold) | ||
| horny = f"**Kategori:** " | ||
| horny = "**Kategori:** " |
Author
There was a problem hiding this comment.
Function nsfw refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
userbot/helpers/progress.py
Outdated
| size /= power | ||
| raised_to_pow += 1 | ||
| return str(round(size, 2)) + " " + dict_power_n[raised_to_pow] + "B" | ||
| return f'{str(round(size, 2))} {dict_power_n[raised_to_pow]}B' |
Author
There was a problem hiding this comment.
Function humanbytes refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-68
to
+73
| ((str(days) + f" gün, ") if days else "") | ||
| + ((str(hours) + f" saat, ") if hours else "") | ||
| + ((str(minutes) + f" dakika, ") if minutes else "") | ||
| + ((str(seconds) + f" saniye, ") if seconds else "") | ||
| (f"{str(days)} gün, " if days else "") | ||
| + (f"{str(hours)} saat, " if hours else "") | ||
| + (f"{str(minutes)} dakika, " if minutes else "") | ||
| + (f"{str(seconds)} saniye, " if seconds else "") | ||
| ) | ||
|
|
Author
There was a problem hiding this comment.
Function time_formatter refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
userbot/helpers/progress.py
Outdated
Comment on lines
81
to
84
| ((str(int(days)) + f" gün, ") if days else "") | ||
| + ((str(int(hours)) + ":") if hours else "00:") | ||
| + ((str(int(minutes)) + ":") if minutes else "00:") | ||
| (f"{int(days)} gün, " if days else "") | ||
| + (f'{int(hours)}:' if hours else "00:") | ||
| + (f'{int(minutes)}:' if minutes else "00:") |
Author
There was a problem hiding this comment.
Function readable_time refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Remove unnecessary calls to
str()from formatted values in f-strings (remove-str-from-fstring)
| bottomTextPosition = (bottomTextPositionX, bottomTextPositionY) | ||
| draw = Draw(img) | ||
| outlineRange = int(fontSize / 15) | ||
| outlineRange = fontSize // 15 |
Author
There was a problem hiding this comment.
Function dogememify_helper refactored with the following changes:
- Simplify division expressions. (
simplify-division)
userbot/helpers/functions/jikan.py
Outdated
Comment on lines
226
to
228
| msg += f"\n**Genres:** " | ||
| msg += "\\n**Genres:** " | ||
| for g in jsonData["genres"]: | ||
| msg += g + " " | ||
| msg += f'{g} ' |
Author
There was a problem hiding this comment.
Function formatJSON refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| msg = "" | ||
| if len(description) > 700: | ||
| description = description[0:200] + "....." | ||
| description = description[:200] + "....." |
Author
There was a problem hiding this comment.
Function shorten refactored with the following changes:
- Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
| result = post(anilisturl, json={"query": user_query, "variables": username}).json() | ||
| error = result.get("errors") | ||
| if error: | ||
| if error := result.get("errors"): |
Author
There was a problem hiding this comment.
Function anilist_user refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
userbot/helpers/functions/jikan.py
Outdated
Comment on lines
330
to
331
| image = post("https://graphql.anilist.co", json=data).json()["data"]["Media"][ | ||
| "bannerImage" | ||
| ] | ||
| if image: | ||
| if image := post("https://graphql.anilist.co", json=data).json()["data"][ | ||
| "Media" | ||
| ]["bannerImage"]: |
Author
There was a problem hiding this comment.
Function getBannerLink refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Signed-off-by: TeleDoge <DogeUserBot@gmail.com>
Author
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.17%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Author
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.15%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
DOGErefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
DOGEbranch, then run:Help us improve this pull request!