Skip to content

Conversation

@ulemons
Copy link
Contributor

@ulemons ulemons commented Nov 6, 2025

What

Updated the activity/query pipe to correctly handle the countOnly flag and to make the segments parameter robust when empty or undefined.

Why

Previously, the pipe always returned rows even when countOnly=1, leading to unnecessary data load.
Also, queries with empty segments could fail or return inconsistent results.

How

  • Added conditional logic to return only count() when countOnly=1.
  • Normalized segments to avoid errors when the parameter is empty or missing.
  • Preserved all existing filters and G1–G5 logic.

@ulemons ulemons requested a review from epipav November 6, 2025 14:57
@ulemons ulemons self-assigned this Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@ulemons ulemons merged commit 310c5e1 into main Nov 11, 2025
13 checks passed
@ulemons ulemons deleted the fix/tinybird-activity-query-count-logic branch November 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants