Skip to content

Update CblReactNativeEngine.tsx to impl ICore interface #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CblReactNativeEngine.tsx to impl ICore interface #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/CblReactNativeEngine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
ScopeArgs,
ScopesResult,
DocumentGetBlobContentArgs,
URLEndpointListenerArgs,
URLEndpointListenerCreateArgs,
URLEndpointListenerStatus,
URLEndpointListenerTLSIdentityArgs,
} from './cblite-js/cblite/core-types';

import { EngineLocator } from './cblite-js/cblite/src/engine-locator';
Expand Down Expand Up @@ -112,6 +116,21 @@

this._eventEmitter = new NativeEventEmitter(this.CblReactNative);
}
URLEndpointListener_createListener(args: URLEndpointListenerCreateArgs): Promise<{ listenerId: string; }> {

Check failure on line 119 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

'args' is defined but never used

Check failure on line 119 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `args:·URLEndpointListenerCreateArgs):·Promise<{·listenerId:·string;` with `⏎····args:·URLEndpointListenerCreateArgs⏎··):·Promise<{·listenerId:·string`
throw new Error('Method not implemented.');
}
URLEndpointListener_startListener(args: URLEndpointListenerArgs): Promise<void> {

Check failure on line 122 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

'args' is defined but never used

Check failure on line 122 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `args:·URLEndpointListenerArgs` with `⏎····args:·URLEndpointListenerArgs⏎··`
throw new Error('Method not implemented.');
}
URLEndpointListener_stopListener(args: URLEndpointListenerArgs): Promise<void> {

Check failure on line 125 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

'args' is defined but never used

Check failure on line 125 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `args:·URLEndpointListenerArgs` with `⏎····args:·URLEndpointListenerArgs⏎··`
throw new Error('Method not implemented.');
}
URLEndpointListener_getStatus(args: URLEndpointListenerArgs): Promise<URLEndpointListenerStatus> {

Check failure on line 128 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

'args' is defined but never used

Check failure on line 128 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `args:·URLEndpointListenerArgs` with `⏎····args:·URLEndpointListenerArgs⏎··`
throw new Error('Method not implemented.');
}
URLEndpointListener_deleteIdentity(args: URLEndpointListenerTLSIdentityArgs): Promise<void> {

Check failure on line 131 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

'args' is defined but never used

Check failure on line 131 in src/CblReactNativeEngine.tsx

View workflow job for this annotation

GitHub Actions / lint 

Replace `args:·URLEndpointListenerTLSIdentityArgs` with `⏎····args:·URLEndpointListenerTLSIdentityArgs⏎··`
throw new Error('Method not implemented.');
}
Comment on lines +119 to +133
Copy link

@gemini-code-assist gemini-code-assist bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding these stub methods correctly implements the ICoreEngine interface and fixes the build, the generic error message 'Method not implemented.' can be difficult to debug. It's better to provide a more specific error message for each method to clearly indicate which function was called but is not implemented. This will help developers who might try to use this functionality in the future.

Suggested change
URLEndpointListener_createListener(args: URLEndpointListenerCreateArgs): Promise<{ listenerId: string; }> {
throw new Error('Method not implemented.');
}
URLEndpointListener_startListener(args: URLEndpointListenerArgs): Promise<void> {
throw new Error('Method not implemented.');
}
URLEndpointListener_stopListener(args: URLEndpointListenerArgs): Promise<void> {
throw new Error('Method not implemented.');
}
URLEndpointListener_getStatus(args: URLEndpointListenerArgs): Promise<URLEndpointListenerStatus> {
throw new Error('Method not implemented.');
}
URLEndpointListener_deleteIdentity(args: URLEndpointListenerTLSIdentityArgs): Promise<void> {
throw new Error('Method not implemented.');
}
URLEndpointListener_createListener(args: URLEndpointListenerCreateArgs): Promise<{ listenerId: string; }> {
throw new Error('URLEndpointListener_createListener not implemented.');
}
URLEndpointListener_startListener(args: URLEndpointListenerArgs): Promise<void> {
throw new Error('URLEndpointListener_startListener not implemented.');
}
URLEndpointListener_stopListener(args: URLEndpointListenerArgs): Promise<void> {
throw new Error('URLEndpointListener_stopListener not implemented.');
}
URLEndpointListener_getStatus(args: URLEndpointListenerArgs): Promise<URLEndpointListenerStatus> {
throw new Error('URLEndpointListener_getStatus not implemented.');
}
URLEndpointListener_deleteIdentity(args: URLEndpointListenerTLSIdentityArgs): Promise<void> {
throw new Error('URLEndpointListener_deleteIdentity not implemented.');
}


//private logging function
private debugLog(message: string) {
Expand Down
Loading