Initial setup for golang tests

.github/workflows/go-lint.yml → .github/workflows/go.yaml

@@ -1,4 +1,4 @@
-name: Golang Linting
+name: Golang Validation
 
 on:
   push:
@@ -29,3 +29,10 @@ jobs:
       - name: Check Format
         run: |
           gofmt -s -l database logging sse *.go
+      - name: Run Tests
+        run: |
+          go test ./database
+      - name: Run vet
+        run: |
+          go vet ./database/ ./logging/ ./sse/
+          go vet *.go

Dockerfile

@@ -2,6 +2,7 @@ FROM docker.io/golang:1.24-alpine AS build
 
 WORKDIR /src/
 RUN apk add git
+COPY go.* .
 RUN go mod download # do this before build for caching
 COPY database database
 COPY logging logging

README.md

@@ -42,6 +42,13 @@ go mod tidy
 
 # format all code according to go standards
 gofmt -w -s *.go logging sse database
+
+# run tests (database is the first place we've defined tests)
+go test ./database
+
+# run heuristic validation
+go vet ./database/ ./logging/ ./sse/
+go vet *.go
 ```
 
 ## To-Dos

database/database.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"os"
 	"strings"
+	"testing"
 	"time"
 
 	"github.com/computersciencehouse/vote/logging"
@@ -20,10 +21,16 @@ const (
 	Updated UpsertResult = 1
 )
 
-var Client = Connect()
+var Client *mongo.Client = Connect()
 var db = ""
 
 func Connect() *mongo.Client {
+	// This always gets invoked on initialisation. bad! it'd be nice if we only did this setup in main rather than components under test. for now we just skip if testing
+	if testing.Testing() {
+		logging.Logger.WithFields(logrus.Fields{"module": "database", "method": "Connect"}).Info("testing, not doing db connection, someone should mock this someday")
+		return nil
+	}
+
 	logging.Logger.WithFields(logrus.Fields{"module": "database", "method": "Connect"}).Info("beginning database connection")
 
 	ctx, cancel := context.WithTimeout(context.TODO(), 10*time.Second)