feat: support open 3d viewer in media asset panel #6703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
🎭 Playwright Test Results⏰ Completed at: 11/14/2025, 02:06:40 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/14/2025, 01:55:38 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 2.98 MB (baseline 2.93 MB) • 🔴 +59.3 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 803 kB (baseline 803 kB) • 🔴 +69 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.03 kB (baseline 8 kB) • 🔴 +37 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 307 kB (baseline 306 kB) • 🔴 +222 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 210 kB (baseline 266 kB) • 🟢 -56.5 kBReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.6 kB (baseline 12.6 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 5.87 kB (baseline 5.87 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 3 added / 3 removed Other — 3.92 MB (baseline 3.92 MB) • 🔴 +518 BBundles that do not match a named category
Status: 15 added / 15 removed |
DrJKL
reviewed
Nov 14, 2025
Comment on lines
+315
to
+316
| console.error('Error initializing standalone 3D viewer:', error) | ||
| useToastStore().addAlert('Failed to load 3D model') |
Contributor
There was a problem hiding this comment.
Question: There's a lot of state set in the try, would any of it need to be reset if there's an issue?
Contributor
There was a problem hiding this comment.
Or could the try/catch be scoped more tightly?
DrJKL
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for previewing 3D assets directly in the Media Asset Panel.
Changes
.glb,.gltf, etc.) in the Media Asset Panel now opens the full3D viewer
Screenshots
2025-11-14.08-47-46.mp4
┆Issue is synchronized with this Notion page by Unito