Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Nov 13, 2025

Summary

Backports PR #6381 (UI color updates & tweaks) to core/1.30 branch.

This includes:

  • Text readability improvements
  • Semantic color token consistency updates
  • UI element styling refinements
  • Component import path fixes (ComfyLogoTransparent → ComfyLogo)

Merge Conflicts Resolved

  • ComfyMenuButton.vue: Accepted cherry-picked version with import changes
  • 20 browser test snapshots: Used backportee's copy as instructed

Original commit: fd236b3

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 13, 2025
This commit applies improvements for text readability, consistency, and semantic color token usage. Includes updates to node components, UI elements, and browser test snapshots.

Backported from: fd236b3
@christian-byrne christian-byrne force-pushed the backport-ui-color-updates-6381 branch from ff95f1a to d44ac4d Compare November 13, 2025 18:39
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 11/14/2025, 02:24:57 AM UTC

📈 Summary

  • Total Tests: 477
  • Passed: 422 ✅
  • Failed: 20 ❌
  • Flaky: 5 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 417 / ❌ 18 / ⚠️ 5 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 2 / ❌ 2 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Nov 13, 2025
- Remove unused useWorkflowTemplateSelectorDialog import
- Fix TypeScript errors in eslint.config.ts
- Auto-fix Tailwind CSS class ordering and shorthand issues
- Resolve conflicting classes in PackCard component

Ensures CI can start properly without build errors.
This file was deleted in core/1.30 but kept during backport conflict resolution.
Removing it now as it's not referenced anywhere in the codebase.
christian-byrne and others added 4 commits November 13, 2025 14:40
This plugin has been removed from main branch and was causing
TypeScript compilation errors in CI. Removing import and related
configuration to match current state.
Remove both the plugin and its type definitions from package.json
since the plugin has been removed from the ESLint configuration.
Synchronize pnpm-lock.yaml with package.json changes that removed
the eslint-plugin-tailwindcss and its type definitions.
@github-actions
Copy link

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

Update test expectations to match the Tailwind CSS shorthand classes
that were applied by ESLint auto-fix during the backport process.
@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 14, 2025
@github-actions
Copy link

Updating Playwright Expectations

@christian-byrne
Copy link
Contributor Author

these failing tests are all vue node changes upstream, safe to regenerate

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 14, 2025
@christian-byrne christian-byrne changed the title Backport PR #6381 to core/1.30: UI color updates & tweaks [backport core/1.30]: UI color updates & tweaks Nov 14, 2025
@christian-byrne christian-byrne merged commit bf24b6e into core/1.30 Nov 14, 2025
2 checks passed
@christian-byrne christian-byrne deleted the backport-ui-color-updates-6381 branch November 14, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants