-
Notifications
You must be signed in to change notification settings - Fork 12
feat: v-next #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: v-next #42
Conversation
|
Is there still interest in this? Would you like other people to test at this stage? |
Yes! It got put on the back burner for a bit, but should be in a good place now Please feel free to test it, any feedback or suggestions are more than welcome. It’s still missing the v3 endpoints and a migration to TypeScript for improved IntelliSense but it's good enough for an initial release. |
|
I'm unable to test it because package.json has: So the repo gets fetched without src. |
These changes are not built or released yet. To test you would need to clone the branch, run |
|
Hi, first attempt at using it: I tried to: this.version is undefined here: Even after adding |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: publish to npm | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| NPM_CONFIG_PROVENANCE: true | ||
| run: | | ||
| pnpm publish \ | ||
| --access=public \ |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
To resolve the issue, add a permissions block to the workflow configuration to restrict the GITHUB_TOKEN to the least necessary privileges. The best location is at the root of the workflow (under the workflow name or triggers) if you want to define permissions for all jobs, or within each job's config if you need more granularity.
For this workflow, a minimal permissions block such as contents: read will almost always suffice for publishing to npm (actual publishing is authenticated via the NODE_AUTH_TOKEN), though if you use npm provenance you may also want id-token: write. To strictly follow the principle of least privilege for the visible steps, add the following at the top level just after the workflow name and before the on: trigger:
permissions:
contents: readEdit .github/workflows/publish.yml to insert this block after name: Publish. No new packages or external imports are required.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Publish | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| release: |
|
Ha, not a great start. It seems the route file got overridden at some point, I have fixed that and added tests to ensure it won't regress. The token issue should be resolved as well. I also improved the error format to help debug any future errors. |
This PR introduces the next major version of this package.
TODO
Routeclass