simplify debugResponse logic (#38)

Author: TavoNiievez

src/Codeception/Module/Symfony.php

@@ -624,38 +624,38 @@ protected function debugResponse($url)
     {
         parent::debugResponse($url);
 
-        if ($profile = $this->getProfile()) {
-            if ($profile->hasCollector('security')) {
-                if ($profile->getCollector('security')->isAuthenticated()) {
-                    $roles = $profile->getCollector('security')->getRoles();
-
-                    if ($roles instanceof Data) {
-                        $roles = $this->extractRawRoles($roles);
-                    }
-
-                    $this->debugSection(
-                        'User',
-                        $profile->getCollector('security')->getUser()
-                        . ' [' . implode(',', $roles) . ']'
-                    );
-                } else {
-                    $this->debugSection('User', 'Anonymous');
-                }
-            }
-            if ($profile->hasCollector('swiftmailer')) {
-                $messages = $profile->getCollector('swiftmailer')->getMessageCount();
-                if ($messages) {
-                    $this->debugSection('Emails', $messages . ' sent');
-                }
-            } elseif ($profile->hasCollector('mailer')) {
-                $messages = count($profile->getCollector('mailer')->getEvents()->getMessages());
-                if ($messages) {
-                    $this->debugSection('Emails', $messages . ' sent');
+        if (!$profile = $this->getProfile()) {
+            return;
+        }
+
+        if ($profile->hasCollector('security')) {
+            $security = $profile->getCollector('security');
+            if ($security->isAuthenticated()) {
+                $roles = $security->getRoles();
+
+                if ($roles instanceof Data) {
+                    $roles = $this->extractRawRoles($roles);
                 }
+
+                $this->debugSection(
+                    'User',
+                    $security->getUser()
+                    . ' [' . implode(',', $roles) . ']'
+                );
+            } else {
+                $this->debugSection('User', 'Anonymous');
             }
-            if ($profile->hasCollector('timer')) {
-                $this->debugSection('Time', $profile->getCollector('timer')->getTime());
-            }
+        }
+        if ($profile->hasCollector('swiftmailer')) {
+            $emails = $profile->getCollector('swiftmailer')->getMessageCount();
+        } elseif ($profile->hasCollector('mailer')) {
+            $emails = count($profile->getCollector('mailer')->getEvents()->getMessages());
+        }
+        if (isset($emails)) {
+            $this->debugSection('Emails', $emails . ' sent');
+        }
+        if ($profile->hasCollector('timer')) {
+            $this->debugSection('Time', $profile->getCollector('timer')->getTime());
         }
     }