removed extra return statements (#37)

TavoNiievez · web-flow · commit adb0d9e04753 · 2020-11-13T23:12:19.000+02:00
diff --git a/src/Codeception/Module/Symfony.php b/src/Codeception/Module/Symfony.php
@@ -812,7 +812,6 @@ public function logout()
 
         if (!$container->has('session')) {
             $this->fail("Symfony container doesn't have 'session' service");
-            return;
         }
         $session = $this->grabService('session');
 
@@ -851,7 +850,6 @@ public function seeInSession($attrib, $value = null)
 
         if (!$container->has('session')) {
             $this->fail("Symfony container doesn't have 'session' service");
-            return;
         }
 
         $session = $this->grabService('session');
@@ -884,7 +882,6 @@ public function amOnAction($action, $params = [])
 
         if (!$container->has('router')) {
             $this->fail("Symfony container doesn't have 'router' service");
-            return;
         }
 
         $router = $this->grabService('router');
@@ -924,7 +921,6 @@ public function seeAuthentication($remembered = false)
 
         if (!$container->has('security.helper')) {
             $this->fail("Symfony container doesn't have 'security.helper' service");
-            return;
         }
 
         $security = $this->grabService('security.helper');
@@ -933,7 +929,6 @@ public function seeAuthentication($remembered = false)
 
         if (!$user) {
             $this->fail('There is no user in session');
-            return;
         }
 
         if ($remembered) {
@@ -961,7 +956,6 @@ public function seeUserHasRole($role)
 
         if (!$container->has('security.helper')) {
             $this->fail("Symfony container doesn't have 'security.helper' service");
-            return;
         }
 
         $security = $this->grabService('security.helper');
@@ -970,7 +964,6 @@ public function seeUserHasRole($role)
 
         if (!$user) {
             $this->fail('There is no user in session');
-            return;
         }
 
         $this->assertTrue(
@@ -1000,7 +993,6 @@ public function dontSeeAuthentication($remembered = true)
 
         if (!$container->has('security.helper')) {
             $this->fail("Symfony container doesn't have 'security.helper' service");
-            return;
         }
 
         $security = $this->grabService('security.helper');
@@ -1034,7 +1026,6 @@ public function seeCurrentActionIs($action)
 
         if (!$container->has('router')) {
             $this->fail("Symfony container doesn't have 'router' service");
-            return;
         }
 
         $router = $this->grabService('router');
@@ -1059,7 +1050,6 @@ public function amLoggedInAs(UserInterface $user, $firewallName = 'main', $firew
         $container = $this->_getContainer();
         if (!$container->has('session')) {
             $this->fail("Symfony container doesn't have 'session' service");
-            return;
         }
 
         $session = $this->grabService('session');

Original file line number	Diff line number	Diff line change
`@@ -812,7 +812,6 @@ public function logout()`
`812`	`812`
`813`	`813`	`if (!$container->has('session')) {`
`814`	`814`	`$this->fail("Symfony container doesn't have 'session' service");`
`815`		`- return;`
`816`	`815`	`}`
`817`	`816`	`$session = $this->grabService('session');`
`818`	`817`
`@@ -851,7 +850,6 @@ public function seeInSession($attrib, $value = null)`
`851`	`850`
`852`	`851`	`if (!$container->has('session')) {`
`853`	`852`	`$this->fail("Symfony container doesn't have 'session' service");`
`854`		`- return;`
`855`	`853`	`}`
`856`	`854`
`857`	`855`	`$session = $this->grabService('session');`
`@@ -884,7 +882,6 @@ public function amOnAction($action, $params = [])`
`884`	`882`
`885`	`883`	`if (!$container->has('router')) {`
`886`	`884`	`$this->fail("Symfony container doesn't have 'router' service");`
`887`		`- return;`
`888`	`885`	`}`
`889`	`886`
`890`	`887`	`$router = $this->grabService('router');`
`@@ -924,7 +921,6 @@ public function seeAuthentication($remembered = false)`
`924`	`921`
`925`	`922`	`if (!$container->has('security.helper')) {`
`926`	`923`	`$this->fail("Symfony container doesn't have 'security.helper' service");`
`927`		`- return;`
`928`	`924`	`}`
`929`	`925`
`930`	`926`	`$security = $this->grabService('security.helper');`
`@@ -933,7 +929,6 @@ public function seeAuthentication($remembered = false)`
`933`	`929`
`934`	`930`	`if (!$user) {`
`935`	`931`	`$this->fail('There is no user in session');`
`936`		`- return;`
`937`	`932`	`}`
`938`	`933`
`939`	`934`	`if ($remembered) {`
`@@ -961,7 +956,6 @@ public function seeUserHasRole($role)`
`961`	`956`
`962`	`957`	`if (!$container->has('security.helper')) {`
`963`	`958`	`$this->fail("Symfony container doesn't have 'security.helper' service");`
`964`		`- return;`
`965`	`959`	`}`
`966`	`960`
`967`	`961`	`$security = $this->grabService('security.helper');`
`@@ -970,7 +964,6 @@ public function seeUserHasRole($role)`
`970`	`964`
`971`	`965`	`if (!$user) {`
`972`	`966`	`$this->fail('There is no user in session');`
`973`		`- return;`
`974`	`967`	`}`
`975`	`968`
`976`	`969`	`$this->assertTrue(`
`@@ -1000,7 +993,6 @@ public function dontSeeAuthentication($remembered = true)`
`1000`	`993`
`1001`	`994`	`if (!$container->has('security.helper')) {`
`1002`	`995`	`$this->fail("Symfony container doesn't have 'security.helper' service");`
`1003`		`- return;`
`1004`	`996`	`}`
`1005`	`997`
`1006`	`998`	`$security = $this->grabService('security.helper');`
`@@ -1034,7 +1026,6 @@ public function seeCurrentActionIs($action)`
`1034`	`1026`
`1035`	`1027`	`if (!$container->has('router')) {`
`1036`	`1028`	`$this->fail("Symfony container doesn't have 'router' service");`
`1037`		`- return;`
`1038`	`1029`	`}`
`1039`	`1030`
`1040`	`1031`	`$router = $this->grabService('router');`
`@@ -1059,7 +1050,6 @@ public function amLoggedInAs(UserInterface $user, $firewallName = 'main', $firew`
`1059`	`1050`	`$container = $this->_getContainer();`
`1060`	`1051`	`if (!$container->has('session')) {`
`1061`	`1052`	`$this->fail("Symfony container doesn't have 'session' service");`
`1062`		`- return;`
`1063`	`1053`	`}`
`1064`	`1054`
`1065`	`1055`	`$session = $this->grabService('session');`