-
-
Notifications
You must be signed in to change notification settings - Fork 118
Remove emoji from menu maps #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
But keep the card sizes constant for now. We may change this in the future, but at the moment this keeps things consistent and tidy. Definitely looks a little empty, though.
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LonMcGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm all for removing emoji, especially when they look different on different systems and might require knowing cultural context to fully understand them.
Questions:
- I am conscious that coloured icons can make it easier for people to quickly find familiar locations. Is there a plan to check with trainees whether they find the removal of icons a hindrance?
- Are you still keeping the other decoration emoji? E.g. the 👉 📍 on the grid overview,
▶️ in expandables, and the 🔖 for the table of contents? - What about page sections / headings, like 🔌 on this page: https://deploy-preview-1658--cyf-curriculum.netlify.app/guides/deploying/supabase/ and on day plans?

But keep the card sizes constant for now.
We may change this in the future, but at the moment this keeps things consistent and tidy. Definitely looks a little empty, though.