Skip to content

London | 25-ITP-Sep | Payman Issa Baiglu | sprint 3 | 2-practice-tdd #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-Sep | Payman Issa Baiglu | sprint 3 | 2-practice-tdd #883

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
92afa66
Implement countChar function and add test for non-existent character
Nov 15, 2025
9e894a7
Refactor getOrdinalNumber function and expand test cases for ordinal …
Nov 15, 2025
ded405e
Implement repeat function with error handling for negative counts and…
Nov 15, 2025
a124398
Refactor getOrdinalNumber function to improve variable naming and rem…
Nov 22, 2025
e7d7fff
Update getCardValue function to check for specific card representatio…
Nov 22, 2025
fbacf4a
reverted to original
Nov 22, 2025
3585be7
Fix repeat function to throw an error for negative counts instead of …
Nov 22, 2025
bbc996c
Refactor repeat function to correctly handle string repetition and ma…
Nov 23, 2025
5ee3f6b
Update negative count test to ensure it throws an error instead of re…
Nov 23, 2025
354b5ac
Refactor getOrdinalNumber function for clarity and improve test cases…
Nov 23, 2025
fdc1b1a
Fix test case description for numbers ending in 1 and remove redundan…
Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const getOrdinalNumber = require("./get-ordinal-number");
// When the number is 1,
// Then the function should return "1st"

test("append 'nd' to numbers ending in 1, except those ending in 11", () => {
test("append 'st' to numbers ending in 1, except those ending in 11", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
expect( getOrdinalNumber(21) ).toEqual("21st");
expect( getOrdinalNumber(131) ).toEqual("131st");
Expand All @@ -24,16 +24,8 @@ test("append 'rd' to numbers ending in 3, except those ending in 13", () => {
expect( getOrdinalNumber(33) ).toEqual("33rd");
expect( getOrdinalNumber(133) ).toEqual("133rd");
});
test("append 'th' to numbers ending in 4", () => {
expect(getOrdinalNumber(4)).toEqual("4th");
expect( getOrdinalNumber(24) ).toEqual("24th");
expect( getOrdinalNumber(134) ).toEqual("134th");
});
test("should return '11th' for 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
});
test("append 'th' to numbers which are not ending in 1, 2, 3", () => {
expect(getOrdinalNumber(5)).toEqual("5th");
expect( getOrdinalNumber(29) ).toEqual("29th");
expect( getOrdinalNumber(24) ).toEqual("24th");
expect( getOrdinalNumber(138) ).toEqual("138th");
});
Copy link
Contributor

@cjyuan cjyuan Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the test categories now cover all numbers, but within this category, the samples being used are not very comprehensive. Can you think of what numbers you could have also tested?