Skip to content

Manchester | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Manchester | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite #879

wants to merge 10 commits into from
+4,523 −18

Conversation

@khalidbih
Copy link

@khalidbih khalidbih commented Nov 14, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist:

I have completed the coursework/sprint-3-implement-and-rewrite.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@khalidbih khalidbih changed the title Coursework/sprint 3 Manchester | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@khalidbih khalidbih added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@khalidbih khalidbih changed the title Manchester | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite NW | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@khalidbih khalidbih changed the title NW | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite Manchester | 25-ITP-Sep | Khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite Nov 14, 2025
cjyuan
cjyuan reviewed Nov 15, 2025
View reviewed changes
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Copy link
Contributor

@cjyuan cjyuan Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can your function pass all the tests in this script?

Copy link
Author

@khalidbih khalidbih Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because it will fail the negative fraction test (Case 3).
I run the code, this is the output: FAIL ../1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
✓ should return true for a proper fraction (4 ms)
✓ should return false for Improper fraction (4 ms)
✕ should return false for Negative fraction (2 ms)
✓ should return false for Equal numerator and denominator (1 ms)

Copy link
Contributor

@cjyuan cjyuan Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test fails. So how would you fix the issue?

Copy link
Author

@khalidbih khalidbih Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the test so that negative fractions are handled correctly, and after running the tests with Jest, everything passed.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025
@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2025
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2025
@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 17, 2025
cjyuan
cjyuan reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Comment on lines +15 to +17
test("should return true for Negative fraction", () => {
expect(isProperFraction(-4, 7)).toEqual(true);
});
Copy link
Contributor

@cjyuan cjyuan Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description is still not quite correct.

Copy link
Author

@khalidbih khalidbih Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I’ll make sure to write clearer test descriptions next time and pay more attention.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 18, 2025
@khalidbih
Copy link
Author

khalidbih commented Nov 18, 2025

Changes look good.

Thank you so much. I also appreciate your guidance and feedback.

@khalidbih khalidbih mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khalidbih @cjyuan