Sheffield | 25-ITP-SEP | Declan Williams | Sprint 2 | Coursework #877
Conversation
…on error so that new code will work correctly and not throw the old error
…r and update console log example
…cted error missing )
…e last digit of input numbers
… to fix the convert to percentage function works correctly
…g it and updated comments
… comments for clarity
…format with example usage
updated comments for clarity on roundedBmi returning as a string.
refactored code to be indented properly. and updated name of function to align more correctly with the values of the variable stored.
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
CatchingKiyoko
added
📅 Sprint 2
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
CatchingKiyoko
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
| const roundedBmi = bmi.toFixed(1); // round the result to 1 decimal place and return as a string. | ||
| return roundedBmi; // return the string result of rounded BMI value | ||
| } |
There was a problem hiding this comment.
What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?
Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,
console.log(123); // Output 123
console.log("123"); // Output 123
// Treated differently in the program
let sum1 = 123 + 100; // Evaluate to 223 -- a number
let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.There was a problem hiding this comment.
i expect this to return a string but if i needed to convert it to a number i can use the "Number()" constructor to do so. (refactored to have a capital)
There was a problem hiding this comment.
number() is not quite correct but you are in the right direction.
| function toPounds(penceString){ | ||
| const penceStringWithoutTrailingP = penceString.substring(0, penceString.length -1); | ||
| const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0"); | ||
| const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2); | ||
| const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"); | ||
| return `£${pounds}.${pence}p`; | ||
| } |
There was a problem hiding this comment.
have resovled the indentation at the end of the function.
cjyuan
added
Reviewed
CatchingKiyoko
added
Needs Review
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist