Skip to content

Conversation

@Konvaly
Copy link

@Konvaly Konvaly commented Nov 11, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

This PR covers work in the Test-First Development section of the sprint project:

Test-First Approach:

Wrote Jest tests before implementing the functions, practicing the test-driven development (TDD) process.

Jest Tests: Created and completed test files for:

  • count.test.js
  • repeat-str.test.js
  • get-ordinal-number.test.js

Each test file follows the provided acceptance criteria and uses Jest’s syntax for clarity.

Functions were then implemented to make all tests pass.

All tests run successfully with the VS Code Test Runner or by using npm test.

@Konvaly Konvaly added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR branch is not clean; it contains changes unrelated to "Practice TDD" exercise.
Can you revert the changes made in Sprint-2 and Sprint-3/1-implement-and-rewrite-tests folders?

Note: Your other Sprint-3 PR branch, #832, is also not clean.

If you have difficulty reverting the changes, please seek assistance from a volunteer in an in-person workshop. Alternatively, you can create new branches (make sure they are created from your main branch), transfer your Sprint-3 exercise files to the new branches, and submit new PRs (and then close the old Sprint-3 PRs).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025
@Konvaly Konvaly force-pushed the coursework/sprint-3-practice-tdd branch from 9f50cbb to be4e103 Compare November 17, 2025 01:28
@Konvaly Konvaly closed this Nov 17, 2025
@Konvaly Konvaly force-pushed the coursework/sprint-3-practice-tdd branch from be4e103 to 92dc38c Compare November 17, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants