London | 25-ITP-SEP | Mariia Serhiienko|Sprint 3|Implement and rewrite #871
Conversation
…-get-angle-type.test.js
…-jest/2-is-proper-fraction.test.js
…-jest/3-get-card-value.test.js
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Konvaly
added
📅 Sprint 3
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 similar comments
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint 3) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Konvaly
changed the title
A-O-Emmanuel
added
Review in progress
|
Please check your pull request, it is not the expected format. |
A-O-Emmanuel
added
Reviewed
Konvaly
changed the title
Konvaly
changed the title
Konvaly
changed the title
Hi @A-O-Emmanuel ! Thank you for revieving my PR! |
Konvaly
added
Needs Review
|
You've made the changes and all checks have passed |
|
Hi @A-O-Emmanuel ! |
There was a problem hiding this comment.
Please write your explanation and the new code, follow the instructions.
There was a problem hiding this comment.
For this task Sprint-2/1-key-errors/0.js - there is no code because this task should be in Sprint-2 and I mistakenly created new branch not from "main" but from the branch Sprint-2. After that I reverted this action (so explanation and the new code are in the another PR, which is already reviewed).
There was a problem hiding this comment.
This meets the acceptance criteria.
There was a problem hiding this comment.
Please check the acceptance criteria very well, for what you need to do, the last two if statements do not align with their respective acceptance criteria
There was a problem hiding this comment.
I 've fixed if statements and rewritten test case "Both Numerator and Denominator Negative check"
A-O-Emmanuel
added
Reviewed
Konvaly
added
Needs Review
|
Hi @A-O-Emmanuel ! |
A-O-Emmanuel
added
Complete
2 participants
Self checklist
This PR covers work across the Implement and Rewrite Tests with Jest sections of the sprint project:
Implement:
Completed and tested functions in the implement folder :
1-get-angle-type.js,
2-is-proper-fraction.js,
3-get-card-value.js.
Each function was built up step by step with clear logic and verified using multiple cases.
Rewrite Tests with Jest:
Rewroted all original tests using Jest in the rewrite-tests-with-jest folder.
Each test mirrors the previous assertions but now uses Jest’s syntax for better readability and maintainability.
All functions work as expected, and the new Jest test suite runs successfully with npm test or the VS Code Test Explorer.