Skip to content

Manchester| 25-ITP-September | Fithi Teklom| Sprint 3 | 2-practice-tdd #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Manchester| 25-ITP-September | Fithi Teklom| Sprint 3 | 2-practice-tdd #863

wants to merge 18 commits into from
+118 −33

Conversation

@Fithi-Teklom
Copy link

@Fithi-Teklom Fithi-Teklom commented Nov 10, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@Fithi-Teklom Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Fithi-Teklom Fithi-Teklom changed the title Manchester| 25-ITP-September | Fithi Teklom| Sprint 3/2-practice-tdd Manchester| 25-ITP-September | Fithi Teklom| Sprint 3 | 2-practice-tdd Nov 10, 2025
cjyuan
cjyuan reviewed Nov 11, 2025
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025
@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 13, 2025
cjyuan
cjyuan reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test in get-oridinal-number.test.js could use some improvement.

All other changes look good.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 13, 2025
@Fithi-Teklom
Copy link
Author

Fithi-Teklom commented Nov 15, 2025

I have cleaned my branch.

@cjyuan
Copy link
Contributor

cjyuan commented Nov 15, 2025 •
edited
Loading

Branch is clean. Well done!

You placed Jest test script for getOridinalNumber() in Sprint-3/2-practice-tdd/get-ordinal-number.js instead of in Sprint-3/2-practice-tdd/get-ordinal-number.test.js. Can you move the test script to the .test.js file?

@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2025
cjyuan
cjyuan reviewed Nov 17, 2025
View reviewed changes
Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Copy link
Contributor

@cjyuan cjyuan Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried running this test script to make sure it can run properly?

Copy link
Author

@Fithi-Teklom Fithi-Teklom Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I have made sure that the tests have all passed.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 17, 2025
@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 17, 2025
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 17, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 17, 2025

Looks good.

This was referenced Nov 17, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fithi-Teklom @cjyuan