London | 25-ITP-September | Carlos Abreu | Sprint 2 | Coursework #860

carlosyabreu · 2025-11-08T13:00:44Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR is the commit I've done for Sprint 2 Coursework that needs to be merged into CYF main branch

Questions

// I commented this section instead deleting (Ask any questions you have for your reviewer).

…only for developers

…rameters and use Number function to convert into a Number

…y a function

github-actions · 2025-11-08T13:01:00Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:02:30Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:02:33Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:02:34Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:02:42Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:02:48Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

Code looks good.

Can you revert the changes made in the Sprint-1 folder to keep this branch clean?

cjyuan · 2025-11-08T13:31:35Z

Sprint-2/3-mandatory-implement/2-cases.js

+// Example usage:
+console.log(toUpperSnakeCase("hello there"));         // Output: "HELLO_THERE"
+console.log(toUpperSnakeCase("lord of the rings"));   // Output: "LORD_OF_THE_RINGS"
+console.log(toUpperSnakeCase("javascript is fun"));   // Output: "JAVASCRIPT_IS_FUN"


What return value do you expect from the following function call?

toUpperSnakeCase("hello there"); // three spaces between the two words

If the function toUpperSnakeCase() converts a string to UPPER_SNAKE_CASE then:

Replace spaces (or word separators) with underscores _.

Convert all letters to uppercase.

Because the function doesn't require the multiple white space to normalise (i.e. to collapse into one) then we might get multiple underscores resulting in the following output:

"HELLO___THERE"

Does your function return "HELLO___THERE" when the parameter is "hello there"?

github-actions · 2025-11-08T13:35:35Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T13:35:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T16:51:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

carlosyabreu · 2025-11-08T16:57:49Z

Afternoon CJ Yuan

Thanks for reviewing my PR.
I've updated and cleaned the (coursework/sprint-2) branch.
There is no more Sprint-1 folder on that branch.
Cheers

cjyuan · 2025-11-08T17:06:34Z

Good job in fixing the branch.

The last component in the PR title should be just "Coursework" (instead of the module name)
The PR description still contains some placeholder text. Can you update the PR description according to the PR Guideline so that it can pass the automated Validate PR Metadata check?
Can you also respond to my inline comment made on Sprint-2/3-mandatory-implement/2-cases.js?

github-actions · 2025-11-08T17:06:56Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T20:08:12Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T20:13:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T20:25:45Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-11-09T04:10:22Z

The text in the "Questions" section still appear in the PR description.
May I suggest looking up how to comment text in Markdown encoded text?

carlosyabreu added 24 commits November 3, 2025 00:14

Increase by 1 the variable count

e1447e3

Assignment operator equal

f184b29

2-initials.js first letters of the variables

d88693e

Directory and extension part of a file path

ad07e16

Explanation of 4-random.js file

fc159be

Using comment to explain the information contain in the file, useful …

92d1f33

…only for developers

Change keyword 'const' to 'let' to assign variable

204a98d

Variable must be declared first before it can be used

b9538b2

Extracting the last 4 digits and display it

5b6a38f

Change variable naming starting with letter instead of numbers

57e97e9

Change function replaceAll arguments adding commas to separate its pa…

7e75245

…rameters and use Number function to convert into a Number

commit 2-time-format.js and 3-to-pounds.js

a36e485

Add alert and prompt function explanation

94b7128

Console.log and Console and property

269ce23

Correct a function with let defined inside it

4818ddd

Change the local variable to be called from global scope

992f376

Change a literal numerical value as parameter for a variable expect b…

607ca58

…y a function

Commit 0.js and 1.js files

79b52ed

Change the function to display the last digit correctly

6b17b68

Correct the BMI function and the necessary explanation

e29954a

Change small letter into capital letter

9577ac5

Different display of pounds

2b746b1

Test of function at different scenarios

886d971

Display time in usual format

d34a28d

carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 8, 2025

cjyuan reviewed Nov 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

Delete Sprint-1 folder

da83341

carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 8, 2025

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 8, 2025

carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 8, 2025

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 9, 2025

Uh oh!

London | 25-ITP-September | Carlos Abreu | Sprint 2 | Coursework #860

Are you sure you want to change the base?

London | 25-ITP-September | Carlos Abreu | Sprint 2 | Coursework #860

Conversation

carlosyabreu commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

carlosyabreu Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

carlosyabreu commented Nov 8, 2025

Uh oh!

cjyuan commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

cjyuan commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

carlosyabreu commented Nov 8, 2025 •

edited

Loading