West Midlands | 25-ITP-Sept | Ali Naru | Sprint 2 | Coursework/sprint-2 #840
Conversation
…ons and explanations
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
…vertToPercentage function
…ons and explanations
… and explanations
…ions and explanations
…time formatting questions
MohammedNaru
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (Sprint-2) doesn't match expected format (example: 'Sprint 2', without quotes) If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
MohammedNaru
changed the title
MohammedNaru
changed the title
MohammedNaru
added
Needs Review
| function convertToPercentage(decimalNumber) { | ||
| decimalNumber = 0.5; | ||
| const percentage = `${decimalNumber * 100}%`; | ||
|
|
||
| return percentage; |
There was a problem hiding this comment.
- This is an incomplete implementation of the function.
- This function will always return "50%", which is not very useful. Can you improve its reusability so that it can be used to convert any number to an equivalent string in percentage format?
|
|
||
| function calculateBMI(weight, height) { | ||
| const bmi = weight / (height * height); | ||
| return bmi.toFixed(1); |
There was a problem hiding this comment.
What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?
Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,
console.log(123); // Output 123
console.log("123"); // Output 123
// Treated differently in the program
let sum1 = 123 + 100; // Evaluate to 223 -- a number
let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.
cjyuan
added
Reviewed
2 participants
Sprint 2 Coursework
Self checklist
Changelist
Currently working on Pr
Questions
No questions currently