-
-
Notifications
You must be signed in to change notification settings - Fork 240
London| 25-ITP-Sep | Sophia Mohamed| Sprint 3|Coursework/sprint-3-implement-and-rewrite #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
7312985
113d089
12ae68f
258000e
aacec30
080b931
ae44017
2ab5c7f
51bb59d
cc59b53
b84aff7
108b8cc
bfff323
b3b5952
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,18 +6,34 @@ | |
| // The assertion error will tell you what the expected output is | ||
| // Write the code to pass the test | ||
| // Then, write the next test! :) Go through this process until all the cases are implemented | ||
|
|
||
| // Run the tests, work out what Case 2 is testing, and implement the required code here. | ||
| // Case 1: Right angle | ||
| function getAngleType(angle) { | ||
| if (angle === 90) { | ||
| return "Right angle"; | ||
| } | ||
| // Case 2: Acute angle | ||
| else if (angle < 90) { | ||
| return "Acute angle"; | ||
| } | ||
| // Run the tests, work out what Case 2 is testing, and implement the required code here. | ||
| // Then keep going for the other cases, one at a time. | ||
| } | ||
|
|
||
| // Case 3: Obtuse angle | ||
| else if (angle > 90 && angle < 180) { | ||
| return "Obtuse angle"; | ||
| } | ||
| // Case 4: Straight angle | ||
| else if (angle === 180) { | ||
| return "Straight angle"; | ||
| } | ||
| // Case 5: Reflex angle | ||
| else if (angle > 180 && angle < 360) { | ||
| return "Reflex angle"; | ||
| } | ||
| else { | ||
| return "Invalid angle"; // Optional: handles 0 or ≥ 360 | ||
| } | ||
| } | ||
| // The line below allows us to load the getAngleType function into tests in other files. | ||
| // This will be useful in the "rewrite tests with jest" step. | ||
| module.exports = getAngleType; | ||
|
|
||
| // we're going to use this helper function to make our assertions easier to read | ||
| // if the actual output matches the target output, the test will pass | ||
|
|
@@ -50,14 +66,25 @@ assertEquals(acute, "Acute angle"); | |
| // When the angle is greater than 90 degrees and less than 180 degrees, | ||
| // Then the function should return "Obtuse angle" | ||
| const obtuse = getAngleType(120); | ||
| assertEquals(obtuse, "Obtuse angle"); | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
|
|
||
| // Case 4: Identify Straight Angles: | ||
| // When the angle is exactly 180 degrees, | ||
| // Then the function should return "Straight angle" | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| const straight = getAngleType(180); | ||
| assertEquals(straight, "Straight angle"); | ||
|
|
||
| // Case 5: Identify Reflex Angles: | ||
| // When the angle is greater than 180 degrees and less than 360 degrees, | ||
| // Then the function should return "Reflex angle" | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
| // ====> write your test here, and then add a line to pass the test in the function above const reflex = getAngleType(270); | ||
| const reflex = getAngleType(270); | ||
| assertEquals(reflex, "Reflex angle"); | ||
|
|
||
| //console.assert(reflex === "Reflex angle", `Expected ${reflex} to equal Reflex angle`); | ||
|
||
|
|
||
|
|
||
|
|
||
| module.exports = getAngleType; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,20 @@ | ||
| // Implement a function isProperFraction | ||
| // Write assertions for your function to check it works in different cases | ||
| // Terms: | ||
| // Terms:A proper fraction is when: | ||
| //the absolute value of the numerator is less than the denominator | ||
|
|
||
| // Fractions: https://www.bbc.co.uk/bitesize/topics/zt9n6g8/articles/zjxpp4j | ||
| // Written here like this: 1/2 == Numerator/Denominator | ||
| // the first test and first case is written for you | ||
| // complete the rest of the tests and cases | ||
| // write one test at a time, and make it pass, build your solution up methodically | ||
| // 1-complete the rest of the tests and cases | ||
|
|
||
| // 2-write one test at a time, and make it pass, build your solution up methodically | ||
| //1- | ||
| function isProperFraction(numerator, denominator) { | ||
| if (numerator < denominator) { | ||
| if (Math.abs(numerator) < Math.abs(denominator)) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -33,7 +38,6 @@ function assertEquals(actualOutput, targetOutput) { | |
| // Explanation: The fraction 2/3 is a proper fraction, where the numerator is less than the denominator. The function should return true. | ||
| const properFraction = isProperFraction(2, 3); | ||
| assertEquals(properFraction, true); | ||
|
|
||
| // Improper Fraction check: | ||
| // Input: numerator = 5, denominator = 2 | ||
| // target output: false | ||
|
|
@@ -46,14 +50,20 @@ assertEquals(improperFraction, false); | |
| // target output: true | ||
| // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true. | ||
| const negativeFraction = isProperFraction(-4, 7); | ||
| // ====> complete with your assertion | ||
| assertEquals(negativeFraction, true); | ||
|
|
||
|
|
||
| // Equal Numerator and Denominator check: | ||
| // Input: numerator = 3, denominator = 3 | ||
| // target output: false | ||
| // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false. | ||
| const equalFraction = isProperFraction(3, 3); | ||
| // ====> complete with your assertion | ||
| assertEquals(equalFraction, false); | ||
|
|
||
|
|
||
|
|
||
| // Stretch: | ||
| // What other scenarios could you test for? | ||
| const negativeDenominator = isProperFraction(3, -5); | ||
| assertEquals(negativeDenominator, true); | ||
| const bothNegative = isProperFraction(-2, -6); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looks like this one is missing assert
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added the assert |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,9 +8,17 @@ | |
| // write one test at a time, and make it pass, build your solution up methodically | ||
| // just make one change at a time -- don't rush -- programmers are deep and careful thinkers | ||
| function getCardValue(card) { | ||
| const rank = card.slice(0, -1); | ||
| if (rank === "A") { | ||
| return 11; | ||
| } | ||
| if (["J", "Q", "K", "10"].includes(rank)) { | ||
|
||
| return 10; | ||
| } else if (!isNaN(rank)) { | ||
| return Number(rank); | ||
| } else { | ||
| throw new Error("Invalid card rank."); | ||
| } | ||
| } | ||
|
|
||
| // The line below allows us to load the getCardValue function into tests in other files. | ||
|
|
@@ -39,19 +47,40 @@ assertEquals(aceofSpades, 11); | |
| // When the function is called with such a card, | ||
| // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5). | ||
| const fiveofHearts = getCardValue("5♥"); | ||
| assertEquals(fiveofHearts, 5); | ||
| assertEquals(getCardValue("2♣"), 2); | ||
| assertEquals(getCardValue("3♣"), 3); | ||
| assertEquals(getCardValue("4♣"), 4); | ||
| assertEquals(getCardValue("5♥"), 5); | ||
| assertEquals(getCardValue("6♦"), 6); | ||
| assertEquals(getCardValue("7♠"), 7); | ||
| assertEquals(getCardValue("8♠"), 8); | ||
| assertEquals(getCardValue("9♥"), 9); | ||
| // ====> write your test here, and then add a line to pass the test in the function above | ||
|
|
||
| // Handle Face Cards (J, Q, K): | ||
| // Given a card with a rank of "10," "J," "Q," or "K", | ||
| // When the function is called with such a card, | ||
| // Then it should return the value 10, as these cards are worth 10 points each in blackjack. | ||
| const tenOfDiamonds = getCardValue("10♦"); | ||
| assertEquals(tenOfDiamonds, 10); | ||
|
|
||
| const jackOfClubs = getCardValue("J♣"); | ||
| assertEquals(jackOfClubs, 10); | ||
|
|
||
| const queenOfDiamonds = getCardValue("Q♦"); | ||
| assertEquals(queenOfDiamonds, 10); | ||
|
|
||
| const kingOfHearts = getCardValue("K♥"); | ||
| assertEquals(kingOfHearts, 10); | ||
|
|
||
| // Handle Ace (A): | ||
| // Given a card with a rank of "A", | ||
| // When the function is called with an Ace, | ||
| // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack. | ||
|
|
||
| assertEquals(getCardValue("A♠"), 11); | ||
| // Handle Invalid Cards: | ||
| // Given a card with an invalid rank (neither a number nor a recognized face card), | ||
| // When the function is called with such a card, | ||
| // Then it should throw an error indicating "Invalid card rank." | ||
| assertEquals(() => getCardValue("B♦"), "Invalid card rank."); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,32 @@ | ||
| // This statement loads the getCardValue function you wrote in the implement directory. | ||
| // We will use the same function, but write tests for it using Jest in this file. | ||
| const getCardValue = require("../implement/3-get-card-value"); | ||
|
|
||
| // Case 1: Handle Ace (A): | ||
| test("should return 11 for Ace of Spades", () => { | ||
| const aceofSpades = getCardValue("A♠"); | ||
| expect(aceofSpades).toEqual(11); | ||
| }); | ||
|
|
||
| // Case 2: Handle Number Cards (2-10): | ||
| test("should return correct values for number cards 2-9", () => { | ||
| expect(getCardValue("2♣")).toEqual(2); | ||
| expect(getCardValue("3♣")).toEqual(3); | ||
| expect(getCardValue("4♣")).toEqual(4); | ||
| expect(getCardValue("5♥")).toEqual(5); | ||
| expect(getCardValue("6♦")).toEqual(6); | ||
| expect(getCardValue("7♠")).toEqual(7); | ||
| expect(getCardValue("8♠")).toEqual(8); | ||
| expect(getCardValue("9♥")).toEqual(9); | ||
| }); | ||
| // Case 3: Handle Face Cards (J, Q, K): | ||
| // Case 4: Handle Ace (A): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you are missing this test case. Could you please add it? |
||
| // Case 5: Handle Invalid Cards: | ||
| test("should return 10 for face cards J, Q, K and 10", () => { | ||
| expect(getCardValue("10♦")).toEqual(10); | ||
| expect(getCardValue("J♣")).toEqual(10); | ||
| expect(getCardValue("Q♦")).toEqual(10); | ||
| expect(getCardValue("K♥")).toEqual(10); | ||
| }); | ||
|
|
||
| // Case 4: Handle Invalid Cards: | ||
| test("should throw an error for invalid card rank", () => { | ||
| expect(() => getCardValue("B♦")).toThrow("Invalid card rank."); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is a bit misleading. Is this optional or default? Those are two different things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed line 32, there was no need to add an Invalid angle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should keep it, it's a nice default case or it could be a good if condition to catch invalid values for angle parameter. Either way, you should have one of them. Think of it this way, if your angle value is 500 or -1, how will your function behave?