Skip to content

London | 25-ITP-Sep | Zadri Abdule | Sprint 1 | Module Structuring & Testing Data #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-Sep | Zadri Abdule | Sprint 1 | Module Structuring & Testing Data #837

wants to merge 15 commits into from

Conversation

@Zadri415
Copy link

@Zadri415 Zadri415 commented Nov 1, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all of the tasks for Sprint 1 of Module Structuring & Testing Data.

Questions

Ask any questions you have for your reviewer.
Not at the moment.

Zadri415 added 13 commits October 14, 2025 20:50
@Zadri415
Explain assignment in count increment example
7995c8d
@Zadri415
Add intitials variables charAt method
5213e77
@Zadri415
Add dir and ext variables
c77a3cf
@Zadri415
Add explanatory comments to random number generator code
ba118b5
@Zadri415
Comment out instruction lines so they are not executed
d5dfe95
@Zadri415
Change age variable from const to let to allow reassignment
5c9289a
@Zadri415
Add comment explaining instialization error
8f743b2
@Zadri415
Add predict that the code will fail because .slice() is not valid on …
095d155 
…a number
@Zadri415
Predict that the code will fail because .slice() is not valid on a nu…
e054a32 
…mber
@Zadri415
Fix: renamed variable starting with a number to follow JS naming rules
6ea69f1
@Zadri415
Added MDN-based explanation,and documented variable declarations
40825f8
@Zadri415
Completed answers for 2-time-format.js
5f00dde
@Zadri415
Added line-by-line explanations for 3-to-pounds.js
265ee10
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Zadri415 Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Zadri415 Zadri415 added the Module-Structuring-And-Testing-Data The name of the module. label Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Zadri415 Zadri415 changed the title London | 25-ITP-Sep | Zadri Abdule | Sprint 1 | Coursework London | 25-ITP-Sep | Zadri Abdule | Sprint 1 | Module Structuring & Testing Data Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

3 similar comments
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Zadri415 Zadri415 removed the Module-Structuring-And-Testing-Data The name of the module. label Nov 2, 2025
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor
LonMcGregor reviewed Nov 3, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing to fix in file 1.js

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 3, 2025
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zadri415 @LonMcGregor