London | 25-ITP-SEP | Mariia Serhiienko| Sprint 2 | Coursework/sprint-2 #832

Konvaly · 2025-11-01T04:46:36Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

This PR covers work across all main sections of the sprint project:

Errors: Checked each file in the errors folder, predicted and explained what errors occur, and why they happen.

Debug: Found and fixed issues in the debug files, explaining why the code wasn’t working and verifying the fixes.

Implement: Built and tested functions for 1-bmi.js, 2-cases.js, and 3-to-pounds.js to meet the given requirements.

Interpret: Reviewed and explained how the larger programs work, using console.log and docs to understand unfamiliar parts.

Extend: Wrote tests and fixed any bugs for the 24-hour to 12-hour time conversion function.

All tasks now run correctly, with clear explanations and working code throughout.

github-actions · 2025-11-01T04:46:52Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T04:57:23Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T04:57:23Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

jennethydyrova

Hi @Konvaly! Very clean code, nice work! There are couple of issues I pinpointed, could you please address those?

Also, could you please remove package-lock.json file from this PR as it's not related?

jennethydyrova · 2025-11-03T16:20:29Z

Sprint-2/1-key-errors/0.js

+  let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`;
+  return capitalisedStr;


This is correct but can you think of a way to simplify it? Also, does it need to be let?

Yes, "const" might be better option, cause I don't need to change "capitalisedStr" in next evalutaion of my function.
About simplifying - actually I can return the result without any defined variable.

jennethydyrova · 2025-11-03T16:22:42Z

Sprint-2/1-key-errors/1.js

+  const percentage = `${decimalNumber * 100}%`;
+
+  return percentage;


Same as my previous comment for capitalise function, can you think of a way to simplify it?

I simplified this function in the same way like with previous task :)

jennethydyrova · 2025-11-03T16:24:08Z

Sprint-2/2-mandatory-debug/0.js

 // Predict and explain first...

-// =============> write your prediction here
+// =============> I think the result will be undefined because in the function there is no return statement.


Very good guess!

jennethydyrova · 2025-11-03T16:24:42Z

Sprint-2/2-mandatory-debug/0.js


 // Finally, correct the code to fix the problem
-//  =============> write your new code here
+//  =============> function multiply(a, b) {


I think you would want to comment out the broken code and have your fixed code uncommented. Same for other files.

Thank you! It was confusing for me because there weren't some clear instructions about what do I have to comment/uncomment.
Now I've done this due to your recommendation.

I'll note this!

jennethydyrova · 2025-11-03T16:25:23Z

Sprint-2/2-mandatory-debug/2.js

 // Predict the output of the following code:
-// =============> Write your prediction here
+// =============> The output will be:
+// 1. The last digit of 42 is 3


jennethydyrova · 2025-11-03T16:26:59Z

Sprint-2/2-mandatory-debug/2.js

 // Finally, correct the code to fix the problem
-// =============> write your new code here
-
+//=============> const num = 103;


I think the point of this exercise is not to declare any global variables and just pass all the numbers as function arguments

I also thought about it , but I was sure that I have to change only function. My bad!

jennethydyrova · 2025-11-03T16:28:21Z

Sprint-2/3-mandatory-implement/2-cases.js

 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+
+function toUpperCaseSnakeString(str) {


This is fine but could be better. Do you need to say string here? Think of other string methods such as toUpperCase or to toLowerCase. Can you think of a better name?

You're right, I changed this name to "toUpperSnakeCase".

Konvaly · 2025-11-05T13:06:44Z

Hi @Konvaly! Very clean code, nice work! There are couple of issues I pinpointed, could you please address those?

Also, could you please remove package-lock.json file from this PR as it's not related?

jennethydyrova · 2025-11-05T16:16:09Z

Hi @Konvaly! All your answers are correct but I don't see changes applied. Did you forget to push?

Konvaly · 2025-11-05T19:58:14Z

Hi @jennethydyrova !

I've pushed it just now and added some tests and fixed bugs in 5-stretch-extend.js.
I really appreciate your time and detailed feedback , it helped me spot a few things I’d missed!

jennethydyrova · 2025-11-06T16:00:44Z

hi @Konvaly ! I am happy to approve this PR but you have your pipeline failing. Can you please fix it?

Konvaly added 11 commits October 31, 2025 23:59

Initial commit

8907408

Solved task 1-key-errors/0.js

e113639

Solved task 1-key-errors/1.js

83a2f87

Solved task 1-key-errors/2.js

ea085d9

Solved task 2-mandatory-debug/0.js

2d4152e

Solved task 2-mandatory-debug/1.js

0b216d5

Solved task 2-mandatory-debug/2.js

e0d30d1

Solved task 3-mandatory-implement/1-bmi.js

ec8c0e5

Solved task 3-mandatory-implement/2-cases.js

0606e40

Solved task 3-mandatory-implement/3-to-pounds.js

b4c62e1

Solved task 4-mandatory-interpret/time-format.js

f5ab7c1

Konvaly added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 1, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 3, 2025

jennethydyrova suggested changes Nov 3, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 3, 2025

Remove package-lock.json from tracking

9d2753f

Fixed and updated files in Sprint-2

83547a2

Konvaly added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 5, 2025

jennethydyrova removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 6, 2025

Konvaly added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 7, 2025

Konvaly requested a review from jennethydyrova November 7, 2025 07:26

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

		let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`;
		return capitalisedStr;

		const percentage = `${decimalNumber * 100}%`;

		return percentage;

Uh oh!

London | 25-ITP-SEP | Mariia Serhiienko| Sprint 2 | Coursework/sprint-2 #832

Are you sure you want to change the base?

London | 25-ITP-SEP | Mariia Serhiienko| Sprint 2 | Coursework/sprint-2 #832

Uh oh!

Conversation

Konvaly commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Konvaly commented Nov 5, 2025

Uh oh!

jennethydyrova commented Nov 5, 2025

Uh oh!

Konvaly commented Nov 5, 2025

Uh oh!

jennethydyrova commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants