Skip to content

Manchester | 25-ITP-May | Mahtem T. Mengstu| Sprint 1 | Coursework/Sprint 1 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Manchester | 25-ITP-May | Mahtem T. Mengstu| Sprint 1 | Coursework/Sprint 1 #780

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d6c5c0b
Described what line 3 is doing
Mahtem Oct 17, 2025
2ae5aaa
Declare a variable called initials that stores the first character of…
Mahtem Oct 17, 2025
ebd4d3e
Describe what line 3 is doing.
Mahtem Oct 17, 2025
7eb19b3
Described what line three is doing.
Mahtem Oct 17, 2025
f683d85
Described what line three is doing.
Mahtem Oct 17, 2025
76e6a40
Declared a variable named initials
Mahtem Oct 17, 2025
b9a5530
Created dir and ext variables
Mahtem Oct 17, 2025
fc1f2d4
Described what the prpgram is doing
Mahtem Oct 17, 2025
927521c
Modified
Mahtem Oct 18, 2025
7db8109
Modified
Mahtem Oct 18, 2025
97637ad
Added codewar related code
Mahtem Oct 18, 2025
5dab8a6
Used template string to display initials
Mahtem Oct 18, 2025
6e76b0d
Differentiated const and let
Mahtem Oct 18, 2025
6ac3015
Corrected typo
Mahtem Oct 18, 2025
1e97c2e
Suggested better names in "camel case"
Mahtem Oct 18, 2025
4010b4d
corrected name suggestion according to camelCase
Mahtem Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sprint-1/3-mandatory-interpret/2-time-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,16 @@ console.log(result);

// Ans: the variable result represent total movie lenght, Movie duration_hr_min_sec would be better name.
Copy link

@CameronDowner CameronDowner Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Javascript, the convention is to use "camel case". This would be perfect for a language like Python 🙂

Could you suggest one in camel case?

See this article: link


// In a "camel case" the following options would be better names
// 1. MovieDurationHrMinSec
// 2. TotalMovieSpan
// 3. TotalMoviePeriod
Copy link

@CameronDowner CameronDowner Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we call PascalCase (the first letter is capatalised) which is not quite right for this

  • camelCase
  • PascalCase
  • snake_case
  • kebab-case

Each language will have a convention of using a certain case - for Javascript it's camelCase


// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer

// Ans: I have tried with different values and it seems to work for all values, but it needs to validate to avoid entering negative values
// I inserted --3500 and returned 0: -58: -20 which does not mean real time representation.


// Corrected typo reminder -----> remainder
// Suggested better names in "camel case" a convention in Javascript